OOP help

[fantomel]

<?php
 
 
 /*
Create the mysql class_exists
*/
 
    class mysql
    {
 
        var $MYSQL_user = DBUSER;//MySQL username variable
        var $MYSQL_pass = DBPASS;//MySQL password variable
        var $MYSQL_host = DBHOST;//MySQL host variable - usually localhost
        var $MYSQL_db = DB;//MySQL database variable
 
        var $connect;
        var $get_db;
 
        function __construct(   ) {//PHP 5 Constructor
 
            $this->Connect(   );
        }
 
        function mysql(   ) {//PHP 4 constructor
 
            $this->Connect(   );
 
        }
 
        function Connect(   ) {//Create a function called Connect that is responsible for connecting to the mysql db
 
            $this->connect = mysql_connect($this->MYSQL_host, $this->MYSQL_user, $this->MYSQL_pass)or die(mysql_error(   ));
              $this->get_db = mysql_select_db($this->MYSQL_db) or die(mysql_error().__LINE__.__FILE__);
        }//End function
 
 
        function __destruct(   ) {//Automatically closes the mysql connection
            mysql_close(   $this->connect   );
 
        }
 
/*
The queries
*/
 
        function GetUserLogin($username, $password) { //Create a new function that requires you define the vars $username and $password when initiating
 
            $query = "
            SELECT username, id, password FROM `users` 
            WHERE
            `username` = '". $username ."' 
            AND 
            `password` = '". $password ."' 
            AND
            `banned` = 'n' 
            LIMIT 1; 
            ";//Create the MySQL query and make sure they arent banned
            return $query; //Return the query string
        }
 
 
        function GetUser(   $username   ) {//Create a function that gets a users info
 
            $query = "
            SELECT username, id, email FROM `users` 
            WHERE 
            `username` = '". $username ."' 
            LIMIT 1; 
            ";//Create the MySQL query and make sure they arent banned
 
            return $query; //Return the query string
        }
 
 
        function RegisterUser(   $username, $password, $email, $ip   ) {//Create a new function that requires certain variables
            $query = "
            INSERT INTO `users`
            (`username`, `password`, `email`, `ip`, `level`)
            VALUES
            ('". $username ."', '". $password ."', '". $email ."', '". $ip ."', '1');
            ";//Create a MySQL query that inserts values into the database
 
            return $query; //Return the query string
        }
 
 
    }//End class
 
 
 
 
 
?>

on line 43 i have a problem gives error

Warning on line 43,
mysql_close(): 5 is not a valid MySQL-Link resource,
in C:\xampp\htdocs\xgame\classes\mysql.php


can someone help me please ?

[Markus]

Is there any need for $this->connect.
When mysql_close is called, it closes the last opened connection.

[pbmods]

Heya, fantomel.

You might as well get rid of the PHP-5-style constructor; this class is a PHP 4 class, and PHP 5 is backwards compatible.

My guess is that at the time the destructor is called, mysql_close() has already been called somewhere else.

[r035198x]

1.) That's a warning not an error
2.) Why don't you post the code you executed that gave you the warning.