shortening code

[vern]

Just curious, how would I shorten the following code?

$sql_forum_posts_num = "SELECT forum_posts FROM ".
$db_db.".phpbb_forums WHERE forum_id = '$forum_id'";
$forum_posts_num = mysql_query($sql_forum_posts_num) or
die(mysql_error());
$forum_posts_num_real = mysql_fetch_row($forum_posts_num);
$forum_posts_real_num = $forum_posts_num_real[0] + $num_topics_real;
$forum_topics_num_update_sql = "UPDATE ".$db_db.".phpbb_forums SET
forum_posts = '$forum_posts_real_num' WHERE forum_id = '$forum_id'";
mysql_query($forum_topics_num_update_sql) or die(mysql_error());

6 lines for something so simple seems so much. Is there any syntax I
can change to cut this down?

[Rik Wasmus]

On Tue, 13 May 2008 02:10:57 +0200, vern <vw******@gmail.comwrote:

Just curious, how would I shorten the following code?

$sql_forum_posts_num = "SELECT forum_posts FROM ".
$db_db.".phpbb_forums WHERE forum_id = '$forum_id'";
$forum_posts_num = mysql_query($sql_forum_posts_num) or
die(mysql_error());
$forum_posts_num_real = mysql_fetch_row($forum_posts_num);
$forum_posts_real_num = $forum_posts_num_real[0] + $num_topics_real;
$forum_topics_num_update_sql = "UPDATE ".$db_db.".phpbb_forums SET
forum_posts = '$forum_posts_real_num' WHERE forum_id = '$forum_id'";
mysql_query($forum_topics_num_update_sql) or die(mysql_error());

6 lines for something so simple seems so much. Is there any syntax I
can change to cut this down?

Shorter code isn't always better. If it works I'd leave it, escpecially
since it seems to be from the phpBB packages, and manually altering files
could result in a much more troublesome update.

However there is offcourse a simpler way:

mysql_query("UPDATE {$db_db}.phpbb_forums SET forum_posts = forum_posts
+ $num_topics_real WHERE forum_id = $forum_id");

Keep SQL injection in mind...
--
Rik Wasmus
[SPAM] Now temporarily looking for some smaller PHP/MySQL projects/work to
fund a self developed bigger project, mail me at rik at rwasmus.nl. [/SPAM]

[=?ISO-8859-1?Q?=22=C1lvaro_G=2E_Vicario=22?=]

vern escribió:

$sql_forum_posts_num = "SELECT forum_posts FROM ".
$db_db.".phpbb_forums WHERE forum_id = '$forum_id'";
$forum_posts_num = mysql_query($sql_forum_posts_num) or
die(mysql_error());
$forum_posts_num_real = mysql_fetch_row($forum_posts_num);
$forum_posts_real_num = $forum_posts_num_real[0] + $num_topics_real;
$forum_topics_num_update_sql = "UPDATE ".$db_db.".phpbb_forums SET
forum_posts = '$forum_posts_real_num' WHERE forum_id = '$forum_id'";
mysql_query($forum_topics_num_update_sql) or die(mysql_error());

This code seems to put a lot of effort in creating unique names for
variables that do not seem of any use outside this block. I'd say that
replacing stuff like $sql_forum_posts_num and
$forum_topics_num_update_sql with $sql would be a sort of improvement.
Also, some blank lines would make it look less like a brick.

--
-- http://alvaro.es - Álvaro G. Vicario - Burgos, Spain
-- Mi sitio sobre programación web: http://bits.demogracia.com
-- Mi web de humor al baño María: http://www.demogracia.com
--

[AnrDaemon]

Greetings, vern.
In reply to Your message dated Tuesday, May 13, 2008, 04:10:57,

Just curious, how would I shorten the following code?

$sql_forum_posts_num = "SELECT forum_posts FROM ".
$db_db.".phpbb_forums WHERE forum_id = '$forum_id'";
$forum_posts_num = mysql_query($sql_forum_posts_num) or
die(mysql_error());
$forum_posts_num_real = mysql_fetch_row($forum_posts_num);
$forum_posts_real_num = $forum_posts_num_real[0] + $num_topics_real;
$forum_topics_num_update_sql = "UPDATE ".$db_db.".phpbb_forums SET
forum_posts = '$forum_posts_real_num' WHERE forum_id = '$forum_id'";
mysql_query($forum_topics_num_update_sql) or die(mysql_error());

6 lines for something so simple seems so much. Is there any syntax I
can change to cut this down?

For me, I'd just trow away the database prefix and use mysql_select_db()
instead.
It's rare case when I need to work with more than one database in a single script.
--
Sincerely Yours, AnrDaemon <an*******@freemail.ru>