Simple Login using Ms Access ODBC

[Yew12]

I am trying to create a simple login for my webpage, but Im a bit of a novice and cannot see where Im going wrong any help would be much appreciated.

I'm using an access database and ODBC.

The code I have got is below;

[PHP]<?php

$tbl_name="tblCustomer";

$connstr = "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" . realpath("2PointB.mdb").";";
$conn=odbc_connect($connstr,'','') or die(Print "connect error: ".odbc_error());

$username=$_POST['username'];
$password=$_POST['password'];

$username = stripslashes($username);
$password = stripslashes($password);

$sql="SELECT * FROM $tbl_name WHERE username='$username' and password='$password'";
$stmt=odbc_prepare($conn, $sql) or die (Print "odbc prepare error".odbc_error());
$result=odbc_exec($stmt) or die (Print "result error ".odbc_error());

$count=odbc_num_rows($result);

if($count==1){

session_register("username");
session_register("password");
header("location:/wfolder/Logon2.php");
}
else {
echo "Wrong Username or Password";
}

odbc_close($stmt);

?>[/PHP]

Thanks

[ronverdonk]

Assuming you have a separate login script/form that you have not shown here.

I am unable to guess about "where Im going wrong " and I really don't want to, so: what is the problem you encounter? Any error messages? What exactly does not work? What have you debugged so far in your code?

Ronald

[Yew12]

Sorry I will try to clarify,

I have one HTML page with two input boxes on and it passes the variables username and password to this php script where I want to check to see if they are valid and if so send them to another page, if not then display message "Wrong Login".

Any other questions just ask.

[ronverdonk]

I understand how it is supposed to work, but I asked you how you know it does not work and what problems you have! Like an error messgae, system hang, nothing at all, sql error, etc.

A more general remark on the code: do not use session_register, it is deprecated.

If you want your script to work regardless of register_globals, you need to instead use the $_SESSION array as $_SESSION entries are automatically registered. If your script uses session_register(), it will not work in environments where the PHP directive register_globals is disabled.

Ronald

[Yew12]

I get the result error. with out a odbc error number.

[ronverdonk]

Your problem is in this statement[php]$result=odbc_exec($stmt) or die (Print "result error ".odbc_error());[/php]This statement says: prepare and execute an sql statement. You have already prepared, so you must use[php]$result=odbc_execute($stmt) or die (Print "result error ".odbc_error());[/php]So:
odbc_exec — Prepare and execute a SQL statement
odbc_execute — Execute an already prepared statement

Ronald

[Yew12]

Thanks very much, but unfortunatly i still get an 07001.

[ronverdonk]

I cannot find the 7001 error code in the MySQL documentaiton, so why don't you just add the odbc error message to your output like[php]$result=odbc_execute($stmt) or die (Print "result error ".odbc_error().'-'.odbc_errormsg());[/php]so you can see the error reason.

Ronald

[Yew12]

Thanks, added it in the error reads

result error 07001-[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 2.

I have tried looking checking that the names are right and everything but still no luck.

Also thanks for helping a novice you are helping more that you think.

[ronverdonk]

Means you have not changed your odbc_exec into the odbc_execute statement. I.e. odbc_exec requires 2 parameters, odbc_execute requires 1 parameter.

And you really must use odbc_execute because you have already prepared the sql statement in the odbc_prepare!

Ronald

[Yew12]

I have changed it so it now reads

[PHP]$sql="SELECT * FROM $tbl_name WHERE username='$username' and password='$password'";
$stmt=odbc_prepare($conn, $sql) or die (Print "odbc prepare error".odbc_error());
$result=odbc_execute($stmt) or die (Print "result error ".odbc_error().'-'.odbc_errormsg());
[/PHP]

Any other ideas.

Thanks so much

[ronverdonk]

And you still have an error? If so, please show your entire code here and I will try to re-create your problem. If not, fine.

Btw: you do not need the prepare because you have to variables to fill in.

Ronald

[Yew12]

Ok first form the one which get the users input

[PHP]<form name="form1" method="post" action="Logon1.php">
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong>Login </strong></td>
</tr>
<tr>
<td width="78">Username</td>
<td width="6">:</td>
<td width="294"><input name="username" type="text" id="username"></td>
</tr>
<tr>
<td>Password</td>
<td>:</td>
<td><input name="password" type="text" id="password"></td>
</tr>
<tr>
<td>&nbsp;</td>
<td>&nbsp;</td>
<td><input type="submit" name="Submit" value="Login"></td>
</tr>
</table>
</td>
</form>[/PHP]

The second;

[PHP]<?php

$tbl_name="tblCustomer";

$connstr = "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" . realpath("2PointB.mdb").";";
$conn=odbc_connect($connstr,'','') or die(Print "connect error: ".odbc_error());


$username=$_POST['username'];
$password=$_POST['password'];


$username = stripslashes($username);
$password = stripslashes($password);

$sql="SELECT * FROM $tbl_name WHERE username='$username' and password='$password'";
$stmt=odbc_prepare($conn, $sql) or die (Print "odbc prepare error".odbc_error());
$result=odbc_execute($stmt) or die (Print "result error ".odbc_error().'-'.odbc_errormsg());


$count=odbc_num_rows($result);


if($count==1){

session_register("username");
session_register("password");
header("location:/wfolder/Logon2.php");
}
else {
echo "Wrong Username or Password";
}

odbc_close($stmt);

?>[/PHP]

Thaks for your continued support.

[ronverdonk]

1. according to the php documentation, many odbc drivers (Access, DB2, etc) return a wrong result with odbc_num_rows (). So do not use that, use the fetch instead.

2. in order to use the $_SESSION array, start a session at the very beginning of each script file that is going to use the $_SESSION array.

3. since you have no variables to prepare, do not prepare separately but use the obc_exec which is a porepare and execute in one statement.

4. the close had the wrong resource id variable.

5. The following should work[php]<?php
session_start();

$tbl_name="tblCustomer";

$connstr = "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" . realpath("2PointB.mdb").";";
$conn=odbc_connect($connstr,'','')
or die("connect error: ".odbc_error());

// get passed parameters
$username=trim(stripslashes($_POST['username']));
$password=trim(stripslashes($_POST['password']));

$sql="SELECT * FROM $tbl_name WHERE username='$username' and password='$password'";

// prepare and execute in 1 statement
$result=odbc_exec($conn,$stmt)
or die ("result error ".odbc_error().'-'.odbc_errormsg());

// if no result: no rows read
if (!odbc_fetch_row($result))
die("Wrong Username or Password");

// else: all is okay
else {
$_SESSION['username']=$username;
$_SESSION['password']=$password;
header("location:/wfolder/Logon2.php");
}
odbc_close($conn);
?>[/php]

[Yew12]

Sorry for the late repaly.

Everything working as planned

Thanks.

[ronverdonk]

Sorry for the late repaly.

Everything working as planned

Thanks.

You mean my last post contributed or did you find the solution yourself? If the latter, please show us that solution, so we all can learn from it.

Ronald