Problem in code (Update query)

[praveenkrg]

my update query is not working properly!

$mgroupname=$_GET['selectpg'];
//echo $mgroupname;
 
///query for checking userg_id
$result=mysql_query("SELECT * FROM group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{  
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];
 
//echo $userg_id;
//echo $userg_name;
///query for checking userg_id
}  
 
if(isset($_POST['submit']))
{
  $gp_name=$_POST['gp_name'];
  $add_checkbox=$_POST['add_checkbox'];
  $modify_checkbox=$_POST['modify_checkbox'];
  $delete_checkbox=$_POST['delete_checkbox'];
  $view_checkbox=$_POST['view_checkbox'];
 
  //$button=$_POST['button'];
  if(strlen($gp_name)<1)
  {
      print "You did not enter a Group Name.<BR>";
      print "<a href='addgroup.php'>Go Back</a> &amp; Enter a Group Name.";
  }
  //else if(strlen($button)<1)
  //{
      //print "You did not enter a button.";
  //}
  else
  {
    $insertbutton="update group SET userg_name = '$gp_name' where userg_id = 2 ";
    $insertbutton1="update rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = 2";
    mysql_query($insertbutton) or die(mysql_error());
    mysql_query($insertbutton1) or die(mysql_error());
    print "Group modify.<BR>";
    print "<a href='main.php'>Go Back</a>";
  }
}
else
{
    print "<form name='form' action='modifygroup.php' method='post'>";
    print "Modify Group Name:<BR>";
    print "<input type='text' name='gp_name' size='20' value='$userg_name'><BR><BR>";
    print "Modify Permissions:<BR>";
    print "<input type='checkbox' name='add_checkbox' value='1'>";
    print "Manage Users&nbsp;<br>";
    print "<input type='checkbox' name='modify_checkbox' value='1'>";
    print "Update/View own info&nbsp;<br>";
    print "<input type='checkbox' name='delete_checkbox' value='1'>";
    print "Update/View User Salaries/Leave Balance/TDS&nbsp;<br>";
    print "<input type='checkbox' name='view_checkbox' value='1'>";
    print "Update/View User attendance&nbsp;<br><BR><BR>";
    print "<input type='submit' name='submit' value='Update'></form><BR>";
    print "<a href='main.php'>Go Back</a>";
}
 

[rpnew]

my update query is not working properly!

$mgroupname=$_GET['selectpg'];
//echo $mgroupname;

///query for checking userg_id
$result=mysql_query("SELECT * FROM group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];

//echo $userg_id;
//echo $userg_name;
///query for checking userg_id
}

if(isset($_POST['submit']))
{
$gp_name=$_POST['gp_name'];
$add_checkbox=$_POST['add_checkbox'];
$modify_checkbox=$_POST['modify_checkbox'];
$delete_checkbox=$_POST['delete_checkbox'];
$view_checkbox=$_POST['view_checkbox'];

//$button=$_POST['button'];
if(strlen($gp_name)<1)
{
print "You did not enter a Group Name.<BR>";
print "<a href='addgroup.php'>Go Back</a> &amp; Enter a Group Name.";
}
//else if(strlen($button)<1)
//{
//print "You did not enter a button.";
//}
else
{
$insertbutton="update group SET userg_name = '$gp_name' where userg_id = 2 ";
$insertbutton1="update rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = 2";
mysql_query($insertbutton) or die(mysql_error());
mysql_query($insertbutton1) or die(mysql_error());
print "Group modify.<BR>";
print "<a href='main.php'>Go Back</a>";
}
}
else
{
print "<form name='form' action='modifygroup.php' method='post'>";
print "Modify Group Name:<BR>";
print "<input type='text' name='gp_name' size='20' value='$userg_name'><BR><BR>";
print "Modify Permissions:<BR>";
print "<input type='checkbox' name='add_checkbox' value='1'>";
print "Manage Users&nbsp;<br>";
print "<input type='checkbox' name='modify_checkbox' value='1'>";
print "Update/View own info&nbsp;<br>";
print "<input type='checkbox' name='delete_checkbox' value='1'>";
print "Update/View User Salaries/Leave Balance/TDS&nbsp;<br>";
print "<input type='checkbox' name='view_checkbox' value='1'>";
print "Update/View User attendance&nbsp;<br><BR><BR>";
print "<input type='submit' name='submit' value='Update'></form><BR>";
print "<a href='main.php'>Go Back</a>";
}

Hi,
What is the problem or error you're getting?

Regards,
RP

[praveenkrg]

Hi,
What is the problem or error you're getting?

Regards,
RP

Actually i am not getting any error but this code is not working properly.

I have fetched the values using this command

$result=mysql_query("SELECT * FROM tez_ems_group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];

echo $userg_id;
echo $userg_name;
}

till here it runs fine but after this i have a submit button. some where in the middle of the code

i have written this

else
{
$insertbutton="update tez_ems_group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";
$insertbutton1="update tez_ems_rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = '$userg_id'";
mysql_query($insertbutton) or die(mysql_error());
mysql_query($insertbutton1) or die(mysql_error());


Before the submit button $userg_id prints the values but in this line

$insertbutton="update tez_ems_group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";

it doesn't print the value. why?

[rpnew]

Actually i am not getting any error but this code is not working properly.

I have fetched the values using this command

$result=mysql_query("SELECT * FROM tez_ems_group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];

echo $userg_id;
echo $userg_name;
}

till here it runs fine but after this i have a submit button. some where in the middle of the code

i have written this

else
{
$insertbutton="update tez_ems_group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";
$insertbutton1="update tez_ems_rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = '$userg_id'";
mysql_query($insertbutton) or die(mysql_error());
mysql_query($insertbutton1) or die(mysql_error());


Before the submit button $userg_id prints the values but in this line

$insertbutton="update tez_ems_group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";

it doesn't print the value. why?

Hi,
I'm not sure about this but... you have this problem.... that you are fetching values using 'WHILE' loop and you are not getting it outside the 'WHILE' loop and thats what happens as per my PHP knowledge. If you want to be sure for this try 'echoing' your value outside the while loop. so if you want to do anything with those value. Put all those code in the while loop(and from your first post. i think you need to put your IF-ELSE into while. But be aware it will run as many times as that while loop runs so change accordingly if needed or get back here again)
Thats my solution. Try that or let someone come with better solution..

Regards,
RP

[praveenkrg]

Hi,
I'm not sure about this but... you have this problem.... that you are fetching values using 'WHILE' loop and you are not getting it outside the 'WHILE' loop and thats what happens as per my PHP knowledge. If you want to be sure for this try 'echoing' your value outside the while loop. so if you want to do anything with those value. Put all those code in the while loop(and from your first post. i think you need to put your IF-ELSE into while. But be aware it will run as many times as that while loop runs so change accordingly if needed or get back here again)
Thats my solution. Try that or let someone come with better solution..

Regards,
RP

Hi,
when i put my IF-ELSE part in WHILE loop then it display nothing.

[rpnew]

Hi,
when i put my IF-ELSE part in WHILE loop then it display nothing.

Hi,
Can you post your new code here??
And one more thing i would like you to check is make sure that all your loops and conditions are working accordingly...
Regards,
RP

[praveenkrg]

Hi,
Can you post your new code here??
And one more thing i would like you to check is make sure that all your loops and conditions are working accordingly...
Regards,
RP

Here is my new code:
$mgroupname=$_GET['selectpg'];
//echo $mgroupname;

$result=mysql_query("SELECT * FROM group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];


if(isset($_POST['submit']))
{
$gp_name=$_POST['gp_name'];
$add_checkbox=$_POST['add_checkbox'];
$modify_checkbox=$_POST['modify_checkbox'];
$delete_checkbox=$_POST['delete_checkbox'];
$view_checkbox=$_POST['view_checkbox'];

//$button=$_POST['button'];
if(strlen($gp_name)<1)
{
print "You did not enter a Group Name.<BR>";
print "<a href='addgroup.php'>Go Back</a> &amp; Enter a Group Name.";
}
else
{
$insertbutton="update group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";
$insertbutton1="update tez_ems_rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = '$userg_id'";
mysql_query($insertbutton) or die(mysql_error());
mysql_query($insertbutton1) or die(mysql_error());
print "Group modify.<BR>";
print "<a href='main.php'>Go Back</a>";
}
}
else
{
print "<form name='form' action='modifygroup.php' method='post'>";
print "Modify Group Name:<BR>";
print "<input type='text' name='gp_name' size='20' value='$userg_name'><BR><BR>";
print "Modify Permissions:<BR>";
print "<input type='checkbox' name='add_checkbox' value='1'>";
print "Manage Users&nbsp;<br>";
print "<input type='checkbox' name='modify_checkbox' value='1'>";
print "Update/View own info&nbsp;<br>";
print "<input type='checkbox' name='delete_checkbox' value='1'>";
print "Update/View User Salaries/Leave Balance/TDS&nbsp;<br>";
print "<input type='checkbox' name='view_checkbox' value='1'>";
print "Update/View User attendance&nbsp;<br><BR><BR>";
print "<input type='submit' name='submit' value='Update'></form><BR>";
print "<a href='main.php'>Go Back</a>";
}
}

[rpnew]

Here is my new code:
$mgroupname=$_GET['selectpg'];
//echo $mgroupname;

$result=mysql_query("SELECT * FROM group WHERE userg_name ='$mgroupname'");
while($row = @mysql_fetch_array($result, MYSQL_ASSOC))
{
$userg_id=$row['userg_id'];
$userg_name=$row['userg_name'];


if(isset($_POST['submit']))
{
$gp_name=$_POST['gp_name'];
$add_checkbox=$_POST['add_checkbox'];
$modify_checkbox=$_POST['modify_checkbox'];
$delete_checkbox=$_POST['delete_checkbox'];
$view_checkbox=$_POST['view_checkbox'];

//$button=$_POST['button'];
if(strlen($gp_name)<1)
{
print "You did not enter a Group Name.<BR>";
print "<a href='addgroup.php'>Go Back</a> &amp; Enter a Group Name.";
}
else
{
$insertbutton="update group SET userg_name = '$gp_name' where userg_id = '$userg_id' ";
$insertbutton1="update tez_ems_rights SET addition = '$add_checkbox', editing = '$modify_checkbox', deletion = '$delete_checkbox', viewing = '$view_checkbox' where userg_id = '$userg_id'";
mysql_query($insertbutton) or die(mysql_error());
mysql_query($insertbutton1) or die(mysql_error());
print "Group modify.<BR>";
print "<a href='main.php'>Go Back</a>";
}
}
else
{
print "<form name='form' action='modifygroup.php' method='post'>";
print "Modify Group Name:<BR>";
print "<input type='text' name='gp_name' size='20' value='$userg_name'><BR><BR>";
print "Modify Permissions:<BR>";
print "<input type='checkbox' name='add_checkbox' value='1'>";
print "Manage Users&nbsp;<br>";
print "<input type='checkbox' name='modify_checkbox' value='1'>";
print "Update/View own info&nbsp;<br>";
print "<input type='checkbox' name='delete_checkbox' value='1'>";
print "Update/View User Salaries/Leave Balance/TDS&nbsp;<br>";
print "<input type='checkbox' name='view_checkbox' value='1'>";
print "Update/View User attendance&nbsp;<br><BR><BR>";
print "<input type='submit' name='submit' value='Update'></form><BR>";
print "<a href='main.php'>Go Back</a>";
}
}

Hi,
Let me know one more thin....... you are using $_GET somewhere and somewhere $_POST.. why so?? arent they coming from the same page??

P.S.: Going through your code meanwhile.
Regards,
RP

[praveenkrg]

Hi,
Let me know one more thin....... you are using $_GET somewhere and somewhere $_POST.. why so?? arent they coming from the same page??

P.S.: Going through your code meanwhile.
Regards,
RP

$mgroupname=$_GET['selectpg'];

this variable comes from other page and

if(isset($_POST['submit']))
{
$gp_name=$_POST['gp_name'];
$add_checkbox=$_POST['add_checkbox'];
$modify_checkbox=$_POST['modify_checkbox'];
.........
this one is from same page.

[praveenkrg]

$mgroupname=$_GET['selectpg'];

this variable comes from other page and

if(isset($_POST['submit']))
{
$gp_name=$_POST['gp_name'];
$add_checkbox=$_POST['add_checkbox'];
$modify_checkbox=$_POST['modify_checkbox'];
.........
this one is from same page.

Hi RP,

could you tell me whts the error in this query:

$result = mysql_query("update tez_ems_users SET user_name = '$gp_name', user_password = '$c_pass', first_name = '$f_name', last_name = '$l_name', email = '$email', emp_number = '$emp_number', userg_id = '$selectpg' where user_name = '$gp_name'") or die(mysql_error());

[Markus]

Hi RP,

could you tell me whts the error in this query:

$result = mysql_query("update tez_ems_users SET user_name = '$gp_name', user_password = '$c_pass', first_name = '$f_name', last_name = '$l_name', email = '$email', emp_number = '$emp_number', userg_id = '$selectpg' where user_name = '$gp_name'") or die(mysql_error());

Do you get an error?

Post the rest of the code if not.

[praveenkrg]

Do you get an error?

Post the rest of the code if not.

I have solved my problem. Thanks for all help and support :)

[rpnew]

I have solved my problem. Thanks for all help and support :)

Hi,
Nice to hear that you've solved your problem...

What was your problem? and how did you solve it?

Regards,
RP