a simple if-login question

[Maxim Vexler]

if ((($value1 != null) || ($value1 != "")) && $value2 != "" && $value1
!= $value2) { ret false }

if i omit the [value2 != ""] i would still get the same result, right?
because I check if value1 != "" and then I check if value1!=value2
i.e. :

if ((($value1 != null) || ($value1 != "")) && $value1 != value2) { ret
false }

regards, maxim.

[steve]

"Maxim Vexler" wrote:

if ((($value1 != null) || ($value1 != "")) && $value2 != "" && $value1
!= $value2) { ret false }

if i omit the [value2 != ""] i would still get the same result, right?
because I check if value1 != "" and then I check if value1!=value2 i.e. :

if ((($value1 != null) || ($value1 != "")) && $value1 != value2) { ret
false }

regards, maxim.

I believe you are right. And you can simplify as well:
($value1 != null) || ($value1 != ""))
is equal to:
($value1 != ’’) [[don’t need the two statements]]
or if you have doubts, use:
(strlen($value1) > 0)

--
http://www.dbForumz.com/ This article was posted by author's request
Articles individually checked for conformance to usenet standards
Topic URL: http://www.dbForumz.com/PHP-simple-l...ict138481.html
Visit Topic URL to contact author (reg. req'd). Report abuse: http://www.dbForumz.com/eform.php?p=462837

[Ian.H]

On Tue, 10 Aug 2004 23:28:15 -0400, steve wrote:

I believe you are right. And you can simplify as well:
($value1 != null) || ($value1 != ""))
is equal to:
($value1 != ’’) [[don’t need the two statements]]
or if you have doubts, use:
(strlen($value1) > 0)

A variable assigned an empty string is _not_ the same as it being NULL.
if (!is_null($value1) and strlen($value1) < 1) {

Regards,

Ian

--
Ian.H
digiServ Network
London, UK
http://digiserv.net/

[Ian.H]

On Wed, 11 Aug 2004 04:38:32 +0000, Ian.H wrote:

On Tue, 10 Aug 2004 23:28:15 -0400, steve wrote:

I believe you are right. And you can simplify as well:
($value1 != null) || ($value1 != ""))
is equal to:
($value1 != ’’) [[don’t need the two statements]]
or if you have doubts, use:
(strlen($value1) > 0)

A variable assigned an empty string is _not_ the same as it being NULL.
if (!is_null($value1) and strlen($value1) < 1) {

Oops:
if (!is_null($value1) and strlen($value1) > 0) {
Better =)

Regards,

Ian

--
Ian.H
digiServ Network
London, UK
http://digiserv.net/

[Maxim Vexler]

steve wrote:

"Maxim Vexler" wrote:

> if ((($value1 != null) || ($value1 != "")) && $value2 != "" &&

$value1

>
> != $value2) { ret false }
>
> if i omit the [value2 != ""] i would still get the same result,

right?

>
> because I check if value1 != "" and then I check if

value1!=value2

> i.e. :
>
> if ((($value1 != null) || ($value1 != "")) && $value1 != value2)

{ ret

>
> false }
>
> regards, maxim.

I believe you are right. And you can simplify as well:
($value1 != null) || ($value1 != ""))
is equal to:
($value1 != ’’) [[don’t need the two statements]]
or if you have doubts, use:
(strlen($value1) > 0)

in fact, and please correct me if I'm wrong :
the logic (($value1 != null) || ($value1 != "")) is totally useless !
because no matter what the input is you always get true from it, right?