Creating a simple feedback form using php

[coldrex]

Hi all,

here my simple code:

<?php
 
$name = $_REQUEST['name']; 
$email = $_REQUEST['text']; 
$comment = $_REQUEST['comment']; 
 
mail( "[e-mail]", "Feedback Form",
$name, $comment, "From: $email" );
header( "Location: http://www.megawhite.au" );
 
?>
 

I need to check, if ALL of the fields are filled. If yes - then go to www.megawhite.. if NOT - to some other www.

I know, that it is somehow possible with "empty" command.. :rolleyes:

Can You put me on the right way, please?

Thanx.

[Markus]

Hi all,

here my simple code:

<?php
 
$name = $_REQUEST['name']; 
$email = $_REQUEST['text']; 
$comment = $_REQUEST['comment']; 
 
mail( "[e-mail]", "Feedback Form",
$name, $comment, "From: $email" );
header( "Location: http://www.megawhite.au" );
 
?>
 

I need to check, if ALL of the fields are filled. If yes - then go to www.megawhite.. if NOT - to some other www.

I know, that it is somehow possible with "empty" command.. :rolleyes:

Can You put me on the right way, please?

Thanx.

You could use strlen()

i.e.
[php]
if((strlen($name) > 0) && (strlen($text) > 0) && strlen($comment) > 0)){
// fields aren't empty - execute relevant code
} else {
// a field is empty - execute relevant code
}
[/php]
That's just an easy and robust way of doing it :)

[coldrex]

thanx, man :)

so, now it looks like below:

 
<?php
 
$name = $_REQUEST['name']; 
$email = $_REQUEST['text']; 
$comment = $_REQUEST['comment']; 
 
if((strlen($name) > 0) && (strlen($email) > 0) && strlen($comment) > 0)){
   header ("Location: http://www.pleasefilltheform.com");
} 
 
else {
mail("[e-mail]", "Feedback Form",
$name, $comment, "From: $email");
header ("Location: http://www.thankyoupage.com");
}
 
?>
 

but the thing is, that when i receive form results on email, in sender's field i see the mail, i indicated in my hosting options, e.g. i write in form: [e-mail], but when the message arrives, i see not blabla@com., but [e-mail]... ?

why is it so, and how we can change it?

[ak1dnar]

Your question is not that much clear to me, but check this out.

$to = '[e-mail]';
$headers = "Reply-to: $email\n";
$headers  .= 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
$headers .= 'From: Web Mailer <from_addreass@goes_here.com>' . "\r\n";
mail($to, "Mail Subject", 'Mail Body Mail Body Mail Body', $headers);

Better to use these headers with your mail function

[Markus]

Your question is not that much clear to me, but check this out.

$to = '[e-mail]';
$headers = "Reply-to: $email\n";
$headers  .= 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
$headers .= 'From: Web Mailer <from_addreass@goes_here.com>' . "\r\n";
mail($to, "Mail Subject", 'Mail Body Mail Body Mail Body', $headers);

Better to use these headers with your mail function

Also looking at your code, it would seem you had it wrong.

Doing this
[php]
if((strlen($name) > 0) && (strlen($email) > 0) && strlen($comment) > 0)){
header ("Location: http://www.pleasefilltheform.com");
} else {
mail("[e-mail]", "Feedback Form",
$name, $comment, "From: $email");
header ("Location: http://www.thankyoupage.com");
}
[/php]
would send the mail if the strlen function checks return false! i.e. sending the email if the fields havent been filled out.

Swap it around
i.e.
[php]
if(((strlen($name) > 0) && (strlen($email) > 0) && strlen($comment) > 0))){
//strlen() returns TRUE, send mail.
mail("[e-mail]", "Feedback Form",
$name, $comment, "From: $email");
header ("Location: http://www.thankyoupage.com");
} else {
// email wasnt filled out properly! Redirect.
header ("Location: http://www.pleasefilltheform.com");
}
[/php]

[coldrex]

[php]
if(((strlen($name) > 0) && (strlen($email) > 0) && strlen($comment) > 0))){
//strlen() returns TRUE, send mail.
mail("[e-mail]", "Feedback Form",
$name, $comment, "From: $email");
header ("Location: http://www.thankyoupage.com");
} else {
// email wasnt filled out properly! Redirect.
header ("Location: http://www.pleasefilltheform.com");
}
[/php]

thanx again, now this part is clear for me :) but what about those headers from Ajaxrand? as i uderstand i should write the addresses like variables to send the mail correctly?

[ak1dnar]

thanx again, now this part is clear for me :) but what about those hAjaxrandrom Ajaxranduderstand i uderstand i should write the addresses like variables to send the mail correctly?

For the mail() function you can pass headers. Its only a enhancement for your script. first I thought that, you are having a problem with sending "FROM" header with the mail. Sorry If I got it on the wrong way. anyway have a look at these user comments on mail function anphpeaders in the php manual
You can set the parameters for mail(......) function as variable or directly, No matter. but for better manageability of the mail function I am always passing variables, rather than typing the values. That's It.
And also the headers, you need to learn more of them when time comes with HTML mails and mails with attachments.

[Markus]

Like ajax mentioned, the headers aren't completely necessary; if you just wanted to send a plain text email then you could leave them out, but if you wanted to send a html formatted email, then you would need to include these headers.

:)

[coldrex]

i have not understood about those headers clearly - will they help to solve this "from" problem or no? :)

seems, i dont need them , as Markus said, I want just plain text results from my form.

[ak1dnar]

i have not understood about those headers clearly - will they help to solve this "from" problem or no? :)

seems, i dont need them , as Markus said, I want just plain text results from my form.

This "from" problem, what's wrong with your "From" header. Is it not displaying in the mail?

[coldrex]

yes, when i receive form results on my mail, i see in "from" field, the mail, i identified as my default hosting mail (in my hosting options). this is happening, inspite of writing the mail in "email" field.

[coldrex]

yes, when i receive form results on my mail, i see in "from" field, the mail, i identified as my default hosting mail (in my hosting options). this is happening, inspite of writing the mail in "email" field.

are there any advices you can give?