My readdir and display images snippet - Thanks

[Confused but working on it]

Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
..jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))
{
echo "<img src='images/$file' class=\"pad1em\">";
}
closedir($dir);
?>

For my next trick I'm going to change the above to read a thumbs dir,
and make a link to a larger picture of the same name in images.
Shouldn't be too hard bt my last programming class was almost 20 years
ago. :) Hats off to everyone that does this for a living.

Thanks again!

[Steve]

"Confused but working on it" <Po**********@wherever.comwrote in message
news:2007091209500416807-PostInGroups@wherevercom...

Just wanted to say thanks for the posts helping me make ths work. Added a
few comments and after the readdir used a pattern match to test for .jpg,
and seems to work fine on my test setup. Maybe I should test for gif,
tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))

one suggestion,

why are you using ereg? beside the fact that it is vastly more resource
intensive than preg and slower, neither is needed because substr is faster
than both.

while ...
$extension = strtolower(substr($file, -4));
if ($extension != '.jpg'){ continue; }
whatever you want to do with the jpg from here
end

you could also use fnmatch to pattern match for file names. you could even
use glob()...

$directory = 'images';
$extension = '*.jpg';
chdir($directory);
foreach (glob($extension) as $image)
{
echo '<img src="' . $directory . '/' . $image . '" class="pad1em">';
}

i personally prefer glob() for such things since it requires less code to
get what you want.

anyway...there's always more than one way to skin a cat. ;^)

[Captain Paralytic]

On 12 Sep, 17:50, Confused but working on it
<[e-mail]:

Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))
{
echo "<img src='images/$file' class=\"pad1em\">";
}
closedir($dir);
?>

For my next trick I'm going to change the above to read a thumbs dir,
and make a link to a larger picture of the same name in images.
Shouldn't be too hard bt my last programming class was almost 20 years
ago. :) Hats off to everyone that does this for a living.

Thanks again!

I think that your ereg might find files such as fred.jpgs.php

[Steve]

"Confused but working on it" <Po**********@wherever.comwrote in message
news:2007091209500416807-PostInGroups@wherevercom...

Just wanted to say thanks for the posts helping me make ths work. Added a
few comments and after the readdir used a pattern match to test for .jpg,
and seems to work fine on my test setup. Maybe I should test for gif,
tiff, and png... Anyway, here's the code:

ok, so i've got time on my hands...after re-reading posts today, i'm on this
one again. here's something that will allow you to list any file you want
either filtering by extension or just getting everything. i've been using
the function below since glob became availabe in php. beneath it, i wrapped
up some pseudo-testing code so you could see how the function can be called
and what each param will generate for you.

have fun. ;^)

<?
function listFiles($path, $extension = array(), $combine = false)
{
if (!chdir($path)){ return array(); }
if (!$extension){ $extension = array('*'); }
if (!is_array($extension)){ $extension = array($extension); }
$extensions = '*.{' . implode(',', $extension) . '}';
$files = glob($extensions, GLOB_BRACE);
if (!$files){ return array(); }
$list = array();
foreach ($files as $file)
{
$list[] = ($combine ? $path : '') . $file;
}
return $list;
}

// sampling output
function beautify($html)
{
$html = str_replace(' :: Array', '', $html);
return $html;
}
ob_start('beautify');
// end sample

// test the function
$path = 'c:/inetpub/wwwroot/images';
$extensions = array('jpg', 'gif', 'tif?');

echo '<pre>directory listing for "' . $path . '"</pre>';

$images = listFiles($path);
echo '<pre>no filter, no directory :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, null, true);
echo '<pre>no filter :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, 'jpg', true);
echo '<pre>single filter :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, $extensions, true);
echo '<pre>multiple filter :: ' . print_r($images, true) . '</pre>';
?>

[Confused but working on it]

On 2007-09-13 07:37:21 -0700, "Steve" <no****@example.comsaid:

>
"Confused but working on it" <Po**********@wherever.comwrote in
message news:2007091209500416807-PostInGroups@wherevercom...

>Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))

one suggestion,

why are you using ereg? beside the fact that it is vastly more resource
intensive than preg and slower, neither is needed because substr is
faster than both.

while ...
$extension = strtolower(substr($file, -4));
if ($extension != '.jpg'){ continue; }
whatever you want to do with the jpg from here
end

you could also use fnmatch to pattern match for file names. you could
even use glob()...

$directory = 'images';
$extension = '*.jpg';
chdir($directory);
foreach (glob($extension) as $image)
{
echo '<img src="' . $directory . '/' . $image . '" class="pad1em">';
}

i personally prefer glob() for such things since it requires less code
to get what you want.

anyway...there's always more than one way to skin a cat. ;^)

Hey Steve,

I'm using eregi because I found a line on a site or in the manual that
didn't get .jpg so I fixed it to get the jpgs. Not a programmer, and
barely even a hobbyist so I do what I can to kludge some stuff
together. Maybe I can read preg, substr and glob and use one of them
but was pretty happy with the cat being skinned at all. :)
Basically I'm just writing a paragraph about and event and putting
160px images on the page with a bit of padding. Today I was going to
make this thing read thumbs and link to images... Might have to take a
nap.

Thanks for the help

[Confused but working on it]

On 2007-09-13 08:10:48 -0700, Captain Paralytic <pa**********@yahoo.comsaid:

On 12 Sep, 17:50, Confused but working on it
<[e-mail]:

>Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))
{
echo "<img src='images/$file' class=\"pad1em\">";
}
closedir($dir);
?>

For my next trick I'm going to change the above to read a thumbs dir,
and make a link to a larger picture of the same name in images.
Shouldn't be too hard bt my last programming class was almost 20 years
ago. :) Hats off to everyone that does this for a living.

Thanks again!

I think that your ereg might find files such as fred.jpgs.php

Yo Captain! (ex-nick of mine)

So that will never be found because fred and I, well, his wife will
tell you the whole story...

Just like a million other peeps I take pictures. I load em up in my mac
in iPhoto, make an album with the corresponding name and don't include
shats that were crappy. Export to a dir called images, filezilla to my
site. Use my little code to display on a page. I tried iWeb to make
pages, gallery databases done in php, and holy cow way to complicated.
Just easier to manage everything in directories by some kind of topic.

So is there a way for your exampe to happen?

Thanks for your input,
Ron

[Confused but working on it]

On 2007-09-13 09:07:17 -0700, "Steve" <no****@example.comsaid:

>
"Confused but working on it" <Po**********@wherever.comwrote in
message news:2007091209500416807-PostInGroups@wherevercom...

>Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:

ok, so i've got time on my hands...after re-reading posts today, i'm on
this one again. here's something that will allow you to list any file
you want either filtering by extension or just getting everything. i've
been using the function below since glob became availabe in php.
beneath it, i wrapped up some pseudo-testing code so you could see how
the function can be called and what each param will generate for you.

have fun. ;^)

<?
function listFiles($path, $extension = array(), $combine = false)
{
if (!chdir($path)){ return array(); }
if (!$extension){ $extension = array('*'); }
if (!is_array($extension)){ $extension = array($extension); }
$extensions = '*.{' . implode(',', $extension) . '}';
$files = glob($extensions, GLOB_BRACE);
if (!$files){ return array(); }
$list = array();
foreach ($files as $file)
{
$list[] = ($combine ? $path : '') . $file;
}
return $list;
}

// sampling output
function beautify($html)
{
$html = str_replace(' :: Array', '', $html);
return $html;
}
ob_start('beautify');
// end sample

// test the function
$path = 'c:/inetpub/wwwroot/images';
$extensions = array('jpg', 'gif', 'tif?');

echo '<pre>directory listing for "' . $path . '"</pre>';

$images = listFiles($path);
echo '<pre>no filter, no directory :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, null, true);
echo '<pre>no filter :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, 'jpg', true);
echo '<pre>single filter :: ' . print_r($images, true) . '</pre>';

$images = listFiles($path, $extensions, true);
echo '<pre>multiple filter :: ' . print_r($images, true) . '</pre>';
?>

Steve,

Wow, way too much time on your hands. :)

My first goal was to get my pics to display, then get rid of the . and
..., now I will fix the code to the example you gave before if you say
it's faster. Then,(light drumroll...), I want to read everything in
thumbs and create my output so I get the thumbto link to a larger pic
in images. Some sort of anchor tag thing. THAT would be cool to me.
Then I can rewrite about 20 pages, export 20 albums as thumbs and 20
albums as images... :)

I'm going to make my anchor tag...

thx..ron

[Confused but working on it]

On 2007-09-13 07:37:21 -0700, "Steve" <no****@example.comsaid:

>
"Confused but working on it" <Po**********@wherever.comwrote in
message news:2007091209500416807-PostInGroups@wherevercom...

>Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))

one suggestion,

why are you using ereg? beside the fact that it is vastly more resource
intensive than preg and slower, neither is needed because substr is
faster than both.

while ...
$extension = strtolower(substr($file, -4));
if ($extension != '.jpg'){ continue; }
whatever you want to do with the jpg from here
end

you could also use fnmatch to pattern match for file names. you could
even use glob()...

$directory = 'images';
$extension = '*.jpg';
chdir($directory);
foreach (glob($extension) as $image)
{
echo '<img src="' . $directory . '/' . $image . '" class="pad1em">';
}

i personally prefer glob() for such things since it requires less code
to get what you want.

anyway...there's always more than one way to skin a cat. ;^)

Here's how I changed the line:

echo "<a href='images/$file'><img src='thumbs/$file'
class=\"pad1em\"></a>";

My originals were 1600x1200 so I did a bew export to thumbs at 100x75
and another to images at 400x300. Freakin fantastic! Had to refresh the
page as the old thumb was showing but very cool. Will play with size I
shoot at and then corresponding thumbs and bigger versions. Like 1024
wide makes nice thumbs at 128, click to see a 512 or 640 bersion.

Before I start hacking your code in from above, any reason the
following wont work?

if ($extension != '.jpg' or != 'gif' or != '.tif' ){ continue; }

Or use the whole expression?

Thanks again!
ron

[Rik Wasmus]

On Fri, 14 Sep 2007 23:42:46 +0200, Confused but working on it
<Po**********@wherever.comwrote:

On 2007-09-13 08:10:48 -0700, Captain Paralytic <pa**********@yahoo.com
said:

>On 12 Sep, 17:50, Confused but working on it
<[e-mail]:

>>Just wanted to say thanks for the posts helping me make ths work. Added
a few comments and after the readdir used a pattern match to test for
.jpg, and seems to work fine on my test setup. Maybe I should test for
gif, tiff, and png... Anyway, here's the code:
<?php
//Open images directory
$dir = opendir("images");
//read files in the dir
while (($file = readdir($dir)) !== false)
//test to make sure jpg
if (eregi("\.jpg",$file))
{
echo "<img src='images/$file' class=\"pad1em\">";

Hmm, are you sure about the class name? I'd say that on a new layout with
the same HTML 'pad1em' could end up making very little sense. A golden
rule of css is that a classname should reflect what something is, not how
it is _displayed. A more suitable name could be something like
'imagepreview' or the like.

>>}
closedir($dir);
?>
For my next trick I'm going to change the above to read a thumbs dir,
and make a link to a larger picture of the same name in images.
Shouldn't be too hard bt my last programming class was almost 20 years
ago. :) Hats off to everyone that does this for a living.
Thanks again!

I think that your ereg might find files such as fred.jpgs.php

Yo Captain! (ex-nick of mine)

So that will never be found because fred and I, well, his wife will tell
you the whole story...

Just like a million other peeps I take pictures. I load em up in my mac
in iPhoto, make an album with the corresponding name and don't include
shats that were crappy. Export to a dir called images, filezilla to my
site. Use my little code to display on a page. I tried iWeb to make
pages, gallery databases done in php, and holy cow way to complicated.
Just easier to manage everything in directories by some kind of topic.

So is there a way for your exampe to happen?

Oh yeah.
(Just make sure the file is a proper image directly after an upload.
Examining extention or mime-type is no good. I'm quite happy to us
getimagesize() for this purpose, as it would return false if it couldn't
interpret a file as an image.)

And to display only files _ending_ in jp(e)g, I'd use
preg_match('/\.jpe?g$/i',$string);
--
Rik Wasmus

[Confused but working on it]

On 2007-09-14 19:30:34 -0700, "Rik Wasmus" <lu************@hotmail.comsaid:

>>>>
echo "<img src='images/$file' class=\"pad1em\">";

Hmm, are you sure about the class name? I'd say that on a new layout wit h
the same HTML 'pad1em' could end up making very little sense. A golden
rule of css is that a classname should reflect what something is, not ho w
it is _displayed. A more suitable name could be something like
'imagepreview' or the like.

>>

Oh yeah.
(Just make sure the file is a proper image directly after an upload.
Examining extention or mime-type is no good. I'm quite happy to us
getimagesize() for this purpose, as it would return false if it couldn't
interpret a file as an image.)

And to display only files _ending_ in jp(e)g, I'd use
preg_match('/\.jpe?g$/i',$string);
--
Rik Wasmus

Rik,

Thanks for responding. In this case the class name is what it is.
..pad1em{padding: 1em;}

Was just messing with some spacing and will rename if I add some pretty
decorations. Any suggestions for this class?

thx..ron