Optimizing a function...

[StinkFinger]

All,
This is a function that I use quite often. I pass in my SQL string and
return the results as an array. Does anyone see any optimizations that I can
make (eventually I would like to make a class, but I am still new).

function table_array ($sql_string)
{
$result = mysql_query($sql_string) or die("dead");
$num_rows = mysql_num_rows($result);
$num_fields = mysql_num_fields($result);
$j = 0;
$x = 1;
while ($row = mysql_fetch_array($result)) {
for($j = 0;$j < $num_fields;$j++) {
$name = mysql_field_name($result, $j);
$arr[$x][$name] = $row[$name];
}
$x++;
}
return array('arr' => $arr, 'rows' => $num_rows, 'fields' => $num_fields);
}

Always trying to shave off some access times =)
Thanks.

[neur0maniak]

Here's a basic class I made a while ago that does something similar..

Once on a page you'll need to do:
$db = new dbObject("localhost", "database", "myuser", "mypassword");

from then on, you can just use:
$db->query("SELECT * FROM wherever");

It'll return just the array of contents of your query.

Once you have the array, you can get the number of rows by:
$num_rows = count($returnedArray);

and you can get the number of fields by:
$num_fields = intval(count(@$returnedArray[0]));

The plan was back then that I could replace the class if I ever moved to
a different database technology.

<?php

class dbObject {
var $server = "localhost";
var $database = "";
var $username = "root";
var $password = "";

var $connection;

function dbObject ($server, $database, $username, $password) {
if ($this->connection = mysql_connect($server, $username,
$password)) {
mysql_select_db ($database, $this->connection);
}
}

function query($sql) {
$dbO = mysql_query($sql, $this->connection);
if (strtolower(substr($sql, 0, 6))=="select") {
$ret = Array();
if (!$dbO) {print "SQL: {$sql} <BR /> FAILED";}
while ($dbR = mysql_fetch_array($dbO)) {$ret[] = $dbR;}
}else{
$ret = $dbO;
}
return $ret;
}

function close() {
mysql_close($this->connection);
}
}

?>

StinkFinger wrote:

All,
This is a function that I use quite often. I pass in my SQL string and
return the results as an array. Does anyone see any optimizations that I can
make (eventually I would like to make a class, but I am still new).

function table_array ($sql_string)
{
$result = mysql_query($sql_string) or die("dead");
$num_rows = mysql_num_rows($result);
$num_fields = mysql_num_fields($result);
$j = 0;
$x = 1;
while ($row = mysql_fetch_array($result)) {
for($j = 0;$j < $num_fields;$j++) {
$name = mysql_field_name($result, $j);
$arr[$x][$name] = $row[$name];
}
$x++;
}
return array('arr' => $arr, 'rows' => $num_rows, 'fields' => $num_fields);
}

Always trying to shave off some access times =)
Thanks.

[StinkFinger]

"neur0maniak" <us****@neur0maniak.co.uk> wrote in message
news:40*********************@ptn-nntp-reader03.plus.net...

Here's a basic class I made a while ago that does something similar..

Once on a page you'll need to do:
$db = new dbObject("localhost", "database", "myuser", "mypassword");

from then on, you can just use:
$db->query("SELECT * FROM wherever");

It'll return just the array of contents of your query.

Once you have the array, you can get the number of rows by:
$num_rows = count($returnedArray);

and you can get the number of fields by:
$num_fields = intval(count(@$returnedArray[0]));

The plan was back then that I could replace the class if I ever moved to a
different database technology.

<?php

class dbObject {
var $server = "localhost";
var $database = "";
var $username = "root";
var $password = "";

var $connection;

function dbObject ($server, $database, $username, $password) {
if ($this->connection = mysql_connect($server, $username,
$password)) {
mysql_select_db ($database, $this->connection);
}
}

function query($sql) {
$dbO = mysql_query($sql, $this->connection);
if (strtolower(substr($sql, 0, 6))=="select") {
$ret = Array();
if (!$dbO) {print "SQL: {$sql} <BR /> FAILED";}
while ($dbR = mysql_fetch_array($dbO)) {$ret[] = $dbR;}
}else{
$ret = $dbO;
}
return $ret;
}

function close() {
mysql_close($this->connection);
}
}

?>

Huge thanks. I'm going to try it out right now =)
Thanks again.

[Christopher Finke]

"StinkFinger" <st****@pinky.com> wrote in message
news:10*************@corp.supernews.com...

Does anyone see any optimizations that I can make

function table_array ($sql_string)
{
$result = mysql_query($sql_string) or die("dead");
$num_rows = mysql_num_rows($result);
$num_fields = mysql_num_fields($result);
$j = 0;
$x = 1;
while ($row = mysql_fetch_array($result)) {
for($j = 0;$j < $num_fields;$j++) {
$name = mysql_field_name($result, $j);
$arr[$x][$name] = $row[$name];
}
$x++;
}
return array('arr' => $arr, 'rows' => $num_rows, 'fields' => $num_fields); }

You could do the following:

function table_array ($sql_string){
$result = mysql_query($sql_string) or die("dead");

while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
$arr[] = $row;
}

return array('arr' => $arr, 'rows' => mysql_num_rows($result), 'fields'
=> mysql_num_fields($result));
}

This should be identical, but with less variable declarations and
assignments.

Chris Finke

[StinkFinger]

"Christopher Finke" <ch***@efinke.com> wrote in message
news:2l************@uni-berlin.de...

"StinkFinger" <st****@pinky.com> wrote in message
news:10*************@corp.supernews.com...

Does anyone see any optimizations that I can make

function table_array ($sql_string)
{
$result = mysql_query($sql_string) or die("dead");
$num_rows = mysql_num_rows($result);
$num_fields = mysql_num_fields($result);
$j = 0;
$x = 1;
while ($row = mysql_fetch_array($result)) {
for($j = 0;$j < $num_fields;$j++) {
$name = mysql_field_name($result, $j);
$arr[$x][$name] = $row[$name];
}
$x++;
}
return array('arr' => $arr, 'rows' => $num_rows, 'fields' =>

$num_fields);

}

You could do the following:

function table_array ($sql_string){
$result = mysql_query($sql_string) or die("dead");

while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
$arr[] = $row;
}

return array('arr' => $arr, 'rows' => mysql_num_rows($result), 'fields'
=> mysql_num_fields($result));
}

This should be identical, but with less variable declarations and
assignments.

Thank you also - this is great. I can use this until I fully understand the
classes, etc.

[Tony Marston]

If you want to convert a result set into an associative array then try this
for size:

// convert result set into a simple associative array for each row
while ($row = mysql_fetch_assoc($result)) {
$array[] = $row;
} // while

return $array;

As you can see this takes the associative array produced by
mysql_fetch_assoc() and appens it to $array. It does not have to waste time
in iterating over every field in each row.

I know this code works as I have been using it for several years. Take a
look at http://www.tonymarston.co.uk/php-mys...seobjects.html for
details. This gives a basic introduction into classes, and how to create a
class to handle all your database access.

HTH.

--
Tony Marston

http://www.tonymarston.net

"StinkFinger" <st****@pinky.com> wrote in message
news:10*************@corp.supernews.com...

All,
This is a function that I use quite often. I pass in my SQL string and
return the results as an array. Does anyone see any optimizations that I can make (eventually I would like to make a class, but I am still new).

function table_array ($sql_string)
{
$result = mysql_query($sql_string) or die("dead");
$num_rows = mysql_num_rows($result);
$num_fields = mysql_num_fields($result);
$j = 0;
$x = 1;
while ($row = mysql_fetch_array($result)) {
for($j = 0;$j < $num_fields;$j++) {
$name = mysql_field_name($result, $j);
$arr[$x][$name] = $row[$name];
}
$x++;
}
return array('arr' => $arr, 'rows' => $num_rows, 'fields' => $num_fields); }

Always trying to shave off some access times =)
Thanks.