Action depending on drop down

[gnawz]

Hi

I have a drop down thus

<form name = frmUtils method = POSTaction = "">
<select name = Do>
<option>Add</option>
<option>Delete</option>
<option>Update</option>
</select>
</form>

I want the form action to change based on the selection ie

if selected Index is Add
action = add.php


if selected Index is Delete
action = delete.php


if selected Updateis Add
action = update.php

Somebody help

[nathj]

Hi

I have a drop down thus


<form name = frmUtils method = POSTaction = "">
<select name = Do>
<option>Add</option>
<option>Delete</option>
<option>Update</option>
</select>
</form>

I want the form action to change based on the selection ie

if selected Index is Add
action = add.php


if selected Index is Delete
action = delete.php


if selected Updateis Add
action = update.php

Somebody help

Thats sounds tricky. Could you use some javascript on the dropdown onchange event? This could use document.getElementById to write the innerHtml of the form (give the form an id that is the same as the name) and add the appropritae action.

That would be the lines of my first attempt. Have a go and let me know how you get on. I'll be happy to help.

Cheers
nathj

[kovik]

You should approach the situation differently.

<?php
if(!empty($_POST['do']))
{
    switch($_POST['do'])
    {
        case 'add':
        case 'update':
        case 'delete':
            header('Location: http://www.mydomain.tld/' . $_POST['do'] . '.php');
    }
}
?>
<form method ="post" action = "">
<select name ="do">
    <option value="add">Add</option>
    <option value="delete">Delete</option>
    <option value="update">Update</option>
</select>
</form>

[nathj]

You should approach the situation differently.

<?php
if(!empty($_POST['do']))
{
    switch($_POST['do'])
    {
        case 'add':
        case 'update':
        case 'delete':
            header('Location: http://www.mydomain.tld/' . $_POST['do'] . '.php');
    }
}
?>
<form method ="post" action = "">
<select name ="do">
    <option value="add">Add</option>
    <option value="delete">Delete</option>
    <option value="update">Update</option>
</select>
</form>

I see where you are coming from. Use the same action but check what to do on the receiving page. A much slicker solution.

This isn't even my issue and I found that helpful. Thanks for the tip. I don't know what I was thinking.

I would change the !empty() to isset() in this example though, I find it to be a more comprehensive check, and being an optimist I prefer to check that something is done rather than not done.

All in all a much better, less compicated solution than my original thought. I think I may have got a bit stuck on using a technology just because I can - a rookie mistake.

Cheers
nathj

[gnawz]

these are my files

reports.php

$Report = $_GET['report'];
 
switch ($Report) 
{
 
    case 'add' :
 
    addfunction();
 
    break;
 
    case 'delete' :
 
    deletefunction();
 
    break;
 
    case 'update' :
 
    updatefunction();
 
    break;
}
 

the other file with my select...

checkrpt.php

<form name="frmUtils" method="post" action="">
 
  <select name="Do"  id ="Do"onChange="SwapReport();">
        <option value="0">Select view</option>
        <option value="1">Add</option>
        <option value="2">Update</option>
    <option value="2">Delete</option>
      </select>
    </form>
 
 
<script type="text/javascript">
 
function SwapReport()
{
    if (document.frmUtils.Do.selectedIndex == 1)
    {
        document.frmUtils.action = "reports.php?report=add";
    }
    else if (document.frmUtils.Do.selectedIndex == 2)
    {
        document.frmUtils.action = "reports.php?report=update";
    }
    else (document.frmUtils.Do.selectedIndex == 3)
    {
        document.frmUtils.action = "reports.php?report=delete";
    }
 
}
</script>

Help from here. It is not working yet.

[code green]

I think this is a syntax error. Should be else if.

else (document.frmUtils.Do.selectedIndex == 3)

Unless you want

document.frmUtils.action = "reports.php?report=delete";

as a default then remove the condition after else

else {
document.frmUtils.action = "reports.php?report=delete";

You originally asked to make the form action conditional so why not
<script type="text/javascript">
[HTML]function SwapReport()
{
if (document.frmUtils.Do.selectedIndex == 1)
{
document.frmUtils.action = "add.php";
}
else if (document.frmUtils.Do.selectedIndex == 2)
{
document.frmUtils.action = "update.php";
}
else if(document.frmUtils.Do.selectedIndex == 3)
{
document.frmUtils.action = "delete.php";
}
}
</script>[/HTML]

[gnawz]

Still not working...
I appreciate all the help people

[nathj]

Still not working...
I appreciate all the help people

In what way? What exactly is not working?

Do you get any error messages at all?

Cheers
nathj

[gnawz]

It just won't do anything at all.

[nathj]

It just won't do anything at all.

Hi gnawz,

Sorry to go on like this but have you turned error reporting on?

This will really help to track down what may be going on.

When you say it won't do anything what do you mean:
1) Does the drop down appear on the page?
2) If so is there data in the drop down?
3) Can you select the data in the drop down?
4) What happens when you tab out of the drop down (or move focus in some other way)? Do you get any error messages?
5) Have you checked the generated source code view using something like FireFox with the web developer add-on, if so what doe sit say for the code in each case?

Perhaps answers to these will shed a bit more light on it, otherwise it's a complete black out from this side.

Cheers
nathj

[gnawz]

The code does not swap any thing n I do not get any errore.

Yes I can select but when I do,nothing happens.

No change in the page and nothing moves.

I'm stuck

[kovik]

I would change the !empty() to isset() in this example though, I find it to be a more comprehensive check, and being an optimist I prefer to check that something is done rather than not done.

empty() is actually a more comprehensive check, as it does what isset() does as well as check that the data has a value. And, in this case, we have no use for an empty value, therefore empty() is ideal.

[kovik]

The code does not swap any thing n I do not get any errore.

Yes I can select but when I do,nothing happens.

No change in the page and nothing moves.

I'm stuck

Why is no one asking the obvious question? Where do you define addfunction(), updatefunction(), and deletefunction(), and what is it that they actually do? If nothing is being displayed, it's because of them.

[nathj]

empty() is actually a more comprehensive check, as it does what isset() does as well as check that the data has a value. And, in this case, we have no use for an empty value, therefore empty() is ideal.

volectricity,

Thanks for the clarity there. i had misunderstood some documentation I read, obviously reading in a rush as I learn all this stuff.

Cheers
nathj

[gnawz]

My functions are defined in the same page they are called.

[kovik]

My functions are defined in the same page they are called.

This issue isn't whether or not they are defined, it is what they are doing and what they are meant to output to the screen. If you are getting no output, likely the functions are failing.

Have you tried debugging by putting echo statements in place of the functions to ensure that the switch statement is reaching the correct branches?

[ianhobson]

Looking back at the code you posted above,

You are POSTing from the form, and then testing the $_GET variable.

You must either have method=POST and use $_POST or amethod=GET and use the $_GET variable.

Regards

Ian

[kovik]

You are POSTing from the form, and then testing the $_GET variable.

His JavaScript alters the action attribute of the form to include a query string, so that's not the issue.