Rotator - Problem with Adsense and Else

[Jeigh]

I've been working on a small script to rotate adverts around aswell as recording how many times they've been viewed. This is working fine but what I'm trying to do now is if there is no ads to display or no active ones it will display my AdSense.

I've tried a few things which I thought should've worked but here's my code now:

 
<?
   $bannerquery  = "SELECT * FROM banner WHERE active='T' ORDER BY Rand() LIMIT 1";
   $bannerresult = mysql_query($bannerquery);
 
 
   while ($brow = mysql_fetch_array($bannerresult)) {
      $bannerid = $brow[0];
      $bannerimage = $brow[2];
      $bannerhref = $brow[1];
      $banneralt = $brow[3];
      $bannerhits = $brow[4];
 
       if($bannerid != "")
   {
 
      echo "<a href=\"$bannerhref\" target=\"_blank\"><img src=\"images/banners/$bannerimage\" alt=\"$banneralt\" /></a>";
 
      /*Update Impressions*/
      $newhits = $bannerhits + 1;
      $bannerinsert = "UPDATE banner SET hits='$newhits' WHERE id='$bannerid'";
      mysql_query($bannerinsert);
   }
 
else
{
echo "<script type=\"text/javascript\"><!--
google_ad_client = \"pub-*****************\";
google_ad_width = 728;
google_ad_height = 90;
google_ad_format = \"728x90_as\";
google_ad_type = \"text_image\";
google_ad_channel = \"\";
google_color_border = \"CCCCCC\";
google_color_bg = \"CCCCCC\";
google_color_link = \"333333\";
google_color_text = \"000000\";
google_color_url = \"333333\";
//-->
</script>
<script type=\"text/javascript\"
  src=\"http://pagead2.googlesyndication.com/pagead/show_ads.js\">
</script>";
}
}
?>
 

What this is doing is when there is ads to display it displays them as it should, when there's no ads or active ads to display it shows nothing instead of the adsense code.

Also, is there a simple way of implementing a system to also record how many times it has been clicked (I know it's possible, just not sure how complicated it is)?

Thanks for any help :)

[Jeigh]

Also, would somthing like what I've done be easily modified to be able to show ads that have scripts?

Thanks again.

[pbmods]

Heya, Jeigh.

Is your script outputting anything? Perhaps this line:

if($bannerid != "")

is not checking for the correct value. Try using empty() instead.

[pbmods]

In terms of counting clicks, simply have the link go to an intermediate page that registers the click and then redirects the browser to the target page.

[Jeigh]

Thank you very much for your reply, I used empty instead but it still didn't work, so I also tried moving the end bracket for the while to here:

   while ($brow = mysql_fetch_array($bannerresult)) {
      $bannerid = $brow[0];
      $bannerimage = $brow[2];
      $bannerhref = $brow[1];
      $banneralt = $brow[3];
      $bannerhits = $brow[4];
      } /*<------*/
 

Instead of it being around the whole script and it worked :)

For the clicks, I'm assuming you mean have the link be <a href="clicks.php"> and within that have somthing like:

mysql_query("UPDATE banners SET clicks='$newclicks' WHERE id='$bannerid'");
 
header(Location: $url);
 

But how will I get the value for $bannerid to stay the same when it goes to clicks.php as I assume it will just randomly choose another ad from the database.

Thanks.

[Jeigh]

Never crossed my mind to put the values into the URL until now but I've got it all sorted and it's recording the clicks and redirecting to the site. I used:

      echo "<a href=\"redirect.php?bannerid=$bannerid&href=$bannerhref\" target=\"_blank\"><img src=\"images/banners/$bannerimage\" alt=\"$banneralt\" /></a>";
 

and on redirect.php:

<?
 
mysql_connect(localhost, *******, *******) or die(mysql_error());
$dbname = '********';
mysql_select_db($dbname) or die(mysql_error());
 
session_start();
 
$bannerid= trim($_GET['bannerid']);
 
$bannerhref= trim($_GET['href']);
 
$clicks = mysql_query("SELECT clicks FROM banner WHERE id='$bannerid'");
 
while($clickfetch = mysql_fetch_array($clicks))
{
$oldclicks = $clickfetch[0];
}
 
$newclicks = $oldclicks + 1;
 
mysql_query("UPDATE banner SET clicks='$newclicks' WHERE id='$bannerid'");
 
header("Location: $bannerhref");
 
?>
 
 

Thanks for the help :)

[pbmods]

Heya, Jeigh.

Glad to hear you got it working! Good luck with your project, and if you ever need anything, post back anytime :)