Single file upload in a multiple uploads system

[Jankie]

<?php
 if(isset($_POST['submit']) && $_FILES['userfile']['size'] > 0){
foreach ($_FILES["userfile"]["error"] as $key => $error) {
$name = $_FILES['userfile']['name'][$key];
$tempname  = $_FILES['userfile']['tmp_name'][$key];
…………
………
$path = 'uploads/';
include 'dbcon.php';
$rep = strpos($_FILES["userfile"]["type"][$key], "image");
if ($rep===FALSE){
$query = "INSERT INTO file_uploads (id,name,type,size,file_data,Caption) VALUES (‘$id’,'$name','$type','$size','$file_data','$Caption)";
mysql_query($query) or die('error, insert query failed:'.mysql_error());
mysql_close($conn);
}
move_uploaded_file($_FILES["userfile"]["tmp_name"][$key],$path);
}
}
?>
<form action="" method="post" enctype="multipart/form-data">
<p>image upload:
<input type="file" name="userfile[]" />
<input type="file" name="userfile[]" />
<input type="file" name="userfile[]" />
<input type="file" name="userfile[]" />
<input type="file" name="userfile[]" />
</form>
<?
?>
 

When user uploads say 1 file,the other remaing four entries also upload in the db with 0 bytes.This is annoying as I need to move to find a way to get rid of the ids of even those legitimate entries(like one id for whatever number of files a user submits at once).For the time being,I only want help regarding restricting the remaining file inputs from posting into the database
My gratitude in advance.

[Atli]

You need to check the '$_FILE['name']['error']' variable. If the file was uploaded successfully this value will be '0'. Any other value and the upload failed an should not be used.

If I remember correctly, not specifying a file will cause error number 4.

[Jankie]

You need to check the '$_FILE['name']['error']' variable. If the file was uploaded successfully this value will be '0'. Any other value and the upload failed an should not be used.

If I remember correctly, not specifying a file will cause error number 4.

How would I do that Atli?
Sorry i haven't done it before.

[Atli]

You could add these couple of lines right after you start your foreach loop.
They will check if the $error variable you create with your foreach loop is set to anything other than '0' and if it is it skips the loop and moves on to the next loop.

if($error != 0) {
  continue;
}
 

Here is another way to do the same thing, except this time I check the $_FILES array instead of the $error variable the foreach loop created.

if($_FILES['userfiles']['error'][$key] != 0) {
  continue;
}
 

[Jankie]

Thanks a lot Atli
I'll try it off and let you know of the outcome.I do appreciate coming up with the second alternative as it is really what my code based on.As you may have notice above,my error var in the foreach is not complete as I only used it to get the multiple uploads working.Now I understand what pro programmers refer to when they talk about "clean code"

[Jankie]

Perfect
Thank you very much Atli for it !
I still have to deal with another extension of the problem,though
It is one submission of multiple files,so I just need one id record for all those files.Now I get a corresponding number of ids instead of just one
I tried this,but for some reason it didnt work for me

$idquery = "SELECT * FROM file_uploads ORDER BY id ASC LIMIT 1";
$idresult = mysql_query($idquery) or die('error, get last id query failed: ' . mysql_error());
if($idrow = @mysql_fetch_array($idresult)){
    $idpost = $idrow["id"]++;
}else{
    $idpost = 0;
}
 
1.    $query = "INSERT INTO file_uploads (id,name,type,size,file_data,Caption) VALUES (‘$idpost’,'$name','$type','$size','$file_data','$Capt  ion)";
2.    mysql_query($query) or die('error, insert query failed:'.mysql_error());
3.    mysql_close($conn);
4.    }
 

But it only let all files be uploaded except the last one,then I got this error:
error, insert query failed:Duplicate entry '1' for key 1

Changing

 $idpost = $idrow["id"]++;
 

to:

$idpost = $idrow["id"]+1;
 

Would only give me:
error, insert query failed:Duplicate entry '2' for key 1.

[Jankie]

Sorry,sounds more like a Mysql issue,so I reposted it in Mysql section
My apologies if am not supposed to.

[Atli]

This is a whole other topic so I think its for the best.

The new topic is located here

[Prabhash vs]

see the link http://www.elmacindia.com/register.php its use ful for u

<Email removed>

[Atli]

see the link http://www.elmacindia.com/register.php its use ful for u

<Email removed>

I've removed the Email address from your post. Posting email addresses is not allowed, as they can (and most likely will) be picked up by spammers.

Please read the FAQ before posting.

Moderator