How and where to code if/then logic

[jej1216]

I have a PHP page that displays in a table budget vs. actual figures from a MySQL db. I want to add logic where if the actual is greater than the budget, the data is displayed in red, otherwise display in black.

...
while ($myrow = mysql_fetch_array($result))
{
echo "<tr><td>".$myrow["facility"]."</td>";
echo "<td align=right>$".number_format($myrow["sw_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["sw_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_budget"], 0, '.', ',')."</td>";
echo "<td align=right>".$myrow["pd_actual"]."</td>";
echo "<td align=right>".$myrow["pd_budget"]."</td></tr>";
}
echo "</tr></table>";
...
 

I want something like this:

If ($myrow["sw_actual"] > $myrow["sw_budget"])
{ fontcolor=red;
}
 

I tried this prior to the While code, and got an error with the 'fontcolor=red' line. Parse error: parse error, unexpected '=' in /usr/local/php_classes/swb_2007_01.php on line 88.
I tried 'fontcolor: red' as well as 'fontcolor red', but get a parse error for each.

Is my If statement incorrect? Should it be placed elswhere?

TIA,

jej1216

[epots9]

I have a PHP page that displays in a table budget vs. actual figures from a MySQL db. I want to add logic where if the actual is greater than the budget, the data is displayed in red, otherwise display in black.

...
while ($myrow = mysql_fetch_array($result))
{
echo "<tr><td>".$myrow["facility"]."</td>";
echo "<td align=right>$".number_format($myrow["sw_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["sw_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_budget"], 0, '.', ',')."</td>";
echo "<td align=right>".$myrow["pd_actual"]."</td>";
echo "<td align=right>".$myrow["pd_budget"]."</td></tr>";
}
echo "</tr></table>";
...
 

I want something like this:

If ($myrow["sw_actual"] > $myrow["sw_budget"])
{ fontcolor=red;
}
 

I tried this prior to the While code, and got an error with the 'fontcolor=red' line. Parse error: parse error, unexpected '=' in /usr/local/php_classes/swb_2007_01.php on line 88.
I tried 'fontcolor: red' as well as 'fontcolor red', but get a parse error for each.

Is my If statement incorrect? Should it be placed elswhere?

TIA,

jej1216

try this:

...
while ($myrow = mysql_fetch_array($result))
{
If ($myrow["sw_actual"] > $myrow["sw_budget"])
{
$style="color:red;";
}
 
echo "<tr><td>".$myrow["facility"]."</td>";
echo "<td align=right>$".number_format($myrow["sw_actual"], 0, '.', ',')."</td>";
echo "<td align=right style='".$style."'>$".number_format($myrow["sw_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["ben_budget"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_actual"], 0, '.', ',')."</td>";
echo "<td align=right>$".number_format($myrow["cl_budget"], 0, '.', ',')."</td>";
echo "<td align=right>".$myrow["pd_actual"]."</td>";
echo "<td align=right>".$myrow["pd_budget"]."</td></tr>";
}
echo "</tr></table>";
 

good luck

[jej1216]

Thanks - that was it. I had to add an else statement to keep all actuals to show red:

    while ($myrow = mysql_fetch_array($result))
    {
     if ($myrow["sw_actual"] > $myrow["sw_budget"])    {
     $style1="color:red;";    }
     else    {
     $style1="color:black;";    }
 
     if ($myrow["ben_actual"] > $myrow["ben_budget"])    {
     $style2="color:red;";    }
     else    {
     $style2="color:black;";    }
 
     if ($myrow["cl_actual"] > $myrow["cl_budget"])    {
     $style3="color:red;";    }
     else    {
     $style3="color:black;";    }
 
     if ($myrow["pd_actual"] < $myrow["pd_budget"])    {
     $style4="color:red;";    }
     else    {
     $style4="color:black;";    }
 

This works, but the code looks clunky - is there a more elegant code to use?

TIA,

jej1216

[mwasif]

You can use Ternary Operator.

[PHP]while ($myrow = mysql_fetch_array($result))
{
$style1 = ($myrow["sw_actual"] > $myrow["sw_budget"]) ? "color:red;" : "color:black;";
$style2 = ($myrow["ben_actual"] > $myrow["ben_budget"]) ? "color:red;" : "color:black;";
$style3 = ($myrow["cl_actual"] > $myrow["cl_budget"]) ? "color:red;" : "color:black;";
$style4 = ($myrow["pd_actual"] < $myrow["pd_budget"]) ? "color:red;" : "color:black;";
}[/PHP]

[jej1216]

You can use Ternary Operator.

[PHP]while ($myrow = mysql_fetch_array($result))
{
$style1 = ($myrow["sw_actual"] > $myrow["sw_budget"]) ? "color:red;" : "color:black;";
$style2 = ($myrow["ben_actual"] > $myrow["ben_budget"]) ? "color:red;" : "color:black;";
$style3 = ($myrow["cl_actual"] > $myrow["cl_budget"]) ? "color:red;" : "color:black;";
$style4 = ($myrow["pd_actual"] < $myrow["pd_budget"]) ? "color:red;" : "color:black;";
}[/PHP]

Thanks - that is pretty slick code.