Why can't I send an email address via a param in a function?

[Tarik Monem]

Any help is appreciated

Here's the php code that writes a simple string that can be interpreted as a simple href

 
    $someNameVar = $row["name"]; 
    $someEmailVar = $row["email"]; 
    $someLikeVar = $row["what_u_liked"];
 
    addslashes($someNameVar);
    addslashes($someEmailVar);
    addslashes($someLikeVar); 
 
 
    echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');  style=cursor:pointer;cursor:hand;>Click here</a>"; 
 
 

No matter what I have tried to do, the browser gives back an error of unterminated string literal.

Thanks in advance

[ak1dnar]

PHP is not giving that kind of Errors.Problem is with your JavaScript code,because with some sample values for all these three variables its calling for myresume_dom.

<script language="JavaScript" type="text/javascript">
function myresume_dom(para1,para2,para3)
{
alert(para1+"\n"+para2+"\n"+para3);
}
</script>

<?php 
//$someNameVar = $row["name"];
$someNameVar = 'someNameVar';
//$someEmailVar = $row["email"];
$someEmailVar = '[e-mail]';
//$someLikeVar = $row["what_u_liked"];
$someLikeVar = 'someLikeVar';
 
addslashes($someNameVar);
 
addslashes($someEmailVar);
 
addslashes($someLikeVar);
 
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');  style=cursor:pointer;cursor:hand;>Click here</a>";
?>
 

[Tarik Monem]

PHP is not giving that kind of Errors.Problem is with your JavaScript code,because with some sample values for all these three variables its calling for myresume_dom.

<script language="JavaScript" type="text/javascript">
function myresume_dom(para1,para2,para3)
{
alert(para1+"\n"+para2+"\n"+para3);
}
</script>

<?php 
//$someNameVar = $row["name"];
$someNameVar = 'someNameVar';
//$someEmailVar = $row["email"];
$someEmailVar = '[e-mail]';
//$someLikeVar = $row["what_u_liked"];
$someLikeVar = 'someLikeVar';
 
addslashes($someNameVar);
 
addslashes($someEmailVar);
 
addslashes($someLikeVar);
 
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');  style=cursor:pointer;cursor:hand;>Click here</a>";
?>
 

First, thank you for your help.

And you are absolutely correct. I believe the problem is that the value of "$someLikeVar" has spaces within the string. For example, say the value is "AJAX DOM PHP MYSQL" which this is the actual example where I receive the error mentioned above.

So, then if you placed your cursor over the link generated, then it would look something like this in the status bar at the bottom of the browser -- "myresume_dom('Bob','[e-mail]','AJAX"

and that's all it shows -- it doesn't terminate the string literal.

I have tried

 
addslashes() and htmlentities() before generating the string.
 
    $someNameVar = $row["name"]; 
    $someEmailVar = $row["email"]; 
    $someLikeVar = $row["what_u_liked"];
 
addslashes($someNameVar);
addslashes($someEmailVar);
addslashes($someLikeVar);
 
htmlentities($someNameVar);
htmlentities($someEmailVar);
htmlentities($someLikeVar);
 
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar." You chose ".$someLikeVar."<br><a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');  style=cursor:pointer;cursor:hand;>Click here</a>";
 
 

What's strange is that it inserts the value into the MySql table with the complete string. I even made sure that I was receiving the complete string by doing a select and displaying it properly, as you can see in the code above, but for some reason the spaces between the words of the third variable just will not pass properly.

Thanks once more for your help and any thoughts would be appreciated

[Tarik Monem]

PHP is not giving that kind of Errors.Problem is with your JavaScript code,because with some sample values for all these three variables its calling for myresume_dom.

<script language="JavaScript" type="text/javascript">
function myresume_dom(para1,para2,para3)
{
alert(para1+"\n"+para2+"\n"+para3);
}
</script>

<?php 
//$someNameVar = $row["name"];
$someNameVar = 'someNameVar';
//$someEmailVar = $row["email"];
$someEmailVar = '[e-mail]';
//$someLikeVar = $row["what_u_liked"];
$someLikeVar = 'someLikeVar';
 
addslashes($someNameVar);
 
addslashes($someEmailVar);
 
addslashes($someLikeVar);
 
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');  style=cursor:pointer;cursor:hand;>Click here</a>";
?>
 

You were correct. It has nothing to do with the PHP code. It was the spaces in the string that I was trying to pass.

 
    $var = str_replace(" ", "", $someLikeVar);
 
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar." You chose ".$someLikeVar."<br>";
echo "<a href=javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$var."');"; 
echo " style=cursor:pointer;cursor:hand;>Click here</a>";
 
 

Once I removed the spaces between the words in the string being passed by the variable, then it sent the information just fine, but why can't I send a string with spaces?

I don't think that I've ever had to do it before, but I can not imagine why this would be an issue when the string is surrounded by single quotes. Shouldn't Javascript be able to interpret this as one complete string?

Should I send the string as an array with the spaces, but how would a php array be sent to js?

[ak1dnar]

You were correct. It has nothing to do with the PHP code. It was the spaces in the string that I was trying to pass.

//REMOVED
 

Once I removed the spaces between the words in the string being passed by the variable, then it sent the information just fine, but why can't I send a string with spaces?

I don't think that I've ever had to do it before, but I can not imagine why this would be an issue when the string is surrounded by single quotes. Shouldn't Javascript be able to interpret this as one complete string?

Should I send the string as an array with the spaces, but how would a php array be sent to js?

No need to Use Arrays here just a simple changes. we'll try to enclose your href value with double quotes.and since you are echoing it through php i have to use the escape ( \") .

And here we go.Try this way.

<html>
<head>
<script language="JavaScript" type="text/javascript">
function myresume_dom(para1,para2,para3)
{
alert(para1+"\n"+para2+"\n"+para3);
}
</script>
</head>
<body>
 
<?php 
//$someNameVar = $row["name"];
$someNameVar = 'some Name Var';
//$someEmailVar = $row["email"];
$someEmailVar = '[e-mail]';
//$someLikeVar = $row["what_u_liked"];
$someLikeVar = 'some Like Var';
addslashes($someNameVar);
addslashes($someEmailVar);
addslashes($someLikeVar);
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=\"javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');\" style=cursor:pointer;cursor:hand;>Click here</a>";?>
 
</body>
</html>
 

[Tarik Monem]

No need to Use Arrays here just a simple changes. we'll try to enclose your href value with double quotes.and since you are echoing it through php i have to use the escape ( \") .

And here we go.Try this way.

<html>
<head>
<script language="JavaScript" type="text/javascript">
function myresume_dom(para1,para2,para3)
{
alert(para1+"\n"+para2+"\n"+para3);
}
</script>
</head>
<body>
 
<?php 
//$someNameVar = $row["name"];
$someNameVar = 'some Name Var';
//$someEmailVar = $row["email"];
$someEmailVar = '[e-mail]';
//$someLikeVar = $row["what_u_liked"];
$someLikeVar = 'some Like Var';
addslashes($someNameVar);
addslashes($someEmailVar);
addslashes($someLikeVar);
echo "Welcome, ".$someNameVar." with the email of ".$someEmailVar."<br><a href=\"javascript:myresume_dom('".$someNameVar."','".$someEmailVar."','".$someLikeVar."');\" style=cursor:pointer;cursor:hand;>Click here</a>";?>
 
</body>
</html>
 

Hey, it worked -- OK! Explain to me why this worked, because I know that I had to have tried this combination of single and double quotes, without the escape sequence, so why does the escape sequence make such a difference?

[ak1dnar]

Hope this might be answer for your question.
Passing variables to JavaScript

Thanks,
-Ajaxrand

[Tarik Monem]

Hope this might be answer for your question.
Passing variables to JavaScript

Thanks,
-Ajaxrand

Excellent. Thank you once again :-)