fread, explode, and eof problem

[Joe]

I have a 'random quotes' plugin that I use which reads tab delimited
quotes from multiple text files in a directory, and then randomly
displays one. Each text file contains multiple lines, each listing a
person and a quote, separated by a tab, and each file is based around a
topic. I use fopen and fread to suck in all the text, and then explode
to separate into an array of names and quotes. It is working fine with
one small exception. When I run explode, the very last line of one file
ends up merged with the first line of the next file, presumably because
it isn't sensing the end of the last line in a file. So instead of
displaying <name1>, <quote1as it should, I get <name1>,
<quote1><name2occassionally. I'm currently working around this by
including a blank line at the end of each text file, and then filtering
out any random hits on that blank line, but I know their is a better
way (I just don't know what it is, I'm fairly new to PHP). Below is
the code I'm using to generate the array, does anyone have any
suggestions on how to get around this problem (and of course if their
is a completely different but better way of doing this I'm all ears)?

$dir = opendir($lpath);
while ($f = readdir($dir)) {
if (eregi("\.txt",$f)){
$quoteFile = fopen($lpath.'/'.$f, "r");
while (!feof($quoteFile)) {
$quotes .= fread($quoteFile,1024);
}
}
}
$quotes = explode("\n", $quotes);

[Pedro Graca]

Joe wrote:

and of course if their
is a [...] different [...] way of doing this I'm all ears

I'd use file() instead of fopen(), fread(), feof(), fclose().
I'd use arrays (I *love* arrays).

<?php
$quotes = array();
$dir = opendir($lpath);
while ($f = readdir($dir)) {
if (preg_match('/\.txt$/', $f)) {
$quotes = array_merge($quotes, file($lpath . '/' . $f));
}
}
closedir($dir);

### Remove all blank entries from $quotes
$quotes = array_diff($quotes, array("\n"));

###
### ATTENTION
### The $quotes array may have "holes"
### If you need the keys in order without "holes" uncomment the next line
// $quotes = array_merge($quotes);
?>
--
File not found: (R)esume, (R)etry, (R)erun, (R)eturn, (R)eboot

[Jerry Stuckle]

Joe wrote:

I have a 'random quotes' plugin that I use which reads tab delimited
quotes from multiple text files in a directory, and then randomly
displays one. Each text file contains multiple lines, each listing a
person and a quote, separated by a tab, and each file is based around a
topic. I use fopen and fread to suck in all the text, and then explode
to separate into an array of names and quotes. It is working fine with
one small exception. When I run explode, the very last line of one file
ends up merged with the first line of the next file, presumably because
it isn't sensing the end of the last line in a file. So instead of
displaying <name1>, <quote1as it should, I get <name1>,
<quote1><name2occassionally. I'm currently working around this by
including a blank line at the end of each text file, and then filtering
out any random hits on that blank line, but I know their is a better
way (I just don't know what it is, I'm fairly new to PHP). Below is
the code I'm using to generate the array, does anyone have any
suggestions on how to get around this problem (and of course if their
is a completely different but better way of doing this I'm all ears)?

$dir = opendir($lpath);
while ($f = readdir($dir)) {
if (eregi("\.txt",$f)){
$quoteFile = fopen($lpath.'/'.$f, "r");
while (!feof($quoteFile)) {
$quotes .= fread($quoteFile,1024);
}
}
}
$quotes = explode("\n", $quotes);

You're assuming the last line is terminated by a "\n" character. That's
not necessarily true.

--
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
js*******@attglobal.net
==================

[Joe]

This code is a bit cleaner than what I was using, but I'm still having
a similar problem. Now, the first quote in each file has an extra
character before the authors name. I could probably use ltrim to get
rid of the extra character if I knew what it was. How do I find what
character it is? In the HTML source it just shows up as a rectangle.
Pedro Graca wrote:

Joe wrote:

and of course if their
is a [...] different [...] way of doing this I'm all ears

I'd use file() instead of fopen(), fread(), feof(), fclose().
I'd use arrays (I *love* arrays).

<?php
$quotes = array();
$dir = opendir($lpath);
while ($f = readdir($dir)) {
if (preg_match('/\.txt$/', $f)) {
$quotes = array_merge($quotes, file($lpath . '/' . $f));
}
}
closedir($dir);

### Remove all blank entries from $quotes
$quotes = array_diff($quotes, array("\n"));

###
### ATTENTION
### The $quotes array may have "holes"
### If you need the keys in order without "holes" uncomment the next line
// $quotes = array_merge($quotes);
?>
--
File not found: (R)esume, (R)etry, (R)erun, (R)eturn, (R)eboot

[Pedro Graca]

Joe top-posted:

[...] Now, the first quote in each file has an extra
character before the authors name. I could probably use ltrim to get
rid of the extra character if I knew what it was.

Can you post an example input file?

How do I find what character it is?

$first_char = substr($quotes[0], 0, 1);
$first_char_ascii_code = ord($quotes[0]);

--
File not found: (R)esume, (R)etry, (R)erun, (R)eturn, (R)eboot