while loops?

Patrick

I'm trying to while loop using a flat txt file and write the values out
into a form. I have 50-58 values to echo. Am I going to have to echo
each line of html. Or is there a way to make this work between the php.
Right now it wants to write the whole table over and over. Is my logic
screwed up? I am not a programmer as such but can get by. I have
something like this which is an abbreviated version. Any help would be
appreciated.

Thanks,
Patrick

<html>
<head>
<?
$filename = "C10AB_precruise.log";
$larray = file($filename);
?>
</head>
<body>
<?
$i=0;
while ($i <= 60)
{
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text"
size="30" name="person" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text" size="30"
name="cruisenum" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?
}
$i++;
?>
</body>
</html>

--
Patrick A. Smith Assistant System Administrator
Ocean Circulation Group – USF - College of Marine Science
http://ocgweb.marine.usf.edu Phone: 727 553-3334

The trouble with doing something right the first time is that nobody
appreciates how difficult it was. - La Rochefoucauld

May 30 '06 #1

Subscribe Post Reply

1500

David Haynes

Patrick wrote:

I'm trying to while loop using a flat txt file and write the values out
into a form. I have 50-58 values to echo. Am I going to have to echo
each line of html. Or is there a way to make this work between the php.
Right now it wants to write the whole table over and over. Is my logic
screwed up? I am not a programmer as such but can get by. I have
something like this which is an abbreviated version. Any help would be
appreciated.

Thanks,
Patrick

If your input file looks something like this:
fred, Barbados/123, Titanic
sally, Turks/Caicos, Mary Celleste

then the following code will help you get started:
<html>
<head>
</head>
<body>
<?php
$filename = "test.log";
if( ! ($fd = fopen($filename, "r")) ) {
echo "Cannot open $filename for read<br>\n";
exit;
}

while( $line = fgets($fd, 80) ) {
$values = explode(',', $line); // assumes comma-separated values
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text"
size="30" name="person" value="<?php echo $values[0]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text"
size="30" name="cruisenum" value="<?php echo $values[1]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $values[2]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?php
}
fclose($fd);
?>
</body>
</html>

-david-

May 30 '06 #2

Patrick

David Haynes wrote:

Patrick wrote:
I'm trying to while loop using a flat txt file and write the values
out into a form. I have 50-58 values to echo. Am I going to have to
echo each line of html. Or is there a way to make this work between
the php. Right now it wants to write the whole table over and over. Is
my logic screwed up? I am not a programmer as such but can get by. I
have something like this which is an abbreviated version. Any help
would be appreciated.

Thanks,
Patrick

If your input file looks something like this:
fred, Barbados/123, Titanic
sally, Turks/Caicos, Mary Celleste

then the following code will help you get started:
<html>
<head>
</head>
<body>
<?php
$filename = "test.log";
if( ! ($fd = fopen($filename, "r")) ) {
echo "Cannot open $filename for read<br>\n";
exit;
}

while( $line = fgets($fd, 80) ) {
$values = explode(',', $line); // assumes comma-separated values
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text"
size="30" name="person" value="<?php echo $values[0]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text" size="30"
name="cruisenum" value="<?php echo $values[1]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $values[2]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?php
}
fclose($fd);
?>
</body>
</html>

-david-

Hi

Thanks for the reply. Yes I can already do that ie.
$values[1]...[2]...[3], and no the file is not comma delimited. It is
delimited by a new line as some of the values are text area inputs. What
I want to be able to do is have the while iterate to the next value so
that any changes in the text file or the originating form that writes
the text file will not require me to go into this one and change all the
numbers.

Patrick

--
Patrick A. Smith Assistant System Administrator
Ocean Circulation Group – USF - College of Marine Science
http://ocgweb.marine.usf.edu Phone: 727 553-3334

The trouble with doing something right the first time is that nobody
appreciates how difficult it was. - La Rochefoucauld

May 30 '06 #3

David Haynes

Patrick wrote:

David Haynes wrote:
Patrick wrote:
I'm trying to while loop using a flat txt file and write the values
out into a form. I have 50-58 values to echo. Am I going to have to
echo each line of html. Or is there a way to make this work between
the php. Right now it wants to write the whole table over and over.
Is my logic screwed up? I am not a programmer as such but can get by.
I have something like this which is an abbreviated version. Any help
would be appreciated.

Thanks,
Patrick

If your input file looks something like this:
fred, Barbados/123, Titanic
sally, Turks/Caicos, Mary Celleste

then the following code will help you get started:
<html>
<head>
</head>
<body>
<?php
$filename = "test.log";
if( ! ($fd = fopen($filename, "r")) ) {
echo "Cannot open $filename for read<br>\n";
exit;
}

while( $line = fgets($fd, 80) ) {
$values = explode(',', $line); // assumes comma-separated values
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text"
size="30" name="person" value="<?php echo $values[0]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text"
size="30" name="cruisenum" value="<?php echo $values[1]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $values[2]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?php
}
fclose($fd);
?>
</body>
</html>

-david-

Hi

Thanks for the reply. Yes I can already do that ie.
$values[1]...[2]...[3], and no the file is not comma delimited. It is
delimited by a new line as some of the values are text area inputs. What
I want to be able to do is have the while iterate to the next value so
that any changes in the text file or the originating form that writes
the text file will not require me to go into this one and change all the
numbers.

Patrick

As long as only your fields are separated by the carriage-returns you
will be all right. If someone sneaks a carriage-return into the text
fields, you will lose your synchronization with the input file. (i.e.
you need to have some trusted form of delimiting the fields)

If you want to use carriage-returns, just replace the while and explode
lines with something like:

while(true) {
if( ! ($line1 = fgets($fd, 80)) ) break;
if( ! ($line2 = fgets($fd, 80)) ) break;
if( ! ($line3 = fgets($fd, 80)) ) break;

and then $value[0] becomes $line1, etc.

BTW the 80 can be replaced with whatever your maxlength is for your text
fields.

-david-

May 30 '06 #4

Patrick

David Haynes wrote:

Patrick wrote:
David Haynes wrote:
Patrick wrote:

I'm trying to while loop using a flat txt file and write the values
out into a form. I have 50-58 values to echo. Am I going to have to
echo each line of html. Or is there a way to make this work between
the php. Right now it wants to write the whole table over and over.
Is my logic screwed up? I am not a programmer as such but can get
by. I have something like this which is an abbreviated version. Any
help would be appreciated.

Thanks,
Patrick

If your input file looks something like this:
fred, Barbados/123, Titanic
sally, Turks/Caicos, Mary Celleste

then the following code will help you get started:
<html>
<head>
</head>
<body>
<?php
$filename = "test.log";
if( ! ($fd = fopen($filename, "r")) ) {
echo "Cannot open $filename for read<br>\n";
exit;
}

while( $line = fgets($fd, 80) ) {
$values = explode(',', $line); // assumes comma-separated values
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text"
size="30" name="person" value="<?php echo $values[0]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text"
size="30" name="cruisenum" value="<?php echo $values[1]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $values[2]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?php
}
fclose($fd);
?>
</body>
</html>

-david-

Hi

Thanks for the reply. Yes I can already do that ie.
$values[1]...[2]...[3], and no the file is not comma delimited. It is
delimited by a new line as some of the values are text area inputs.
What I want to be able to do is have the while iterate to the next
value so that any changes in the text file or the originating form
that writes the text file will not require me to go into this one and
change all the numbers.

Patrick

As long as only your fields are separated by the carriage-returns you
will be all right. If someone sneaks a carriage-return into the text
fields, you will lose your synchronization with the input file. (i.e.
you need to have some trusted form of delimiting the fields)

If you want to use carriage-returns, just replace the while and explode
lines with something like:

while(true) {
if( ! ($line1 = fgets($fd, 80)) ) break;
if( ! ($line2 = fgets($fd, 80)) ) break;
if( ! ($line3 = fgets($fd, 80)) ) break;

and then $value[0] becomes $line1, etc.

BTW the 80 can be replaced with whatever your maxlength is for your text
fields.

-david-

Thanks, I will give that a try.

Patrick

--
Patrick A. Smith Assistant System Administrator
Ocean Circulation Group – USF - College of Marine Science
http://ocgweb.marine.usf.edu Phone: 727 553-3334

The trouble with doing something right the first time is that nobody
appreciates how difficult it was. - La Rochefoucauld

May 30 '06 #5

Kimmo Laine

"Patrick" <ps****@marine.usf.edu> wrote in message
news:e5**********@news1.usf.edu...

I'm trying to while loop using a flat txt file and write the values out
into a form. I have 50-58 values to echo. Am I going to have to echo each
line of html. Or is there a way to make this work between the php. Right
now it wants to write the whole table over and over. Is my logic screwed
up? I am not a programmer as such but can get by. I have something like
this which is an abbreviated version. Any help would be appreciated.

Thanks,
Patrick

<html>
<head>
<?
$filename = "C10AB_precruise.log";
$larray = file($filename);
?>
</head>
<body>
<?
$i=0;
while ($i <= 60)
{
?>

<form method="post" action="precmlog.php">

<table width="800" cellpadding="5" cellspacing="0" border="0">
<tr>
<td width="40%">
Log sheet completed by:<br> <input class="inform" type="text" size="30"
name="person" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>
<tr>
<td>
Cruise name/number:<br> <input class="inform" type="text" size="30"
name="cruisenum" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>

<tr>
<td>
Ship name:<br> <input class="inform" type="text" size="30"
name="shipname" value="<?php echo $larray[$i]; ?>"><br>
</td>
</tr>
</table>

<input class="button" type="submit" value="Submit">
</form>
<?
}
$i++;
?>
</body>
</html>

$i++ should be INSIDE the while loop to have effect. Now you don't increase
it so it keeps writing the same form over an over again because $i gets no
bigger and therefore it's always less than 60 thus it becomes an infinite
loop.

fix
<?
} // Loop stops here, $i is never reached.
$i++;
?>

to

<?
$i++; // Now it's inside the loop and is incremented
}
?>

Or even better, use a for-loop instead. That way you'll do all the necessary
loop-control in one logical place:

for($i=0; $i<=60; $i++) { ....

HTH

--
"ohjelmoija on organismi joka muuttaa kofeiinia koodiksi" -lpk
sp**@outolempi.net | Gedoon-S @ IRCnet | rot13(xv***@bhgbyrzcv.arg)

May 31 '06 #6

Similar topics

Speed of do while

by: Marco | last post by:

We can read this comment at php.net >jon >05-Nov-2003 10:06 >According to my tests, the "do...while" control structure actually seems to be ~40% faster than the "for" control structure. At...

PHP

PEP-0315--Enhanced While Loop: An idea for an alternative syntax

by: Andrew Koenig | last post by:

PEP 315 suggests that a statement such as do: x = foo() while x != 0: bar(x) be equivalent to while True:

Python

do/while Vs For: is there a real difference in performance?

by: RobG | last post by:

A little while ago I opined that do/while loops are harder to read than for loops, and therefore I preferred using for loops. However, it was pointed out that do/while has significant...

Javascript

nested while - how to go to the beginning of the first while?

by: invni | last post by:

I have a nested while. How do I go from the inner while to the beginning of the outer while? Can this be done without using goto? while_1() { some codes here while_2() { if true go to the...

C / C++

147

while (1) vs. for ( ;; )

by: Michael B Allen | last post by:

Should there be any preference between the following logically equivalent statements? while (1) { vs. for ( ;; ) { I suspect the answer is "no" but I'd like to know what the consensus is

C / C++

For...Next vs Do...While

by: jvb | last post by:

Hey all, I figure it's Wednesday, why not put a question up for debate. Beyond personal preference, is there any benefit (performance or otherwise) to using one loop over the other? For example,...