By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
445,813 Members | 1,236 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 445,813 IT Pros & Developers. It's quick & easy.

Problems with formatting and editing a php script

P: n/a
Hi All,

I have struggled through this far with help from many of you so thanks. I am
stuck again. I am really new to this so don't be harsh :-)

There are a few problems. You can run the script here
http://www.pbrown.com/research/test1.php to see the formatting issues

Formatting Issues

1) Why do I get the extra '(' before the '(delete) link
2) Why does the 4th (and I think it is always the last rather than being
just the 4th) record always show below the Add Record link?
Editing Problem

1) When I actually select to delete a record it doesn't, I think it is
related to an 'id' issue but can't see where
2) When I click a link to edit it, it doesn't populate the form below...Why?

I know I am asking a lot. Thanks for any help indeed. If you are asking me
to put any code in to test please help me by being specific

Cheers

Paul

<html><style type="text/css">
<!--
body,td,th {
color: #CCCCCC;
}
body {
background-color: #000000;
}
a:link {
color: #CCCCCC;
}
a:visited {
color: #CCCCCC;
}
a:hover {
color: #CCCCCC;
}
a:active {
color: #CCCCCC;
}
..style1 {
font-size: x-small;
font-style: italic;
}
-->
</style>
<body>
<div align="left">
<p align="center"><img src="/cpsheadersm.jpg" width="409"
height="110"></p>
<p> <?php

$db = mysql_connect("localhost", "user", "password");
mysql_select_db("reminders",$db);

if ($submit) {
// here if no ID then adding else we're editing
if ($id) {
$sql = "UPDATE research_main SET
date_event='$date_event',info_research='$info_rese arch',medium_name='$medium
_name',place_name='$place_name',date_invest='$date _invest',verified_event='$
verified_event',closed_event='$closed_event' WHERE id=$id";
} else {
$sql = "INSERT INTO research_main
(date_event,info_research,medium_name,place_name,d ate_invest,verified_event,
closed_event) VALUES
('$date_event','$info_research','$medium_name','$p lace_name','$date_invest',
'$verified_event','$closed_event')";
}
// run SQL against the DB
$result = mysql_query($sql);
echo "Record updated/edited!<p>";
} elseif ($delete) {
// delete a record
$sql = "DELETE FROM research_main WHERE id=$id";
$result = mysql_query($sql);
echo "$sql Record deleted!<p>";
} else {
// this part happens if we don't press submit
if (!$id) {
// print the list if there is not editing

$result = mysql_query("SELECT * FROM research_main",$db);
while ($myrow = mysql_fetch_array($result)) {

echo "<table border=2>\n";
echo "<tr><td> Investigation Date </td><td> Research Information
</tr><td> Mediums Name </tr><td> Location </tr><td> date being
Researched </tr>\n";

printf("(<a href=\"%s?id=%s\"><tr><td>%s</td><td> %s
</td><td>%s</td></tr></a> \n", $PHP_SELF, $myrow["id"],
$myrow["date_event"], $myrow["info_research"], $myrow["medium_name"],
$myrow["place_name"], $myrow["date_invest"], $myrow["verified_event"],
$myrow["closed_event"]);

printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF,
$myrow["id"]);

}

}

?>

</p>
</div>
<p>&nbsp;</p>
<P>

<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a>

<P>

<form method="post" action="<?php echo $PHP_SELF?>">

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM research_main WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$date_event = $myrow["date_event"];

$info_research = $myrow["info_research"];

$medium_name = $myrow["medium_name"];

$place_name = $myrow["place_name"];

$date_invest = $myrow["date_invest"];

$verified_event = $myrow["verified_event"];

$closed_event = $myrow["closed_event"];

// print the id for editing

?>

<p>
<input type=hidden name="id" value="<?php echo $id ?>">

<?php

}

?>
</p>
<table width="803" border="0">
<tr>
<td width="284">&nbsp;</td>
<td width="509">&nbsp;</td>
</tr>
<tr>
<td>Date Of Event: <span class="style1">yyyy-mm-dd</span> </td>
<td><input name="date_event" type="Text" value="<?php echo
$date_event ?>" size="10"></td>
</tr>
<tr>
<td valign="top">Research Details</td>
<td bordercolor="#000000"><textarea name="info_research"
rows="10"><?php echo $info_research ?></textarea></td>
</tr>
<tr>
<td valign="top">Name of Medium or Researcher:</td>
<td bordercolor="#000000"><input name="medium_name" type="Text"
id="medium_name2" value="<?php echo $medium_name ?>" maxlength="30"></td>
</tr>
<tr>
<td valign="top">Investigation Location:</td>
<td bordercolor="#000000"><input name="place_name" type="Text"
id="place_name3" value="<?php echo $place_name ?>" maxlength="50"></td>
</tr>
<tr>
<td valign="top">Date to be researched: <span
class="style1">yyyy-mm-dd</span> </td>
<td bordercolor="#000000"><input name="date_invest" type="Text"
id="date_invest" value="<?php echo $date_death ?>" size="10"></td>
</tr>
<tr>
<td valign="top">Research Verified:</td>
<td bordercolor="#000000"><input name="verified_event" type="radio"
value="Yes">
YES
<input name="verified_event" type="radio" value="No" checked>
NO</td>
</tr>
<tr>
<td valign="top">Research Closed:</td>
<td bordercolor="#000000"><input name="closed_event" type="radio"
value="Yes">
YES
<input name="closed_event" type="radio" value="No" checked>
NO</td>
</tr>
</table>
<p>
<input type="Submit" name="submit" value="Enter information">
</p>
</form>

<?php

}

?>

</body>

</html>

Jul 17 '05 #1
Share this Question
Share on Google+
4 Replies


P: n/a
> Formatting Issues

1) Why do I get the extra '(' before the '(delete) link
2) Why does the 4th (and I think it is always the last rather than being
just the 4th) record always show below the Add Record link?
Editing Problem

1) When I actually select to delete a record it doesn't, I think it is
related to an 'id' issue but can't see where
2) When I click a link to edit it, it doesn't populate the form below...Why?

I know I am asking a lot. Thanks for any help indeed. If you are asking me
to put any code in to test please help me by being specific

Cheers

Paul


Hi Paul,

Don't know if anyone else, but I'm too lazy to read all your code and
to search the relevant lines. Could you please post only the relevant
code lines here?
thx.

Greetz
Paul.
Jul 17 '05 #2

P: n/a

"Paul 'piz' Wellner Bou" <pa**********@united-scripts.com> wrote in message
news:c0*************@ID-205474.news.uni-berlin.de...
Formatting Issues

1) Why do I get the extra '(' before the '(delete) link
2) Why does the 4th (and I think it is always the last rather than being
just the 4th) record always show below the Add Record link?
Editing Problem

1) When I actually select to delete a record it doesn't, I think it is
related to an 'id' issue but can't see where
2) When I click a link to edit it, it doesn't populate the form below...Why?
I know I am asking a lot. Thanks for any help indeed. If you are asking me to put any code in to test please help me by being specific

Cheers

Paul


Hi Paul,

Don't know if anyone else, but I'm too lazy to read all your code and
to search the relevant lines. Could you please post only the relevant
code lines here?
thx.

H Paul,

I will try but as i said I really have no idea where it is going wrong so I
thought I would try and give as much as poss.

if ($submit) {
// here if no ID then adding else we're editing
if ($id) {
$sql = "UPDATE research_main SET
date_event='$date_event',info_research='$info_rese arch',medium_name='$medium
_name',place_name='$place_name',date_invest='$date _invest',verified_event='$
verified_event',closed_event='$closed_event' WHERE id=$id";
} else {
$sql = "INSERT INTO research_main
(date_event,info_research,medium_name,place_name,d ate_invest,verified_event,
closed_event) VALUES
('$date_event','$info_research','$medium_name','$p lace_name','$date_invest',
'$verified_event','$closed_event')";
}
// run SQL against the DB
$result = mysql_query($sql);
echo "Record updated/edited!<p>";
} elseif ($delete) {
// delete a record
$sql = "DELETE FROM research_main WHERE id=$id";
$result = mysql_query($sql);
echo "$sql Record deleted!<p>";
} else {
// this part happens if we don't press submit
if (!$id) {
// print the list if there is not editing

$result = mysql_query("SELECT * FROM research_main",$db);
while ($myrow = mysql_fetch_array($result)) {

echo "<table border=2>\n";
echo "<tr><td> Investigation Date </td><td> Research Information
</tr><td> Mediums Name </tr><td> Location </tr><td> date being
Researched </tr>\n";

printf("(<a href=\"%s?id=%s\"><tr><td>%s</td><td> %s
</td><td>%s</td></tr></a> \n", $PHP_SELF, $myrow["id"],
$myrow["date_event"], $myrow["info_research"], $myrow["medium_name"],
$myrow["place_name"], $myrow["date_invest"], $myrow["verified_event"],
$myrow["closed_event"]);

printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF,
$myrow["id"]);

}

}

?>

</p>
</div>
<p>&nbsp;</p>
<P>

<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a>

<P>

<form method="post" action="<?php echo $PHP_SELF?>">

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM research_main WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$date_event = $myrow["date_event"];

$info_research = $myrow["info_research"];

$medium_name = $myrow["medium_name"];

$place_name = $myrow["place_name"];

$date_invest = $myrow["date_invest"];

$verified_event = $myrow["verified_event"];

$closed_event = $myrow["closed_event"];

// print the id for editing

?>

<p>
<input type=hidden name="id" value="<?php echo $id ?>">

<?php

}

?>
Jul 17 '05 #3

P: n/a
Dan Weeb wrote:
Hi All,

I have struggled through this far with help from many of you so thanks. I am
stuck again. I am really new to this so don't be harsh :-)

There are a few problems. You can run the script here
http://www.pbrown.com/research/test1.php to see the formatting issues

Formatting Issues

1) Why do I get the extra '(' before the '(delete) link
2) Why does the 4th (and I think it is always the last rather than being
just the 4th) record always show below the Add Record link?
Editing Problem

1) When I actually select to delete a record it doesn't, I think it is
related to an 'id' issue but can't see where
2) When I click a link to edit it, it doesn't populate the form below...Why?

I know I am asking a lot. Thanks for any help indeed. If you are asking me
to put any code in to test please help me by being specific

Cheers

Paul


I also don't have time to trudge through all the code, however I did
have a quick look and I saw
printf("(<a href=\"%s?id=%s\"><tr><td>%s</td><td> %s
</td><td>%s</td></tr></a> \n", $PHP_SELF, $myrow["id"],
$myrow["date_event"], $myrow["info_research"], $myrow["medium_name"],
$myrow["place_name"], $myrow["date_invest"], $myrow["verified_event"],
$myrow["closed_event"]);
Note the printf("(<a href=\.... on the first line, could this be your
extra (?

~Cameron

Jul 17 '05 #4

P: n/a
I noticed that Message-ID: <c0*******************@news.demon.co.uk> from
Dan Weeb contained the following:
Hi All,

I have struggled through this far with help from many of you so thanks. I am
stuck again. I am really new to this so don't be harsh :-)

There are a few problems. You can run the script here
http://www.pbrown.com/research/test1.php to see the formatting issues

Formatting Issues

1) Why do I get the extra '(' before the '(delete) link You have an extra bracket in the printf
2) Why does the 4th (and I think it is always the last rather than being
just the 4th) record always show below the Add Record link?


Try organising your code better, then you can see where the errors are.
There are missing tags. I'd do it like this (BTW I recognise the
tutorial...:-)

There are lots of mistakes with both formatting and dispaying your data.
Forinstance in your prinf() you had $myrow["verified_event"],
$myrow["closed_event"]with no place in your table to put them.

I assume you only need the header row once and that you did intend to
put a </table> tag in somewhere.

Try this for the while() loop (untested)

echo "<table border=2>\n";
echo "<tr>
<td> Investigation Date </td>
<td> Research Information </tr>
<td> Mediums Name </tr>
<td> Location </tr>
<td> date being Researched </td>
<td> Delete </tr>
</tr>\n";

while ($myrow = mysql_fetch_array($result)) {
printf("<tr>
<td><a href=\"%s?id=%s\">%s</a></td>
<td> %s </td>
<td>%s</td>
<td>%s</td>
<td>%s</td>
<td><a href=\"%s?id=%s&delete=yes\">(DELETE)</a>"</td>
</tr> \n",
$PHP_SELF,$myrow["id"],$myrow["date_invest"],$myrow["info_research"],
$myrow["medium_name"],$myrow["place_name"],
$myrow["date_event"],$PHP_SELF,$myrow["id"]);
}
echo "</table>";
Editing Problem

1) When I actually select to delete a record it doesn't, I think it is
related to an 'id' issue but can't see where
You should have a field in that database called 'id' it should be the
primary key and should be set as INT and be auto_increment.

Have you? Because the query is not returning a result for this field.
Try doing this instead.
// delete a record
$sql = "DELETE FROM research_main WHERE id=$id";
if(mysql_query($sql)){
echo "$sql Record deleted!";}
else{ echo "Could not delete record";}

This is a very bad way of deleting records by the way. If this page is
indexed by search engines it will delete all your records. However,
let's get it working first eh?

2) When I click a link to edit it, it doesn't populate the form below...Why?


Missing id so it can't find the record. You need to fix that first then
we'll look at that.
--
Geoff Berrow (put thecat out to email)
It's only Usenet, no one dies.
My opinions, not the committee's, mine.
Simple RFDs http://www.ckdog.co.uk/rfdmaker/
Jul 17 '05 #5

This discussion thread is closed

Replies have been disabled for this discussion.