PHP Foreach HELP!

[matt]

I have this bit of code, that isn't valid, and I need some help getting
it to work... Currently, I get an error because I am calling the next()
function within a foreach loop. I am opening a flat file with data in
the format of:

01|data1|data2

01 Being Gallery Name, data1 being the filename, data2 being photo caption.

Basically I need to look at the line from the text file, and if the
first 2 digits do not match the gallery I have specified, then move on
to the next line, completely ignoring the first line... Code follows:
I would appreciate any help...

<?

$gallery = 03;

$data = file('gallery.txt');

echo "<table border=0 width=500 align=center>";
foreach ($data as $line)
{
list ($g, $q, $a) = explode('|' , trim($line) );
if ( $g != $gallery ) next($line);
else
{
echo "<td width=50% valign=top><img src='/gallery/$q' width=220><br>";
echo "$a<br>";
echo "<a href=\"/gallery/$q\">Enlarge</a><br><br></td>";
$ee++;
//2 - row
if($ee%2==0) echo "<tr>";
}
echo "</table>";

}
?>

[Erwin Moller]

matt wrote:

I have this bit of code, that isn't valid, and I need some help getting
it to work... Currently, I get an error because I am calling the next()
function within a foreach loop. I am opening a flat file with data in
the format of:

01|data1|data2

01 Being Gallery Name, data1 being the filename, data2 being photo
caption.

Basically I need to look at the line from the text file, and if the
first 2 digits do not match the gallery I have specified, then move on
to the next line, completely ignoring the first line... Code follows:
I would appreciate any help...

<?

$gallery = 03;

$data = file('gallery.txt');
OK, you now have an array called $data with all lines.

echo "<table border=0 width=500 align=center>";
foreach ($data as $line)
{
list ($g, $q, $a) = explode('|' , trim($line) );
if ( $g != $gallery ) next($line);
else
{
Why do you test for something you do not care about?
And what is next() in this context?
It is wrong.

Try this:
if ($g == $gallery ){
// print out here
}

echo "<td width=50% valign=top><img src='/gallery/$q'
width=220><br>"; echo "$a<br>";
echo "<a href=\"/gallery/$q\">Enlarge</a><br><br></td>";
$ee++;
//2 - row
if($ee%2==0) echo "<tr>";
}
echo "</table>";

}
?>

regards,
Erwin Moller

[Erwin Moller]

Oh, one tip: the php.net website is a great resource for syntaxconstructs.

http://nl2.php.net/manual/en/control...es.foreach.php

Regards,
Erwin Moller

[Steve]

I have this bit of code, that isn't valid, and I need some help getting
it to work... Currently, I get an error because I am calling the next()
function within a foreach loop. I am opening a flat file with data in
the format of: 01|data1|data2 <?

$gallery = 03;

$data = file('gallery.txt');

echo "<table border=0 width=500 align=center>";
foreach ($data as $line)
{
list ($g, $q, $a) = explode('|' , trim($line) );
if ( $g != $gallery ) next($line);
else
{
echo "<td width=50% valign=top><img src='/gallery/$q' width=220><br>";
echo "$a<br>";
echo "<a href=\"/gallery/$q\">Enlarge</a><br><br></td>";
$ee++;
//2 - row
if($ee%2==0) echo "<tr>";
}
echo "</table>";

}
?>

Don't mix foreach() and next(). Change the test around to avoid it, and
use break to quit the test after a successful match (make sure that
your data is sorted by gallery).

foreach ($data as $line)
{

// ...

if( $g == $gallery )
{
// ...do the table output here...

// then get out of the loop:
break;
}

}

// this should be outside the foreach() loop:
echo '</table>';

---
Steve

[Mladen Gogala]

On Mon, 12 Dec 2005 23:03:51 +1000, matt wrote:

The line

if ( $g != $gallery ) next($line);

should be replaced by

if ( $g != $gallery ) continue;

--
http://www.mgogala.com

[Steve]

The line

if ( $g != $gallery ) next($line);

should be replaced by

if ( $g != $gallery ) continue;

After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

---
Steve

[Steve]

if ($g == $gallery ){
// print out here
}

After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

---
Steve

[Erwin Moller]

Steve wrote:

if ($g == $gallery ){
// print out here
}
After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

If every galery is only mentioned only once in the file: Yes.
But I don't have that arcane knowledge.

Regards,
Erwin Moller

---
Steve

[Steve]

After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

If every galery is only mentioned only once in the file: Yes.
But I don't have that arcane knowledge.

Oops. I'll shut up now.

---
Steve

[matt]

Steve wrote:

The line

if ( $g != $gallery ) next($line);

should be replaced by

if ( $g != $gallery ) continue;

After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

---
Steve

Thanks for all the responses.

As it is a flat file that is used for all galleries, and it appends a
line to the bottom of the file each time a record is added, the
galleries are mixed up throughout the file, so if it stops as soon as
the first match is found, it will not print the rest of the records out.

I will try the "continue" method and see how it works.

[matt]

matt wrote:

Steve wrote:

The line

if ( $g != $gallery ) next($line);
should be replaced by

if ( $g != $gallery ) continue;

After the correct gallery is found this solution will waste cycles
looking at entries that will not match.

---
Steve

Thanks for all the responses.

As it is a flat file that is used for all galleries, and it appends a
line to the bottom of the file each time a record is added, the
galleries are mixed up throughout the file, so if it stops as soon as
the first match is found, it will not print the rest of the records out.

I will try the "continue" method and see how it works.

The Continue Method is causing me problems, After the first instance
where $g != $gallery, it goes to the end of the code and closes the
table... then it goes back and prints the second photo, causing the
second image to not be inside the table that is opened at the start of
the code (I have pasted complete html result at the bottom:)

<table border=1 width=500 align=center><td width=50% valign=top><img
src='photo1.jpg' width=220><br>Test<br><a
href="photo1.jpg">Enlarge</a><br><br></td></table><td width=50%
valign=top><img src='photo2.jpg' width=220><br>Test2<br><a
href="photo2.jpg">Enlarge</a><br><br></td><tr></table>

[Steve]

The Continue Method is causing me problems, After the first instance
where $g != $gallery, it goes to the end of the code and closes the
table... then it goes back and prints the second photo, causing the
second image to not be inside the table that is opened at the start of
the code

Firstly, you make the other correction suggested, moving the close
table tag outside the loop? And secondly, use Erwin's logic which does
not require an explict "continue":

foreach ($data as $line)
{
// ...
if( $g == $gallery )
{
// ...do the table output here...
}
}
// this should be outside the foreach() loop:
echo '</table>';

---
Steve

[matt]

Steve wrote:

The Continue Method is causing me problems, After the first instance
where $g != $gallery, it goes to the end of the code and closes the
table... then it goes back and prints the second photo, causing the
second image to not be inside the table that is opened at the start of
the code

Firstly, you make the other correction suggested, moving the close
table tag outside the loop? And secondly, use Erwin's logic which does
not require an explict "continue":

foreach ($data as $line)
{
// ...
if( $g == $gallery )
{
// ...do the table output here...
}
}
// this should be outside the foreach() loop:
echo '</table>';

---
Steve

Worked a treat. Thanks for your help!

[Mladen Gogala]

On Tue, 13 Dec 2005 06:45:38 -0800, Steve wrote:

The Continue Method is causing me problems, After the first instance
where $g != $gallery, it goes to the end of the code and closes the
table... then it goes back and prints the second photo, causing the
second image to not be inside the table that is opened at the start of
the code
Firstly, you make the other correction suggested, moving the close
table tag outside the loop? And secondly, use Erwin's logic which does
not require an explict "continue":

foreach ($data as $line)
{
// ...
if( $g == $gallery )
{
// ...do the table output here...
}
}
// this should be outside the foreach() loop:
echo '</table>';

Yup, I agree with this. That would solve the problem.


---
Steve

--
http://www.mgogala.com