Undefined index: REQUEST_METHOD

[Bandit]

Hi there,
I have installed a search engine on one of my websites - it had a few
bugs in it, I got all but one out of the script.

The results page works, but it displays this error on the top of the page:

Notice: Undefined index: REQUEST_METHOD in \www\search\libs\utils.php on
line 409

I have enclosed the code it refers to below. I am an amateur when it comes
to PHP, and would appreciate any help. Thanks

Line 409 is this first line.

$retVal = $GLOBALS[$envVar];
if (strlen($retVal) < 1) {
$retVal = getenv($envVar);
if (strlen($retVal) < 1) {
$retVal = $HTTP_ENV_VARS[$envVar];
if (strlen($retVal) < 1) {
$retVal = $HTTP_SERVER_VARS[$envVar];
}
}

Bandit

[Chung Leong]

Use @ to suppress the notice.

$retVal = @$GLOBALS[$envVar];

Or lower your error_reporting level.

Uzytkownik "Bandit" <In**@Bar-Guide.ca> napisal w wiadomosci
news:ra**********************@nnrp1.uunet.ca...

Hi there,
I have installed a search engine on one of my websites - it had a few
bugs in it, I got all but one out of the script.

The results page works, but it displays this error on the top of the page:

Notice: Undefined index: REQUEST_METHOD in \www\search\libs\utils.php on
line 409

I have enclosed the code it refers to below. I am an amateur when it comes to PHP, and would appreciate any help. Thanks

Line 409 is this first line.

$retVal = $GLOBALS[$envVar];
if (strlen($retVal) < 1) {
$retVal = getenv($envVar);
if (strlen($retVal) < 1) {
$retVal = $HTTP_ENV_VARS[$envVar];
if (strlen($retVal) < 1) {
$retVal = $HTTP_SERVER_VARS[$envVar];
}
}

Bandit

[Daniel Tryba]

Chung Leong <ch***********@hotmail.com> wrote:

Use @ to suppress the notice.

$retVal = @$GLOBALS[$envVar];

Or lower your error_reporting level.

Noooooooooooooo. The correct answer is to write better code.

$retVal = $GLOBALS[$envVar];
if (strlen($retVal) < 1) {
$retVal = getenv($envVar);
if (strlen($retVal) < 1) {
$retVal = $HTTP_ENV_VARS[$envVar];
if (strlen($retVal) < 1) {
$retVal = $HTTP_SERVER_VARS[$envVar];
}
}

There are no checks if the index does exist in the array... The
nonexisting key is accessed directly...

if(array_key_exists($envVar,$GLOBALS))
{
$retVal=$GLOBALS[$envVar];
}
elseif(array_key_exists($envVar,$_ENV))
{
...
}
else
{
...
}

--

Daniel Tryba

[Tim Van Wassenhove]

On 2004-01-08, Daniel Tryba <ne****************@canopus.nl> wrote:

There are no checks if the index does exist in the array... The
nonexisting key is accessed directly...

if(array_key_exists($envVar,$GLOBALS))
{
$retVal=$GLOBALS[$envVar];
}

As i've found array_key_exists the most elegant way, isset is faster.
--
http://home.mysth.be/~timvw

[Tim Van Wassenhove]

On 2004-01-08, Bandit <In**@Bar-Guide.ca> wrote:

This is the 3th group i see your post.

Really time to lookup a usenette introduction that tells you about
multiposting and crossposting.

--
http://home.mysth.be/~timvw

[Daniel Tryba]

Tim Van Wassenhove <eu**@pi.be> wrote:

There are no checks if the index does exist in the array... The
nonexisting key is accessed directly...

if(array_key_exists($envVar,$GLOBALS))
{
$retVal=$GLOBALS[$envVar];
}

As i've found array_key_exists the most elegant way, isset is faster.

But array_key_exists has added value: it will barf when the haystack isn't
an array. IMHO that's more important than a few us.

--

Daniel Tryba

[Chung Leong]

Doing more when less will suffice is vain.

Uzytkownik "Daniel Tryba" <ne****************@canopus.nl> napisal w
wiadomosci news:bt**********@news.tue.nl...

Chung Leong <ch***********@hotmail.com> wrote:

Use @ to suppress the notice.

$retVal = @$GLOBALS[$envVar];

Or lower your error_reporting level.

Noooooooooooooo. The correct answer is to write better code.

$retVal = $GLOBALS[$envVar];
if (strlen($retVal) < 1) {
$retVal = getenv($envVar);
if (strlen($retVal) < 1) {
$retVal = $HTTP_ENV_VARS[$envVar];
if (strlen($retVal) < 1) {
$retVal = $HTTP_SERVER_VARS[$envVar];
}
}

There are no checks if the index does exist in the array... The
nonexisting key is accessed directly...

if(array_key_exists($envVar,$GLOBALS))
{
$retVal=$GLOBALS[$envVar];
}
elseif(array_key_exists($envVar,$_ENV))
{
...
}
else
{
...
}

--

Daniel Tryba