trouble reading from file

[somaboy mx]

hi,

I'm on winXPpro / apache 1.2 / php 4.4.x

I'm experimenting with writing and reading from textfiles via php. I can
create a file with fopen, write to it, but I'm having trouble reading
from the file.

here's a snippet:

if (!$keywfile = file("keyw.txt") || !$keywfile = file("desc.txt"))
{
$error = "couldn't open files<br>";

} else {

foreach($keywfile as $line)
{
$keywords .= $line;
}
foreach($keywfile as $line)
{
$desc .= $line;
}

}

I get the following error: Warning: "Invalid argument supplied for
foreach() in d:\filesystem\tmp5o3n6eulkr.php on line 25"

I checked the file handles with print_r and they both output "1". isn't
the file() function supposed to return an array?I have verified that the
files are not empty.
..soma

[Micha³ Wo¼niak]

One quick glance of an experienced eye allowed to understand the blurred
and almost unreadable somaboy mx's handwriting:

[snip]

I get the following error: Warning: "Invalid argument supplied for
foreach() in d:\filesystem\tmp5o3n6eulkr.php on line 25"

I checked the file handles with print_r and they both output "1". isn't
the file() function supposed to return an array?I have verified that
the files are not empty.

Nope, read the manual at www.php.net
You have to use fgets() to get lines from file.

Cheers
Mike

[somaboy mx]

Michał Woźniak wrote:

One quick glance of an experienced eye allowed to understand the blurred
and almost unreadable somaboy mx's handwriting:

[snip]

I get the following error: Warning: "Invalid argument supplied for
foreach() in d:\filesystem\tmp5o3n6eulkr.php on line 25"

I checked the file handles with print_r and they both output "1". isn't
the file() function supposed to return an array?I have verified that
the files are not empty.

Nope, read the manual at www.php.net
You have to use fgets() to get lines from file.

Cheers
Mike

Thanks Mike, fgets() does the job...

..soma

[BKDotCom]

???
Yes, file() will read the entire file into an array
there are a lot more options for reading a file than just fopen and
fgets()

a problem I see is that you're using the same variable ($keywfile) for
both:
if (!$keywfile = file("keyw.txt") || !$keywfile = file("desc.txt"))

and try this format
if ( false == $keywfile = file('keyw.txt') )
{
// couldn't open
}
or

if ( $keywfile = file('keyw.txt') )
{
$keywords = '';
foreach($keywfile as $line)
{
$keywords .= $line;
}
// or instead of the foreach, just use
// $keywords = implode('',$keywfile);
}

[somaboy mx]

BKDotCom wrote:

???
Yes, file() will read the entire file into an array
there are a lot more options for reading a file than just fopen and
fgets()

a problem I see is that you're using the same variable ($keywfile) for
both:
if (!$keywfile = file("keyw.txt") || !$keywfile = file("desc.txt"))

and try this format
if ( false == $keywfile = file('keyw.txt') )
{
// couldn't open
}
or

if ( $keywfile = file('keyw.txt') )
{
$keywords = '';
foreach($keywfile as $line)
{
$keywords .= $line;
}
// or instead of the foreach, just use
// $keywords = implode('',$keywfile);
}

yes, that is some awkward code :( , I noticed and fixed it right after I
posted. But using fgets in combination with feof() fixed the problem of
not being able to iterate over the file contents.

thx,

..soma