Opening a file and outputing the contents

[chanshaw]

Alright I can't seem to get this to actually read from the file but I believe I'm doing it correctly, but obviouslly I'm not.

my $fileName = "guessingGame.csv";
 
sub load()
{    
    open (MYFILE, $fileName) || die(print "Could not open file!");
    while (<MYFILE>) 
    {
        chomp;
        print "$_\n";
    }
    close (MYFILE); 
}

[nithinpes]

There is nothing wrong in the script. It should work once you call the subroutine:

&load();   
 

[chanshaw]

If I'm using windows is their a difference?

[KevinADC]

@chanshaw
No there is no difference. Your open() function is inside a subroutine (well really a prototype in your case) so you have to call the subroutine to tell perl to run the subroutine.

my $fileName = "guessingGame.csv";
load();#<-- now perl will run the subroutine
 
 
sub load {    
    open (MYFILE, $fileName) || die(print "Could not open file!");
    while (<MYFILE>)  {
        chomp;
        print "$_\n";
    }
    close (MYFILE); 
}
 

Don't use parentheses after subroutine names:

sub load() {

That is a called a prototype and you certainbly have no reason to use them and probably never will so just drop the parentheses from now on:

sub load {

You should also pass arguments to your subroutines and pass data back although in this case there is no data to pass back really since you are only using the subroutine to open a file, print its contents and nothing else. Not really a good use of a subroutine.

[numberwhun]

@chanshaw
There shouldn't be a difference for the code you have shown us. What happened when you ran the subroutine as Nithinpes suggested?

Also, the only thing that I see is in your die() statement. If you look at the documentation, you don't need the print inside of it as whatever is in the quotes gets printed by the die function already. You just put in the message you want to have output if the open fails.

Regards,

Jeff