How to redefine subroutine using Require

[ahgan]

Hi,
For some reasons, I have to keep my sub-programs in 2 different .pl files. Both sub-programs are having the same subroutine name. In my main program, I need to determine which sub-program to be called when it meets certain criteria. This is not an issue until I have some mixture of conditions which will switch between the 2 sub-program in different looping. This causes the subroutine to be re-defined and I get undesired results. Is there a better way of doing this, considering I need to keep the sub-programs with the same subroutine names into 2 separate files and switch in between them in main program? Below is the simulation code to explain the issue that I have. Thanks.

~ahgan

##### script1.pl #####

sub Process {
    my $var1 = shift;
    my $var2 = shift;
    return ($var1 * $var2);
}
1;
 

##### script2.pl #####

sub Process {
    my $var1 = shift;
    my $var2 = shift;
    my $ans = "";
    if ($var2 != 0) {
        $ans = $var1 / $var2 
    }
    else {
        $ans = "Error: Divide by 0";
    }
    return $ans;
}
1;
 

##### main.pl #####

use strict;
use warnings;
 
my @num = (1,3,5,7,9);
my @methods = ("multiplication","division","multiplication");
my $runscript = "";
my $result = "";
 
for my $method (@methods) {
    for (0 .. $#num) {
        if ($method eq "multiplication") {
            $runscript = "script1.pl";
        }
        elsif ($method eq "division") {
            $runscript = "script2.pl";
        }
        else {
            print STDERR "Unknown Method\n";
        }
 
        require "$runscript";
        $result = &Process($num[$_],$num[$_]*$num[$_]);
        print "Result for $method of $num[$_] to " . $num[$_]*$num[$_] . " : $result\n";
    }
}
 

[KevinADC]

Unless this is some sort of learning excersize, there is no reason to use seperate files or use the same subroutine name. Put it all in one script. But if for some reason you wanted to continue with this strange setup, try using undef() on the subroutine.

use strict;
use warnings;
 
my @num = (1,3,5,7,9);
my @methods = ("multiplication","division","multiplication");
my $runscript = "";
my $result = "";
 
for my $method (@methods) {
    for (0 .. $#num) {
        if ($method eq "multiplication") {
            $runscript = "script1.pl";
        }
        elsif ($method eq "division") {
            $runscript = "script2.pl";
        }
        else {
            print STDERR "Unknown Method\n";
        }
 
        require "$runscript";
        $result = &Process($num[$_],$num[$_]*$num[$_]);
        undef &Process;#<---- here undef the subroutine
        print "Result for $method of $num[$_] to " . $num[$_]*$num[$_] . " : $result\n";
    }
}
 

[ahgan]

Unfortunately, I need to stick with the setup as I need to load different simulation codes under different circumstances. Anyway, the code
undef &Process;
does not seem to be working. I will have to find other resolution. Thanks for the suggestion.

[nithinpes]

Unfortunately, I need to stick with the setup as I need to load different simulation codes under different circumstances. Anyway, the code
undef &Process;
does not seem to be working. I will have to find other resolution. Thanks for the suggestion.

One way would be to include

package script1;
 

and

package script2;
 

at the top of script1.pl & script2.pl respectively. And modify your main.pl as below:

for my $method (@methods) { 
    for (0 .. $#num) { 
        if ($method eq "multiplication") { 
                 $runscript = "script1.pl"; 
           } 
        elsif ($method eq "division") { 
          $runscript = "script2.pl"; 
                  } 
              else { 
            print STDERR "Unknown Method\n"; 
        } 
        require "$runscript"; 
        my $result;
        $result = &script1::Process($num[$_],$num[$_]*$num[$_])  if($runscript eq "script1.pl"); 
        $result = &script2::Process($num[$_],$num[$_]*$num[$_])  if($runscript eq "script2.pl");
        print "Result for $method of $num[$_] to " . $num[$_]*$num[$_] . " : $result\n"; 
 
 } 
} 
 
 

[KevinADC]

Thats a good suggestion.

[ahgan]

Thanks for all the pointers!