how to write data passed as an argument to a function ???

vijayarl

Hi All,

am trying to call the function, which needs to write the arguements passed to this function in a file.
basically creating a log file : thought instead of printing message, i will write the data in seperate log file so that it will useful for later anlaysis.

script goes like this:

Expand|Select|Wrap|Line Numbers

 
my $string;

my $str="";

my $datestamp = sprintf "%02d%02d%02d", 

    ((localtime)[5]%100, (localtime)[4]+1, (localtime)[3]);

#print $datestamp;

my $time =localtime();

my $subtime = substr($time,11,18);

my $time_sub = substr($subtime,0,8);

#my $datetime=$datestamp."_".$time_sub;

my $logfile ="c:\\Performance_svap\\logfile_$datestamp.txt";

open (Wlog,"> $logfile") or die "Can't open $logfile : $!";

&writelogfile("hi All");

&wirtelogfile("Testing Log file creation");

sub writelogfile($str){

    open(Wlog,">> $logfile") or die "Can't open $logfile : $!";

    #write $str;

    close Wlog;

}

close Wlog;

when i try to run this script i get this error message :

Expand|Select|Wrap|Line Numbers

 
C:\Performance_svap\misc>chkempty.pl

Undefined subroutine &main::wirtelogfile called at :\Performance_svap\misc\chke

mpty.pl line 197.

but when i comment one of the calling function then, logfile gets created but there is not content in it.
All i need is while call this function

Expand|Select|Wrap|Line Numbers

&writelogfile("hi All");

in the output logfile i should get the string which is passed to this function.
somethig like this :

Expand|Select|Wrap|Line Numbers

in logfile: "hi All" should be written

can anyone tell me how to acheive this ???

Regards,
Vijayarl

Stwange

If you refuse to read the warning messages or the code, you will never be able to fix your "own" work.

Firstly:

Expand|Select|Wrap|Line Numbers

&wirtelogfile("Testing Log file creation");

You see how this is spelt wrong? It should be &writelogfile, as the warning tells you.

Secondly:

Expand|Select|Wrap|Line Numbers

 
sub writelogfile($str){

    open(Wlog,">> $logfile") or die "Can't open $logfile : $!";

    #write $str;

    close Wlog;

}

This function opens the logfile and closes it again. Nothing else is done with this file as the middle line is commented out. What do you expect a commented out line to do, apart from nothing?

As for the $str, this isn't how you get parameters in perl, you have to get them from @_. This function does what you want (assuming it's not called from another object):

Expand|Select|Wrap|Line Numbers

 
sub writelogfile { # assumes $logfile is already defined

     my $str = shift; # get the first parameter from @_

     open(WLOG,">> $logfile") or die "Can't open $logfile : $!";

     print WLOG "$str\n"; # using print here which doesn't print a newline by default/

     close WLOG;

}

vijayarl

Thanks Stwange !!!!!

thanks for pointout my mistakes in script...hereafter i will try debug errors myself....

Thanks once again for your support....script worked fine as expected...

Regards,
Vijayarl

how to write data passed as an argument to a function ???

Post your reply

Similar topics