find the highest number in a array

MyMarlboro

i wonder am i make a mistake or not...

Expand|Select|Wrap|Line Numbers

 use Data::Dumper;
 
my @array= qw(1 2 3 4 5 6 8 9 2 5);
 
my $highest=@array[0];
 
foreach my $number (@array) {

    if (@array[$number] > $highest) {

    $highest = @array[$number];

    }

}

print Dumper $highest;

i get the output as $VAR1 = 8;

suppose the answer should be 9 right?

numberwhun

If you are looking for the last element in the array, you can get that with the special variable:

Expand|Select|Wrap|Line Numbers

$#arrayname

On the other hand, take that number and add one and you have the number of elements in the array (not starting at zero).

Regards,

Jeff

nithinpes

The problem lies in this section of your script:

Expand|Select|Wrap|Line Numbers

 
foreach my $number (@array) {

    if (@array[$number] > $highest) {

foreach loop will fetch each element of the array, not each index. So, the comparison section should be:

Expand|Select|Wrap|Line Numbers

 
foreach my $number (@array) {

    if ($number > $highest) {

    $highest = $number;

    }

}

KevinADC

use sort function, which will be much faster anyway:

Expand|Select|Wrap|Line Numbers

 my @array= qw(1 2 3 4 5 6 8 9 2 5);

print ((sort {$b <=> $a} @array)[0]);

find the highest number in a array

Post your reply

Similar topics

Question stats

	Ask Question
Home Questions Articles Browse Topics Latest Top Members FAQ