Bad file Descriptor

[rajiv07]

Hi i have script for upload file to server.when i execute this script it gives Bad file Descriptor error.could u anybody help on this.

use strict;
use CGI;
use CGI::Carp qw(fatalsToBrowser);
use File::Basename;
use diagnostics;
$CGI::POST_MAX = 1024 * 1000; 
$CGI::DISABLE_UPLOADS = 0;  
my $query=new CGI;
 
my $file = $query->param("file") ;
my $upload_dir = "../templates/";
 
my $filename_characters = 'a-zA-Z0-9_.-';
 
my $file = $query->param('file') ;
 
$file=~ s/(^\s+|\s+$)//;
 
my @array=();
 
 my ($filename,undef,$ext) = fileparse($file,qr{\..*});
 
$filename .= $ext;
 
$filename =~ tr/ /_/;
 
$filename =~ s/[^$filename_characters]//g;
 
if($filename =~ /^([$filename_characters]+)$/) {
   $filename = $1;
}
else{
   error("The filename is not valid. Filenames can only contain these characters: $filename_characters");
}
 
##I got the error in this line ##
 
my $upload_filehandle = $query->upload("file") or die $!;
 
open (UPLOADFILE, ">$upload_dir/$filename") or error($!);
binmode UPLOADFILE;
while ( <$upload_filehandle> ) {
   print UPLOADFILE;
}
close UPLOADFILE;
sub error {
   print $query->header(),
         $query->start_html(-title=>'Error'),
         shift,
         $query->end_html;
   exit(0);
}

Regards
Rajiv

[numberwhun]

Hi i have script for upload file to server.when i execute this script it gives Bad file Descriptor error.could u anybody help on this.

use strict;
use CGI;
use CGI::Carp qw(fatalsToBrowser);
use File::Basename;
use diagnostics;
$CGI::POST_MAX = 1024 * 1000; 
$CGI::DISABLE_UPLOADS = 0;  
my $query=new CGI;
 
my $file = $query->param("file") ;
my $upload_dir = "../templates/";
 
my $filename_characters = 'a-zA-Z0-9_.-';
 
my $file = $query->param('file') ;
 
$file=~ s/(^\s+|\s+$)//;
 
my @array=();
 
 my ($filename,undef,$ext) = fileparse($file,qr{\..*});
 
$filename .= $ext;
 
$filename =~ tr/ /_/;
 
$filename =~ s/[^$filename_characters]//g;
 
if($filename =~ /^([$filename_characters]+)$/) {
   $filename = $1;
}
else{
   error("The filename is not valid. Filenames can only contain these characters: $filename_characters");
}
 
##I got the error in this line ##
 
my $upload_filehandle = $query->upload("file") or die $!;
 
open (UPLOADFILE, ">$upload_dir/$filename") or error($!);
binmode UPLOADFILE;
while ( <$upload_filehandle> ) {
   print UPLOADFILE;
}
close UPLOADFILE;
sub error {
   print $query->header(),
         $query->start_html(-title=>'Error'),
         shift,
         $query->end_html;
   exit(0);
}

Regards
Rajiv

In line 38, shouldn't "file" be "$file"?

Regards,

Jeff

[KevinADC]

Change this line:

open (UPLOADFILE, ">$upload_dir/$filename") or error($!);

change to:

open (UPLOADFILE, ">$upload_dir$filename") or error($!);

you already have a trailing slash on the end of $upload_dir as defined in line number eleven of the code you posted.

[KevinADC]

In line 38, shouldn't "file" be "$file"?

Regards,

Jeff

Short answer is: no.

[numberwhun]

Short answer is: no.

That's what I get for digging through tons of code all day. :)

[rajiv07]

Change this line:

open (UPLOADFILE, ">$upload_dir/$filename") or error($!);

change to:

open (UPLOADFILE, ">$upload_dir$filename") or error($!);

you already have a trailing slash on the end of $upload_dir as defined in line number eleven of the code you posted.

Thanks Kevin.Its working fine.I have spent 1 hour to sort this but i couldn't find the small mistake.

Regards
Rajiv