How to append file to the file

[dainova]

Hi,

I need to append a contents of the temp file to another output file, tried copy, but it doesn't work. I can't directly print into the output file as I need to check contents of temp first.
I also tried to work with arrays instead of temp file, but printing array into INFO file gives me line shifting.

Will appreciate help:
--------------------------------------------

use File::Copy;
 
$filec="copy.txt";
$temp="temp.txt";
$open(INFO, ">>$filec");
open(TEMP, ">$temp");
 

[numberwhun]

Welcome to TSDN!!!

First, please know that I have edited your post to add code tags around your code. Please be sure and add them to your post, around your code, for any future code postings.

Next, as far as the file(s) you are dealing with, I understand that you want to combine them into one file. Are you worried about duplicates? Is that what you are wanting to check for? Also, what operating system are you working on?

Regards,

Jeff

[dainova]

Hi,

I don't care about dups, during the loop processing I'm collecting some info into temp, then after storing this info into INFO I'll clean it up.
I'm using Active Perl on W'XP.

Tx
Vic

[numberwhun]

Well, if that is the case, why not do something like this:

### ALWAYS use strict and use warnings ###
use strict;
use warnings;
 
my $filec="copy.txt";
my $temp="temp.txt";
 
### Open the files handles: INFO for appending to and TEMP for writing to ###
open(INFO, ">>$filec");
open(TEMP, "<$temp");
 
 
## Cycle through the open temp file, appending each line out to the INFO file##
while(<TEMP>)
{
    print INFO ("$_");
}
 
 
### Close the file handles opened earlier ###
close(INFO);
close(TEMP);
 

You were on the right track, but I wouldn't use File::Copy, I would just do a print of the file handle while cycling through it using a while loop since the INFO file handle was opened with a append(>>).

Also, always use strict and use warnings. They will keep you out of trouble and in check in most cases. I also changed the redirect for the TEMP file handle to a left angle which reads from. The right angle opens for writing only.

Let us know if you have any other issues.

Regards,

Jeff

[dainova]

Thanks, Jeff !

If works fine but for static temp file, which is not my case.
I go thru loop and depending of number of IFs collecting data into temp, then after one more IF I need to print it into INFO. So I still need

open(TEMP, ">$temp");

Tx
Vic

[numberwhun]

Awesome, glad it worked for you! Yeah, just modify it as you need to. All I did was use the original code that you posted and made modifications/additions to it. Happy Perl scripting!

Regards,

Jeff

[dainova]

Sorry, Jeff

But it does NOT work in my case, I can't process temp if it's opened as output with > as you suggested below, I have zero output, though no errror.
It should work if I'll add close and open as <.


Tx
V

[numberwhun]

If you look at the code I posted, you will see that I used the following:

open(TEMP, "<$temp");
 

which will open the file for reading only. You should only use a > if you are only wanting to write to a file without reading from it.

Regards,

Jeff

[KevinADC]

when you open a file using '>', any existing content is lost. It essentially is creating a brand new file.

[dainova]

It's still confusing for most of guys:

I'm going thru the loop and depending of number of IFs collecting data into temp, then after one more IF I need to print it into INFO. So the question is how can do it in one shot in the very same script: put contents of TEMP file (that was dynamically created) into result INFO file, that opened in >> mode.


Tx
V

[numberwhun]

Since we cannot see your code, why not post it here and we can try and help you get it to work. Without it, we can only speculate as to what you are doing.

Regards,

Jeff

[KevinADC]

It's still confusing for most of guys:

I'm going thru the loop and depending of number of IFs collecting data into temp, then after one more IF I need to print it into INFO. So the question is how can do it in one shot in the very same script: put contents of TEMP file (that was dynamically created) into result INFO file, that opened in >> mode.


Tx
V

Sounds like you are going about it OK. Nothing wrong with using a temp file or temp variables, sometimes it can not be avoided. But without seeing your code and understanding what you are doing there is no way to advise you on how to do it in "one shot". My guess is you could just write the data directly to INFO instead of TEMP.

[Kelicula]

Also there is a read and write opener.

+<

as in:

open(INFO, "+<thefile.txt") or die
 

Of course then you have to worry about position of writing in the file. (Were the write occurs)

Once again I'm sure it would help if you're code was visible.

[numberwhun]

Actually, permissions really don't come into play since the OP is on a Windows XP machine.

Regards,

Jeff

[KevinADC]

permissions != position ;)

[numberwhun]

Still, if the drive is mapped, then position wouldn't matter as access would already be established. Do you agree?

[KevinADC]

I believe he means position in the file as in "seek", if that is the case then the position could matter.

[dainova]

Tx to all,

I'm OK now, I opened TEMP file in > mode, then closed it, then opened as <, this way I can fill it and later read it into the final output INFO file. Thought that you an do it in simpler way, this way I got and extra loop,

open(INFO, ">>$filec");
open(TEMP, ">$temp");
 
print TEMP "$one\n";
print TEMP "$two\n";
print TEMP "$three\n";
 
close(TEMP);
open(TEMP, "<$temp");
$cntr = 0;
while (<TEMP>) {
    $cntr=$cntr + 1;
    print "counter = $cntr\n";  
    print INFO ("$_");
}
 
if ($cntr > 1) {
    print "value of cntr=$cntr\n";
}
 
print INFO " \n";
 
 
print "Time   $tt\n";
 
close(INFO);
close(TEMP);

[numberwhun]

Just an additional note. When creating file handles, its always best to give them names that are most meaningful, causing less confusion on your part later or on the part of those who will have to support your code.

For instance, when opening the temp file for writing, you could use "TEMP_OUT" and when opening the temp file for reading, you could use "TEMP_IN". Just a suggestion, that's all, but albeit a handy one if you ask me.

Regards,

Jeff