Perl socket

[perln00b]

I cant find mistake in following code:

#!/usr/bin/perl
 
use Socket;
 
$host=<STDIN>;
chomp($host);
$port=<STDIN>;
 
$paddr=sockaddr_in($port, inet_aton($host));
$proto=getprotobyname('tcp');
 
socket(SOKET, PF_INET, SOCK_STREAM, $proto) or die "$!";
 
connect(SOKET, $paddr);
 
if(connect(SOKET, $paddr)){
    print "1\n";
} else {
    print "0\n";
}
 

[numberwhun]

First, you don't have the "use strict" and "use warnings" pragmas at the beginning of your code. Without those there to do away with the little errors, most people won't look at your code.

Second, you haven't exactly told us what error you are receiving.

Third, you may want to also chomp() the input for the $port variable.

Lastly, please place any and all code that you put in your post into code tags. Doing so takes some of the work off of our friendly neighborhood moderators that have to clean up posts. (If you don't know how to use code tags, simply look at the "Reply Guidelines" next to your posting message window.)

Regards,

Jeff

[perln00b]

Lastly, please place any and all code that you put in your post into code tags. Doing so takes some of the work off of our friendly neighborhood moderators that have to clean up posts. (If you don't know how to use code tags, simply look at the "Reply Guidelines" next to your posting message window.)

Sorry, I am new on this forum.

and about program: it just print "0".

[numberwhun]

Now mind you, I have zero experience working with sockets, but I notice in your code that you are doing the 'connect' and then using the same connect statement in an if as a test. Are you trying to see if its connected?

I don't think that that will work the way you have it because I doubt that the connect statement returns anything beyond the connection. I think a better way to do this would be to say:

connect(SOKET, $paddr) or die "Could not connect:  $!";
 

That will do the connection for you, but if it doesn't work, it will run the die statement and the "$!" will print the error that was produced.

Regards,

Jeff

[perln00b]

No errors. So... I made it?

[numberwhun]

No errors. So... I made it?

I would say.

Jeff

[KevinADC]

I would also chomp() $port to be safe:

$port=<STDIN>;
chomp($port);

[numberwhun]

I would also chomp() $port to be safe:

$port=<STDIN>;
chomp($port);

Yeah, that was the third thing I suggested. Hopefully he did it.

[KevinADC]

Yeah, that was the third thing I suggested. Hopefully he did it.

Ahh.... I missed that.