Problem in href url encoding

[rajiv07]

$cEn_com =~ s/([^A-Za-z0-9])/sprintf("%%%02X", ord($1))/seg;
 
$cEn_art =~ s/([^A-Za-z0-9])/sprintf("%%%02X", ord($1))/seg;
 
$cResult .= "<a href=javascript:open1('/cgi-bin/admin/order_details.pl?ordernumber=ordernum&artist=$cEn_art&company=$cEn_com');>click</a>";
 

Here i have send the encoded parameter with url to javascript open1 function
to diaplay popup window.The open1 function that i am placing in head tag in my html file.

here what my problem is when any one of parameters ( $cEn_com and $cEn_art) has some value the output (OUTPUT is click) is display.If the values are empty string nothing get display.

Is any Idea.
Thank U.

[crabpot8]

i am not entirely sure of your problem, but you could always make sure there was some output, like this

 if ($cEn_art !~ m{[a-z]}ig || $cEn_com !~ m{[a-z]}ig) {
    #create default response here
} 
 

hope that helps

[miller]

There does not appear to be anything wrong with your encoding. However, I would advise you to use the standard module for this type of escaping. It not only helps document what you are trying to do better, but is actually faster sinceu it caches both the replacement translation but also the pattern that you choose to escape:

cpan URI::Escape

use URI::Escape;
 
$cEn_com = uri_escape($cEn_com, '\W');
$cEn_art = uri_escape($cEn_art, '\W');
 
$cResult .= qq{<a href="javascript:open1('/cgi-bin/admin/order_details.pl?ordernumber=ordernum&artist=$cEn_art&company=$cEn_com');">click</a>};
 

Also, I would advice you to always quote your href's.

Anyway, your problem is not directly related to perl, but is actually either an html or javascript issue. I advise you to ask in the JavaScript forum if the simple quoting of the href above does not fix your problem.

- Miller