Website Session Tracking - No Builtin Modules

[Charles Abetz]

Hi all

My problem is that I am creating a session file on the server when the user first visits my website, but when the user logs in i want to write to the file again with the timestamp and their userID.

Code snipet

if ($core->cookie(-name=>'ChasSession') eq "") {
    if ($sID eq "") {
        $sID = int(rand 1e9);
    }
    else{
        $sID = $core->param('sID');
    }
    $cookie = $core->cookie(
        -name        => 'ChasSession',
        -value        => $sID,
        -expires    => '+7d',
    );
    $file = "session.$sID";
    printHeader("true");
}
else{
    printHeader();
}
 
open (SESSION, ">$file") ;
flock SESSION, "2";
print SESSION "lastActive:". localtime()."\n";
print SESSION "userID: $userID";
flock SESSION, "8";
close (SESSION);
 

this is the first run through it does this
and this works as I want it to.

But when i call a sub (when the user submits their username and password) and try to re-write to the file it doesn't work.

sub CorrectLogin {
    open(LOGIN, "<.htpasswd");
    flock LOGIN, "2";
    $user = shift;
    $pwd = shift;
    $page = shift;
 
    if (($user eq "") || ($pwd eq "")) {
        printDefaultBody("1");
    }
    else{
        while (<LOGIN>){
            @userpwd = split(":", $_);
            chomp;
            $tmpUser = @userpwd[0];
            $tmpPwd = @userpwd[1];
            $tmpPwd =~s/\s*$//g;
            $salt = substr(@userpwd[1], 0,2);
            if (($user eq $tmpUser) && (crypt($pwd, $salt) eq $tmpPwd)) {
                open (SESSION, "<$file");
                rename ("$file", "$file.old");
                open (NEWSESSION, ">$file");
                while (<SESSION>) {
                    print NEWSESSION "lastActive:". localtime()."\n";
                    print NEWSESSION "userID: $user";
                }
                login($user);
                printPageX($page, $file);
                return;
            }
        }
 
        if (($user ne $tmpUser) || (crypt($pwd, $salt) ne $tmpPwd)) {
            print "<div class = \"error\">Invalid username and password </div>";
            printDefaultBody("1");
        }
    }
 
    flock LOGIN, "8"; #unlock
    close(LOGIN); #close file
}
 

Hope this is enough information for somebody to help me.

Charles


EDIT: It is for an assignment for University and I am not allowed to use any of the inbuilt modules

[KevinADC]

try chomping before splitting:

while(<LOGIN>){
chomp;
@userpwd = split(":", $_);
###chomp;

[Charles Abetz]

The login part works fine too, what my problem is second time i use SESSION file handle, it doesn't write to the file that is created previously.

[KevinADC]

add some debugging and see if it helps:

open (NEWSESSION, ">$file") or die "can't open $file: $!";

nearly all system commands, such as open, should be checked for success or failure as a habit.