Stored Procedure returning multiple values

[Constantine AI]

Can anyone help?

Ive created the below stored procedure to allow an input parameter of post code to be entered to display properties which have this post code. The procedure creates fine but because i have two properties with the post code 'S1 4SG', the execution of the procedure fails, it gives the error:

ERROR at line 1:
ORA-01422: exact fetch returns more than requested number of rows
ORA-06512: at "CBRAID.PROC_PROPSEARCH", line 19
ORA-06512: at line 1

Im sure procedures can return more than one value, so does anyone know why its doesnt work or what i can do to make it work?

Below is the procedure and also how I execute and view it in the notepad file attached.

CREATE OR REPLACE PROCEDURE proc_PropSearch
(v_postcode IN Property.PostCode%TYPE,
v_propertyid OUT Property.PropertyID%TYPE,
v_propertytypeid OUT Property.PropertyTypeID%TYPE,
v_houseflatnum OUT Property.HouseFlatNumber%TYPE,
v_street OUT Property.Street%TYPE,
v_city OUT Property.City%TYPE,
v_county OUT Property.County%TYPE,
v_furnished OUT Property.Furnished%TYPE,
v_noofbedrooms OUT Property.NoOfBedrooms%TYPE,
v_noofensuites OUT Property.NoOfEnSuites%TYPE,
v_noofbathrooms OUT Property.NoOfBathrooms%TYPE,
v_receptionrooms OUT Property.NoOfReceptionRooms%TYPE,
v_propertydesc OUT Property.PropertyDesc%TYPE,
v_available OUT Property.Available%TYPE)
 
IS
BEGIN
    SELECT PropertyID, PropertyTypeID, HouseFlatNumber, Street, City, County, Furnished, NoOfBedrooms, NoOfEnSuites, NoOfBathrooms, NoOfReceptionRooms, PropertyDesc, Available
    INTO v_propertyid, v_propertytypeid, v_houseflatnum, v_street, v_city, v_county, v_furnished, v_noofbedrooms, v_noofensuites, v_noofbathrooms, v_receptionrooms, v_propertydesc, v_available 
    FROM Property
    WHERE PostCode = v_postcode;
END proc_PropSearch;

/

VARIABLE g_propertyid NUMBER
VARIABLE g_propertytypeid NUMBER
VARIABLE g_houseflatnum CHAR(4)
VARIABLE g_street VARCHAR2(30)
VARIABLE g_city VARCHAR2(30)
VARIABLE g_county VARCHAR2(30)
VARIABLE g_furnished CHAR(3)
VARIABLE g_noofbedrooms NUMBER
VARIABLE g_noofensuites NUMBER
VARIABLE g_noofbathrooms NUMBER
VARIABLE g_receptionrooms NUMBER
VARIABLE g_propertydesc VARCHAR2(50)
VARIABLE g_available CHAR(3)

EXECUTE proc_PropSearch ('S1 4SG', :g_propertyid, :g_propertytypeid, :g_houseflatnum, :g_street, :g_city, :g_county, :g_furnished, :g_noofbedrooms, :g_noofensuites, :g_noofbathrooms, :g_receptionrooms, :g_propertydesc, :g_available);
PRINT g_propertyid g_propertytypeid g_houseflatnum g_street g_city g_county g_furnished g_noofbedrooms g_noofensuites g_noofbathrooms g_receptionrooms g_propertydesc g_available

This is created in PL/SQL.
Thank you for help

[debasisdas]

That is because the SQl statment is returning more than one record.

Try to use cursor.

[Constantine AI]

That is because the SQl statment is returning more than one record.

Try to use cursor.

I am new to PL/SQL, could you show me the syntax of how the cursor should work with the stored procedure?

[debasisdas]

I am new to PL/SQL, could you show me the syntax of how the cursor should work with the stored procedure?

Please check for the articles in the HowTo section of Oracle in this forum for some related discussions.

[Constantine AI]

Hi I have incorporated a cursor into the stored procedure to return multiple values. The procedure with the cursor creates fine but it doesnt display the results in the DBMS_OUTPUT.PUT_LINE even when ive out SET SERVEROUTPUT ON. Can anybody see the problem?

Here is the code: -

SET SERVEROUTPUT ON
CREATE OR REPLACE PROCEDURE proc_PropSearch
(v_postcode         IN     Property.PostCode%TYPE,
v_propertyid         OUT     Property.PropertyID%TYPE,
v_propertytypeid     OUT     Property.PropertyTypeID%TYPE,
v_houseflatnum         OUT     Property.HouseFlatNumber%TYPE,
v_street         OUT     Property.Street%TYPE,
v_city             OUT     Property.City%TYPE,
v_county         OUT     Property.County%TYPE,
v_furnished         OUT     Property.Furnished%TYPE,
v_noofbedrooms         OUT     Property.NoOfBedrooms%TYPE,
v_noofensuites         OUT     Property.NoOfEnSuites%TYPE,
v_noofbathrooms     OUT     Property.NoOfBathrooms%TYPE,
v_receptionrooms     OUT     Property.NoOfReceptionRooms%TYPE,
v_propertydesc         OUT     Property.PropertyDesc%TYPE,
v_available         OUT     Property.Available%TYPE)
 
AS
CURSOR Cursor_PropSearch IS
SELECT PropertyID, PropertyTypeID, HouseFlatNumber, Street, City, County, Furnished, NoOfBedrooms, NoOfEnSuites, NoOfBathrooms, NoOfReceptionRooms, PropertyDesc, Available   
FROM Property
WHERE PostCode = v_postcode;
 
BEGIN
OPEN Cursor_PropSearch;
 
LOOP
    FETCH Cursor_PropSearch 
    INTO v_propertyid, v_propertytypeid, v_houseflatnum, v_street, v_city, v_county, v_furnished, v_noofbedrooms, v_noofensuites, v_noofbathrooms, v_receptionrooms, v_propertydesc, v_available; 
    EXIT WHEN Cursor_PropSearch%NOTFOUND OR 
        Cursor_PropSearch%NOTFOUND IS NULL;
 
DBMS_OUTPUT.PUT_LINE
(TO_CHAR(v_propertyid) || TO_CHAR(v_propertytypeid) || TO_CHAR(v_houseflatnum) || TO_CHAR(v_street) || TO_CHAR(v_city) || TO_CHAR(v_county) || TO_CHAR(v_furnished) || TO_CHAR(v_noofbedrooms) || TO_CHAR(v_noofensuites) || TO_CHAR(v_noofbathrooms) || TO_CHAR(v_receptionrooms) || TO_CHAR(v_propertydesc) || TO_CHAR(v_available));
 
END LOOP;
 
CLOSE Cursor_PropSearch;
END proc_PropSearch;
/
 

[debasisdas]

If you simply want to display the values using DBMS_OUTPUT why using all those OUT parameters ?

[BMantri]

Hello,

i have executed by trying a test procedure and i got the output :)
create or replace procedure test(p_name varchar2, p_type out varchar2)
is
cursor c1 is select tabtype from tab where tname = p_name;
begin
open c1;
loop
fetch c1 into p_type;
exit when c1%notfound;
dbms_output.put_line('The type is : ' || p_type);
end loop;
close c1;
end;
/


and the calling procedure as

SQL> declare
2 p_name varchar2(20) := 'TEST1';
3 p_type varchar2(20);
4 begin
5 test(p_name, p_type);
6 end;
7 /
The type is : TABLE

PL/SQL procedure successfully completed.


can you please conpare your procedure with these two?


Regards,

BMantri