procedure for numering records - no effect

[Dariusz Tomon]

Hi

I'm trying to add numers to "id" field in my "kadry" table. I write
procedure to do it (as follows) but running this procedure does make
no effect.
Where is bug?
best regards

D.T.

PROCEDURE KADRY_PROC_SEQ2
IS
BEGIN
declare
i number;
k number;
nazwisko varchar2(40);
cursor cur1 IS
select * from kadry;
BEGIN
k:=1;
for c1 IN cur1
loop
c1.id:=k;
k:=k+1;
end loop;
commit;
end;
END;

[Mark C. Stock]

"Dariusz Tomon" <d.*****@mazars.pl> wrote in message
news:c7************************@posting.google.com ...
| Hi
|
| I'm trying to add numers to "id" field in my "kadry" table. I write
| procedure to do it (as follows) but running this procedure does make
| no effect.
| Where is bug?
| best regards
|
| D.T.
|
| PROCEDURE KADRY_PROC_SEQ2
| IS
| BEGIN
| declare
| i number;
| k number;
| nazwisko varchar2(40);
| cursor cur1 IS
| select * from kadry;
| BEGIN
| k:=1;
| for c1 IN cur1
| loop
| c1.id:=k;
| k:=k+1;
| end loop;
| commit;
| end;
| END;
welcome to SQL ;-)

this code only reads the KADRY table and resets a variable in memory -- if
you want to change a value in the database you need to use an UPDATE
statement

;-{ mcs

[Jan]

simple SQL is enough
UPDATE your_table
SET id =rownum;

COMMIT;
d.*****@mazars.pl (Dariusz Tomon) wrote in message news:<c7************************@posting.google.co m>...

Hi

I'm trying to add numers to "id" field in my "kadry" table. I write
procedure to do it (as follows) but running this procedure does make
no effect.
Where is bug?
best regards

D.T.

PROCEDURE KADRY_PROC_SEQ2
IS
BEGIN
declare
i number;
k number;
nazwisko varchar2(40);
cursor cur1 IS
select * from kadry;
BEGIN
k:=1;
for c1 IN cur1
loop
c1.id:=k;
k:=k+1;
end loop;
commit;
end;
END;