Memory Leakage Due to ICON

[prpradip]

I have an ImageList (_imageList). In _imageList I have put large numbers of Icons.
Now what I need is to get Handle of all Icons that I put in _imageList, so that I can destroy (DestoryIcon) them all and release the memory because it's causing Memory leakage.

[prpradip]

I have thousands of Icon in my child application (A). All these icons are in ImageList (_imageList). At the end of application 'A', I have Destroyed _imageList. But, the momory being occupied by hundreds of Icons are still there causing memory leakage. So, whats the solution.

private void ChildForm_Load(object sender, EventArgs e)
        {
            Random r = new Random();
            for (int i = 0; i < 4000; i++)
            {
                int index = r.Next(1, 6);
                using (SysImageList sil = new SysImageList()) //SysImageList is class containing function to get Icon.
                {
                    System.Drawing.Icon ico = sil.Icon(index); //SysImagelist.Icon(int i) is the function to get the Icon using index.
                    if (ico != null)
                    {
                        imageList1.Images.Add(ico);
                    }
                }
            }
        }
 
[DllImport("comctl32.dll", CharSet = CharSet.Auto)]
 public static extern bool ImageList_Destroy(IntPtr hImageList);
-------------
protected override void Dispose(bool disposing)
        {
 
        bool destroyImgList = ImageList_Destroy(imageList1.Handle); //Returning always true.
 
            if (disposing && (components != null))
            {
                components.Dispose();
            }
            base.Dispose(disposing);
        }

But still there is memory leakage. Due to System.Drawing.Icon ico = sil.Icon(index);

So, how to handle this memory leakage

edit by mod: Please use [code] tags, not[indent] tags.

[r035198x]

ImageList.Images gives you all the images ...

[prpradip]

I know but thats the Image. Image is not convertable to Icon.....If we use
((Bitmap)image).Hicon()) to get Handle to Icon and destroy it. It's no meaning because it create and destory that Icon.

[Curtis Rutland]

Please don't double post your questions. If you made a mistake and need to change your question, you can click the Edit button to edit your post, or you can post your corrections in a reply to your original thread. If you can't find your original thread, click the "My Subscriptions" link near the top of the page. If you feel that your question has been overlooked, post a reply to it to "bump" it back to the top of the forum. We ask that you do this only once every 24 hours.

So there is no reason to double post. It makes it hard on the Experts and you to keep track of what help you've already been given.

Threads merged.

MODERATOR

[Plater]

I know your pain. I ran into this too.
You have to use win32_API to destroy hIcon references

Here it what I was doing, you might be able to modify it to fit your purposes

[System.Runtime.InteropServices.DllImport("User32.dll")]
private static extern bool DestroyIcon(IntPtr hIcon);
 
private Icon ImageToIcon(Image image)
{
   IntPtr ip= ((Bitmap)image).GetHicon();
   Icon i = (Icon)Icon.FromHandle(ip).Clone();
   DestroyIcon(ip);
   return i;
}
 
//then you can use the Icon.Destroy() where you are done with it
 

[prpradip]

Isn't there another way to release memory of icon rather than to call
Unmanaged

DestroyIcon(hicon);

icon.Dispose(); 

is not working anyway

[Plater]

Isn't there another way to release memory of icon rather than to call
Unmanaged

DestroyIcon(hicon);

icon.Dispose(); 

is not working anyway

Note my line about also calling:
Icon.Destroy()

[prpradip]

As we are creating Icon again and not destroying it

Icon i = (Icon)Icon.FromHandle(ip).Clone();

Doesn't it cause another leak?

[Plater]

@prpradip
Thus the win32_API I call to destroy the icon pointed to by "ip"

[prpradip]

Then doesn't it destroy new created Icon 'i' also?

[Plater]

No because you have made a clone of it into the Icon i