VB-APP downloading a file with webrequest HELP!!!

[raids51]

I am trying to download a file from the internet using webrequest... but most of the time i try to download a file it only downloads a small portion of the file...any help would be greatly appreciated. heres the code
The url is the url to download and the filename is the filename to save as

Private Sub downloadfile(ByVal url As String, ByVal filename As String)
        Dim wr As Net.HttpWebRequest = Net.HttpWebRequest.Create(url)
        Dim ws As Net.HttpWebResponse = CType(wr.GetResponse(), Net.HttpWebResponse)
        Dim str As IO.Stream = ws.GetResponseStream()
        Dim inBuf(100000000) As Byte
        Dim bytesToRead As Integer = CInt(inBuf.Length)
        Dim bytesRead As Integer = 0
        ProgressBar1.Maximum = ws.ContentLength
        While bytesToRead > 0
            Application.DoEvents()
            Dim n As Integer = str.Read(inBuf, bytesRead, bytesToRead)
            If n = 0 Then
                Exit While
            End If
            bytesRead += n
            bytesToRead -= n
            ProgressBar1.Value = bytesRead
            Label1.Text = bytesRead / 128 & "KB /" & ProgressBar1.Maximum / 128 & "KB"
        End While
        Dim fstr As New IO.FileStream("D:/" & filename, IO.FileMode.OpenOrCreate, IO.FileAccess.Write)
        fstr.Write(inBuf, 0, bytesRead)
        str.Close()
        fstr.Close()
    End Sub 

Please help!!!!

[joedeene]

Why are you making it so complicated on yourself? Especially using VB.Net, you can use the My.Computer.Network.DownloadFile() Method. It's always worked for me. Also, if why not use the WebClient.DownloadFile Method, (although I think it's the same as the first method, not positive). But, if you want help using the WebRequest Class, then I'll search Google for some tutorials, and get back to you :)

joedeene

[Plater]

(Lost my post darn it)

You make a few logical leaps, while good ideas, are incorrect.

For instance if you read zero bytes, you exit your loop. For smaller files on a faster connection that could be correct, but for larger files or when the connection is slow, the data might not be there yet by the time you go to read the data, so you exit your loop prematurally.

Also, at the time that you set bytesToRead, not all of the data could have arrived on the buffer. the .ContentLength proeprty (that you use for your ProgressBar) should contain the correct size.
EDIT: Oops, ok you are just blanket setting your stream and bytesToRead to a large number. Well you should still be using the ContentLength

Now, Application.DoEvents() might be enough to allow processing but a Thread.Sleep(10) would also potentially be usefull to allow the background IO to catch up.