ASP.NET Building String of Control.ID's

[Jelle]

I found this code on the Internet (Steve C. Orr). It works. But now I want to make a string of the id's like this:
strId = strId & checkbox.Id & ", " That does not work. Can anyone help me?

 
public Sub SetTextBoxBackColor(ByVal Page As Control, ByVal clr As color)
       For Each ctrl As Control In Page.Controls
            If TypeOf ctrl Is checkbox Then
                CType(ctrl, checkBox).BackColor = clr
                'txt = txt & CType(ctrl, checkBox).id
            Else
                If ctrl.Controls.Count > 0 Then
                    SetTextBoxBackColor(ctrl, clr)
                End If
            End If
        Next
    End Sub
 
'Anywhere in the code_behind:
SetTextBoxBackColor(Me, color.blue) 'VB.NET
 
 

[Jelle]

Hello,
I found this code on the internet and it works. It colors the checkbox. But now I want to make a string of all the Id's, like
txt = txt & checkbox.Id & ", ". But that doesn't work. Can anybody tell me how it should be?
Thanks.
Jelle

 
public Sub SetTextBoxBackColor(ByVal Page As Control, ByVal clr As color)
    dim txt as string        For Each ctrl As Control In Page.Controls
            If TypeOf ctrl Is checkbox Then
                CType(ctrl, checkBox).BackColor = clr
                'txt = txt & CType(ctrl, checkBox).id            Else
                If ctrl.Controls.Count > 0 Then
 
                    SetTextBoxBackColor(ctrl, clr)
                End If
            End If
        Next
 
    usermsgbox (txt)
    End Sub
 
 
 
'Anywhere in the code_behind:
    SetTextBoxBackColor(Me, color.blue) 'VB.NET
 
 
 
 

[joedeene]

How are you returning the 'txt' string variable? You're dimming it in the sub and therefore not accessible by other subs/functions. But try returning it somehow, either set a textbox's .text property to that string('txt') or do a messagebox.show() just to see what you're returning.

joedeene

[DrBunchman]

Hi Jelle,

Welcome to Bytes.com! I hope you find the site useful.

You've posted your question in the ASP Forum which is for Classic ASP only - I've moved it for you but in future please post all ASP.NET questions in the .NET Forum.

What do you mean by it doesn't work? Does it throw an error and if so what? Or are the results not as expected and if so what are they?

Thanks,

Dr B

[Jelle]

Thank you Yoodeene en DrBunchman. (I will ask further questions in ASP .net.)

What I want is the string of control.Id's and control.values
In my aspwebsite I made the names of the checkboxen equal to the tablefieldnames.
P.e
I have a table with three fields named:
chkFly
chkBus
chkCar

The checkboxes on the page have got the same names. Now when I get returned the names (and the values) in the For.. Each routine I posted, then I easily can make a SQL-routine.

P.e.
txtNames = "chkFly, chkBus, chkCar, "
txtValues = "True, False, True, "

INSERT INTO table (txtNames) VALUES txtValues;

I often use such a routine in VBA (Access) and I want to do simular in ASP .net.

I hope I made myself clear.

Jelle

[Jelle]

Hi,
Thanks to Joedeene I found the answer myself.
The messagebox in Asp.net can be programmed by the following code:

    Public Sub ASPNET_MsgBox(ByVal Message As String)
 
        System.Web.HttpContext.Current.Response.Write("<SCRIPT LANGUAGE=""JavaScript"">" & vbCrLf)
 
        System.Web.HttpContext.Current.Response.Write("alert(""" & Message & """)" & vbCrLf)
 
        System.Web.HttpContext.Current.Response.Write("</SCRIPT>")
 
    End Sub
 

And then I had to add the method: 'tostring'

strId = strId & checkbox.Id.tostring & ", "
And not:
strId = strId & checkbox.Id & ", "
 

But I don't understand the else code in the following routine. Is it because of the postback-function?

    public Function fncMakeSQLCtrlNames(ByVal Page As Control)
    dim ctrlCheckboxlist        as checkboxlist
    dim ctrlCheckbox            as checkbox
    dim ctrlRadioButton         as radiobutton
    dim ctrlRadiobuttonList     as RadioButtonlist
    Dim i as Integer
 
    For Each ctrl As Control In Page.Controls
        If TypeOf ctrl is checkBoxList Then
            ctrlCheckBoxList = ctrl
            if ctrlCheckBoxList.Items.count >0 then
                For i = 0 To ctrlCheckBoxList.Items.Count - 1
                    strSQLNames = strSQLNames  & ctrl.id.tostring & (i+1) & ", "
                Next
            End if
        Elseif Typeof ctrl is Radiobuttonlist then
            ctrlRadiobuttonlist = ctrl
            if ctrlradiobuttonlist.Items.count >0 then
                For i = 0 To ctrlRadiobuttonlist.Items.Count - 1
                    strSQLNames = strSQLNames  & ctrl.id.tostring & (i+1) & ", "
                Next
            End if
        Elseif Typeof Ctrl is checkBox then
            strSQLNames = strSQLNames  & ctrl.id.tostring & ", "
        Elseif Typeof ctrl is radiobutton then
            strSQLNames = strSQLNames  & ctrl.id.tostring & ", "
        Elseif Typeof Ctrl is TextBox then
            strSQLNames = strSQLNames  & ctrl.id.tostring & ", "
        Else
            If ctrl.Controls.Count > 0 Then
                fncMakeSQLCtrlNames(ctrl)
            End If
        End If
    Next
 
    fncMakeSQLCtrlNames = left(strSQLNames,(strSQLNames.length)-2)
    End Function
 
 

[Frinavale]

This seems to be extremely complicated for what you are trying to do!

It would be much more simple to add a checkboxlist to your page and then in your code that you implement for your "Submit" button click event check what the values are.

Not only that but the way you are creating your SQL statement leaves you open for an SQL Insertion attack. It is better to Parametrize your values when creating SQL statements.

Eg:

Protected Sub mySubmitButton_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles mySubmitButton.Click
 
  Dim fly As Boolean =  myCheckBoxList.Items(1).Selected
  Dim bus As Boolean = myCheckBoxList.Items(2).Selected
  Dim car As Boolean = myCheckBoxList.Items(3).Selected
 
  Dim connectionString As String = "<Connection String To My DB>"
 
  Dim dbCon As SqlConnection
  dbCon = New SqlConnection(connectionString)
  Dim sqlCom As New SqlCommand
 
  sqlCom.Connection = dbCon
  sqlcom.CommandType = CommandType.Text
  sqlCom.CommandText = "INSERT INTO table (chkFly, chkBus, chkCar) VALUES(@Fly,@Bus,@Car)"
 
  sqlCom.Parameters.Add("@Fly", SqlDbType.Boolean).Value = fly
  sqlCom.Parmaeters.Add("@Bus", SqlDbType.Boolean).Value = bus
  sqlCom.Parameters.Add("@Car",SqlDbType.Boolean).Value= car
 
  dbCon.Open()
  sqlcom.ExecuteNonQuery
  dbCon.Close()
End Sub

See this article for a very quick over view on how to use a database in your application...and see this article for more information on how to use dynamic controls in ASP.NET (if you insist on using dynamic controls when there is no reason to)

[Jelle]

Thanks. And for the articles.
Jelle