Telnet Client, Sockets trouble!

[marcf]

Hello Everyone!

I have so nearly finished a mud client for a customer to the point where I was about to send them the source code. Out of luck I took the project home to try it on my personal PC just to make sure.

At work on my corporate network everything works perfectly but it seems once anyone uses the client on a direct high speed connection to the internet the incoming text seems to all get jumbled up!

This is using system.net.sockets namespace i've left out a fair bit of code or this post will probably be too long.

My thinking is that on faster connections the dataarrival event is fired off BEFORE the current text has been displayed leading to the text getting mixed up?

If anyone can offer some suggestions here it would be massively appreciated as once this issue is resolved the project works perfectly, its also intended that the client will be provided free of charge to everyone so by helping me your helping people get free software!

Heres the source below...

Dim evtDataArrival As New AsyncCallback(AddressOf  Datarrive)
Public tcpClient As New System.Net.Sockets.TcpClient()
Dim buffer(1024) As Byte
Dim stream As NetworkStream
stream = tcpClient.GetStream
 
 
 
Private Function dataArrive(ByVal dr As IAsyncResult)
        Dim textin As String
 
        numberOfBytes = stream.EndRead(dr)
        ' At this instant DataBuffer variable is filled with the received data
        stream.Flush()
        textin = textin & Encoding.ASCII.GetString(buffer, 0, numberOfBytes)
 
        While stream.DataAvailable
            stream.BeginRead(buffer, 0, 1024, New AsyncCallback(AddressOf dataArrive), stream)
        End While
 
        If Not stream.DataAvailable Or Asc(Strings.Right(textin, 1)) = Val(Chr(32)) Then
            param = textin
            Settext(textin)
            words.Add(textin)
            param = ""
 
            If checktrig.IsAlive = False Then
                checktrig.Interrupt()
            End If
 
            stream.BeginRead(buffer, 0, 1024, evtDataArrival, Nothing)
 
        Else
            stream.BeginRead(buffer, 0, 1024, evtDataArrival, Nothing)
        End If
 
    End Function
 
 Private Function Settext(ByVal param As String) As String
        Dim networkStream As NetworkStream = tcpClient.GetStream()
        Dim pos As Integer
        Dim pos2
        Dim esccode As String
        Dim i As Integer
        Dim parse As String
        Dim myregex As New Regex("(?s)(?:\e\[(?:(\d+);?)*([A-Za-z])(.*?))")
        Dim myresults As MatchCollection
        '(?=\e\[|\z)
 
        If Me.RichTextBox1.InvokeRequired Then
            Dim d As New Stt(AddressOf Settext)
            RichTextBox1.Invoke(d, param)
        Else
            i = 0
            pos = 1
            myresults = myregex.Matches(Trim(param))
 
            If myresults.Count > 0 Then
                Do Until pos = param.Length
 
                    If i <> myresults.Count Then
                        esccode = myresults(i).Value
                        parse = Strings.Mid(param, pos, IIf(myresults(i).Index <= pos, (myresults(i).Index - (pos - 1)), (myresults(i).Index - pos)) + 1)
                    Else
                        parse = Strings.Mid(param, pos, param.Length)
                        pos = param.Length
 
                    End If
 
                    If Not Strings.Left(parse, 1) = Chr(27) Then
                        Me.RichTextBox1.SelectionColor = vcolour
                        RichTextBox1.AppendText(parse)
                        SendMessage(RichTextBox1.Handle, WM_VSCROLL, SB_BOTTOM, 0)
                    End If
 
                    If esccode <> "" Then
                        Select Case esccode
                            Case Chr(27) & "[1m"
                                RichTextBox1.SelectionFont = New Font(RichTextBox1.Font.ToString, RichTextBox1.Font.Size, FontStyle.Bold)
                                Exit Select
                            Case Chr(27) & "[0m"
                                RichTextBox1.SelectionFont = New Font(RichTextBox1.Font.ToString, RichTextBox1.Font.Size, FontStyle.Regular)
                                vcolour = Color.Lime
                                Exit Select
                            Case Chr(27) & "[33m"
                                vcolour = Color.Yellow
                                Exit Select
                            Case Chr(27) & "[35m"
                                vcolour = Color.Magenta
                                Exit Select
                            Case Chr(27) & "[36m"
                                vcolour = Color.Cyan
                                Exit Select
                        End Select
                    End If
 
                    If i <> myresults.Count Then
                        pos = (myresults(i).Index + Len(esccode)) + 1
                        esccode = ""
                        i = i + 1
                    End If
                Loop
            Else
                Me.RichTextBox1.SelectionColor = vcolour
                RichTextBox1.AppendText(param)
                SendMessage(RichTextBox1.Handle, WM_VSCROLL, SB_BOTTOM, 0)
            End If
        End If
    End Function
 

[marcf]

As an update i've confirmed its he event firing multiple times while its still trying to display, any ideas on how to make the second firing of the event wait until all previous ones have finished?

[Plater]

Perhaps buffer a collection of bytes before displaying them.
Like either wait till X amount of bytes have come in or 0.5seconds have passed with no data arrival?

I would also recomend cleaning up your parsing code. It's almost all plain VB and not VB.NET, it might make a difference.