Unchecking a check all checkbox.

[Ryanfromscotland]

Hey there everyone, this is my first post so be nice :-) I have wrote quite a bit so the actual question is written out at the end if you want to skip on and see if you can answer it without the rest of the info.

I'm a hobbiest programmer and have taken up the project of writing a savestate editor - if you don't know what that is it's not really important - but I am having a bit of trouble with some code and google isn't turning up the answer although I think it may be my search terms rather than it not being asked before so appologise if this has already been asked many a time, I have done a search!

I have got a series of 28 checkboxes and a 29th which checks and unchecks them all as appropriate. I have also got code so that if you manually select them all then the 29th checkbox becomes checked. My problem is getting the checkbox to uncheck if you manually uncheck one of the other 28 boxes.

Here is my code and I will put a little explanation afterwards.

NOTE - The 29th checkbox is called checkbox1.

Private Sub CheckBoxChecker(ByVal sender As Object, ByVal e As System.EventArgs) Handles CheckBox2.CheckedChanged, _
    CheckBox3.CheckedChanged, CheckBox4.CheckedChanged, CheckBox5.CheckedChanged, CheckBox6.CheckedChanged, _
    CheckBox7.CheckedChanged, CheckBox8.CheckedChanged, CheckBox9.CheckedChanged, CheckBox10.CheckedChanged, _
    CheckBox11.CheckedChanged, CheckBox12.CheckedChanged, CheckBox13.CheckedChanged, CheckBox14.CheckedChanged, _
    CheckBox15.CheckedChanged, CheckBox16.CheckedChanged, CheckBox17.CheckedChanged, CheckBox18.CheckedChanged, _
    CheckBox19.CheckedChanged, CheckBox20.CheckedChanged, CheckBox21.CheckedChanged, CheckBox22.CheckedChanged, _
    CheckBox23.CheckedChanged, CheckBox24.CheckedChanged, CheckBox25.CheckedChanged, CheckBox26.CheckedChanged, _
    CheckBox27.CheckedChanged, CheckBox28.CheckedChanged, CheckBox29.CheckedChanged
 
        If CheckBox2.Checked And CheckBox3.Checked And CheckBox4.Checked And CheckBox5.Checked And CheckBox6.Checked _
              And CheckBox7.Checked And CheckBox8.Checked And CheckBox9.Checked And CheckBox10.Checked And CheckBox11.Checked _
              And CheckBox12.Checked And CheckBox13.Checked And CheckBox14.Checked And CheckBox15.Checked And CheckBox16.Checked _
              And CheckBox17.Checked And CheckBox18.Checked And CheckBox19.Checked And CheckBox20.Checked And CheckBox21.Checked _
              And CheckBox22.Checked And CheckBox23.Checked And CheckBox24.Checked And CheckBox25.Checked And CheckBox26.Checked _
              And CheckBox27.Checked And CheckBox28.Checked And CheckBox29.Checked = True Then CheckBox1.Checked = True
    End Sub
 
 
 
 
    Private Sub checkboxall(ByVal sender As Object, ByVal e As System.EventArgs) Handles CheckBox1.CheckedChanged
        If CheckBox1.Checked = True Then CheckBox2.Checked = True Else CheckBox2.Checked = False
        If CheckBox1.Checked = True Then CheckBox3.Checked = True Else CheckBox3.Checked = False
        If CheckBox1.Checked = True Then CheckBox4.Checked = True Else CheckBox4.Checked = False
        If CheckBox1.Checked = True Then CheckBox5.Checked = True Else CheckBox5.Checked = False
        If CheckBox1.Checked = True Then CheckBox6.Checked = True Else CheckBox6.Checked = False
        If CheckBox1.Checked = True Then CheckBox7.Checked = True Else CheckBox7.Checked = False
        If CheckBox1.Checked = True Then CheckBox8.Checked = True Else CheckBox8.Checked = False
        If CheckBox1.Checked = True Then CheckBox9.Checked = True Else CheckBox9.Checked = False
        If CheckBox1.Checked = True Then CheckBox10.Checked = True Else CheckBox10.Checked = False
        If CheckBox1.Checked = True Then CheckBox11.Checked = True Else CheckBox11.Checked = False
        If CheckBox1.Checked = True Then CheckBox12.Checked = True Else CheckBox12.Checked = False
        If CheckBox1.Checked = True Then CheckBox13.Checked = True Else CheckBox13.Checked = False
        If CheckBox1.Checked = True Then CheckBox14.Checked = True Else CheckBox14.Checked = False
        If CheckBox1.Checked = True Then CheckBox15.Checked = True Else CheckBox15.Checked = False
        If CheckBox1.Checked = True Then CheckBox16.Checked = True Else CheckBox16.Checked = False
        If CheckBox1.Checked = True Then CheckBox17.Checked = True Else CheckBox17.Checked = False
        If CheckBox1.Checked = True Then CheckBox18.Checked = True Else CheckBox18.Checked = False
        If CheckBox1.Checked = True Then CheckBox19.Checked = True Else CheckBox19.Checked = False
        If CheckBox1.Checked = True Then CheckBox20.Checked = True Else CheckBox20.Checked = False
        If CheckBox1.Checked = True Then CheckBox21.Checked = True Else CheckBox21.Checked = False
        If CheckBox1.Checked = True Then CheckBox22.Checked = True Else CheckBox22.Checked = False
        If CheckBox1.Checked = True Then CheckBox23.Checked = True Else CheckBox23.Checked = False
        If CheckBox1.Checked = True Then CheckBox24.Checked = True Else CheckBox24.Checked = False
        If CheckBox1.Checked = True Then CheckBox25.Checked = True Else CheckBox25.Checked = False
        If CheckBox1.Checked = True Then CheckBox26.Checked = True Else CheckBox26.Checked = False
        If CheckBox1.Checked = True Then CheckBox27.Checked = True Else CheckBox27.Checked = False
        If CheckBox1.Checked = True Then CheckBox28.Checked = True Else CheckBox28.Checked = False
        If CheckBox1.Checked = True Then CheckBox29.Checked = True Else CheckBox29.Checked = False
    End Sub
 

If CheckBox1 is checked then it checks the rest. If CheckBox1 is unchecked it unchecks the rest. If there is a change in CheckBox2-29 it checks to see what the rest are like and if they are all checked it checks CheckBox1 but putting an "else checkbox1.checked = false" there does not work. The problem with that is it messes up the functioning of CheckBox1 since when CheckBox1 changes CheckBox2 it raises the event CheckBox2.CheckedChanged which then checks against all the other values to see if they are equal and since they aren't yet it reverts CheckBox1 back to unchecked!

So any suggestions on how can I get the check all check box to uncheck when not all items are checked in Visual Basic 2005?

[Semajthewise]

The way you have your code written is causing the problem you are going to have to handle each checkbox seperately. like so

' this part of the code checks to see if all others are checked and checks 
' unchecks box 1 as needed (Note leave out the current checkbox your working on)
Private Sub CheckBoxChecker(ByVal sender As Object, ByVal e As System.EventArgs) Handles CheckBox2.CheckedChanged
 If CheckBox3.Checked And CheckBox4.Checked And CheckBox5.Checked And CheckBox6.Checked _
              And CheckBox7.Checked And CheckBox8.Checked And CheckBox9.Checked And CheckBox10.Checked And CheckBox11.Checked _
              And CheckBox12.Checked And CheckBox13.Checked And CheckBox14.Checked And CheckBox15.Checked And CheckBox16.Checked _
              And CheckBox17.Checked And CheckBox18.Checked And CheckBox19.Checked And CheckBox20.Checked And CheckBox21.Checked _
              And CheckBox22.Checked And CheckBox23.Checked And CheckBox24.Checked And CheckBox25.Checked And CheckBox26.Checked _
              And CheckBox27.Checked And CheckBox28.Checked And CheckBox29.Checked = True Then CheckBox1.Checked = True
' when you uncheck this box checkbox1 will also be unchecked 
If CheckBox2.Checked = False Then
            CheckBox1.Checked = False
end sub
 
 

Your second piece of code for checking and unchecking all boxes looks fine.

Sorry to make your code longer but there is no other way.

Good luck,
James

[Ryanfromscotland]

Hey thanks for the reply although I think that code will still raise the same problem as the orignal.

When the all-checkbox is checked it will first check checkbox2 which will then go and see if the rest are checked and since they won't be yet it will result in the all-checkbox becoming unchecked again.

I'll go give it a try though and cross my fingers.

EDIT - Na it's not working but it's cool I'm going to change it to two buttons instead a check all and uncheck all one, that will work better.

[Semajthewise]

I Believe tha is the best way using 2 boxes one to check all and 1 to uncheck all. you can still do the check on the other boxes to see if all are checked.


Happy coding
James