delete statement

[zaiena]

hi,
i'm working in asp.net using visual studio 2005 with vb language,
my tables is access database, will i'm trying to write the delete statement to delete some fields in my tables i wrote this statement and have no errors but the row didn't deleted. here is my code:

Public Function DeleteQuestion(ByVal Question_ID As Integer)
        Dim cmd As New OleDbCommand("Delete from Questions where Question_id= @Question_id)", conn)
        Try
            conn.Open()
            cmd.ExecuteNonQuery()
        Catch ex As Exception
            ex.Message.ToString()
        End Try
        conn.Close()
        If er = "" Then
 
            Return "the Question has been Deleted succefully!!!!"
 
        Else
 
            Return er
        End If
    End Function
End Class

so any one can help or tell me where the problem is or if i miss something here????

[Shashi Sadasivan]

How did you check that no exceptions were thrown?

From your code, if the exception occours, you are creating a reference of the message exception string but nothing happens with that reference.

it would be better if you put it in a messagebox so some output window.

Since your database is Access you should use brackets around field names

Delete from [Questions] where [Question_id]= @Question_id

The other thing about the command you wrote is, what is @Question_id ?
when and wher are u assigning it?


Your query should look more likee

Delete from [Questions] where [Question_id]= ?

and use the AddParameter method for the sql command

[kunal pawar]

try this code

Dim cmd As New OleDbCommand("Delete from Questions where Question_id=" & Question_ID , conn)
 
And update ur function 
Public Function DeleteQuestion(ByVal Question_ID As Integer)
        Dim cmd As New OleDbCommand("Delete from Questions where Question_id=" & Question_ID , conn)
        Try
            conn.Open()
            cmd.ExecuteNonQuery()
        Catch ex As Exception
            ex.Message.ToString()
        End Try
        conn.Close()
        If er = "" Then
 
            Return "the Question has been Deleted succefully!!!!"
 
        Else
 
            Return er
        End If
    End Function
End Class

[zaiena]

try this code

Dim cmd As New OleDbCommand("Delete from Questions where Question_id=" & Question_ID , conn)
 
And update ur function 
Public Function DeleteQuestion(ByVal Question_ID As Integer)
        Dim cmd As New OleDbCommand("Delete from Questions where Question_id=" & Question_ID , conn)
        Try
            conn.Open()
            cmd.ExecuteNonQuery()
        Catch ex As Exception
            ex.Message.ToString()
        End Try
        conn.Close()
        If er = "" Then
 
            Return "the Question has been Deleted succefully!!!!"
 
        Else
 
            Return er
        End If
    End Function
End Class

hello,
i'm trying your statement and i'ts totaly work thank you very much.