.NET Exception Handling

[spartacus]

I have never understood how to throw exceptions properly. If my method is supposed to return an array, when I try to throw the error "ex.Message.ToString() it won't compile. The method is calling for an array but the error throws string. I know this is really stupid of me, but can someone help me with this very basic concept....PLEASE!!!!!

Thanks so much!

Spartacus

[Shashi Sadasivan]

try
{
   //your code goes here
} 
catch(Exception ex)
{
   MessageBox.Show(ex.Message);
}

thats a usual try catch block.
Your array code (which has the array in it) should be sitting in the try block.
and if that fails, it enters the catch block.
If an exception occours, its details are contained in the Exception object representend by "ex" above.
The object "ex" does not require/ask for an array in the ex.Message.toString() method.
if you debug this code, and if it enters the catch statement, hover your mouse on ex to see its methods and properties and what they contain.

cheers

[spartacus]

try
{
   //your code goes here
} 
catch(Exception ex)
{
   MessageBox.Show(ex.Message);
}

thats a usual try catch block.
Your array code (which has the array in it) should be sitting in the try block.
and if that fails, it enters the catch block.
If an exception occours, its details are contained in the Exception object representend by "ex" above.
The object "ex" does not require/ask for an array in the ex.Message.toString() method.
if you debug this code, and if it enters the catch statement, hover your mouse on ex to see its methods and properties and what they contain.

cheers

Thanks so much for the response, I left out something, this is for a web service and and I am filling a dataset which then is used to populate an array. I want to check for sql errors. Below id the method:

   [WebMethod(Description = "Returns weekly revenue levels by day!")]
    public dataForWeekVO[] DataForWeek(string dteWEDate, string strType)
    {
        DateTime shpDate = Convert.ToDateTime(dteWEDate);
 
        cn = new SqlConnection(sqlCSConnectionString);
        System.Data.SqlClient.SqlCommand cmd = new SqlCommand("WE_DataForWeek_S", cn);
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.AddWithValue("@wedate", shpDate);
        cmd.Parameters.AddWithValue("@type", strType);
 
        cn.Open();
 
        try
        {
 
            SqlDataAdapter da = new SqlDataAdapter(cmd);
            System.Data.DataSet ds = new System.Data.DataSet();
            da.Fill(ds, "DataForWeek");
 
            int c = (ds.Tables["WeeklyData"].Rows.Count);
            dataForWeekVO[] dataForWeek = new dataForWeekVO[c];
 
            for (int i = 0; i < (ds.Tables["DataForWeek"].Rows.Count); i = i + 1)
            {
               DataRow aRow = ds.Tables[0].Rows[i];
               dataForWeek[i] = new dataForWeekVO();
               dataForWeek[i].date = Convert.ToDateTime(aRow["Date"].ToString());
               dataForWeek[i].ddd = Convert.ToDecimal(aRow["DDD"].ToString());
               dataForWeek[i].dtrl = Convert.ToDecimal(aRow["DTRL"].ToString());
               dataForWeek[i].cnsd = Convert.ToDecimal(aRow["CNSD"].ToString());
               dataForWeek[i].usps = Convert.ToDecimal(aRow["USPS"].ToString());
              dataForWeek[i].smtp = Convert.ToDecimal(aRow["SMTP"].ToString());
                dataForWeek[i].lsca = Convert.ToDecimal(aRow["LSCA"].ToString());
                dataForWeek[i].fxce = Convert.ToDecimal(aRow["FXCE"].ToString());
                dataForWeek[i].fxh3 = Convert.ToDecimal(aRow["FXH3"].ToString());
                dataForWeek[i].total = Convert.ToDecimal(aRow["Total"].ToString());
 
            }
 
            return dataForWeek;
 
        }
 
        catch (System.Data.SqlClient.SqlException ex)
        {
            throw ex.Message.ToString();
 
 
        finally
        {
            if (cn.State == ConnectionState.Open)
            {
                cn.Close();
            }
        }
 
    }

The above code won't compile. The compile error is "not all code paths return a value". Also since it's a web service should I be using HTTPException or SOAPException?

Thanks again for you help!

spatacus

[Shashi Sadasivan]

catch (System.Data.SqlClient.SqlException ex)
        {
            throw ex.Message.ToString();
 
 
        finally
        {
            if (cn.State == ConnectionState.Open)
            {
                cn.Close();
            }
        }

the catch statment dosent have an end to it.

why the compiler refuses to compile it is because it senses more than one path and checks if it goes through any path, there is something that is returned.

If you put a return statement after the finally block it will work.

[krispaks]

I have this function which will accept a time as string

Public Shared Function SpecTime(ByVal timeStr As String) As String
Dim dt As DateTime
If String.IsNullOrEmpty(timeStr) Then
Return ""
Else
Try
dt = DateTime.Parse("1/8/1985 " + timeStr)
Catch ex As Exception

End Try
Return dt.ToString("h:mm tt")
End If
End Function

when i input an invalid time str eg. "1a", how do i know the unique code for that specific exception? how will it know that "12 a" is invalid or "12;00" is invalid???

my point here is that i need to know the unique exception code (if there is any) so i could handle the different exceptions accordingly.

tnx!