Pig latin program

[johnmac]

i got my pig latin program which looks like this
Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtenglish.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"
Else
stranswer = txtanswer.Text
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
stranswer = strOutput

i was wondering why it won't show the results in the 2nd text output box(stranswer)

thank you

[Plater]

Oh VB, how I dislike you....

Anyways, it looks like you only set the output stuff if it doesn't start with a vowel?

Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtenglish.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"
Else
stranswer = txtanswer.Text
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
stranswer = strOutput
 

I'd do this:?
C#

private string EnglishWordToPigLatinWord(string EnglishWord)
{
   string retval="";
   if (EnglishWord.Length > 0)
   {
      char FirstLetter=EnglishWord.ToUpper()[0];
      if ((FirstLetter='A')||(FirstLetter='E')||(FirstLetter='I')||(FirstLetter='O')||(FirstLetter='U'))
      {
         retval=EnglishWord+"way";
      }
      else
      {//regular
         retval=EnglishWord.SubString(1);
         retval+=EnglishWord[0]+"ay";
      }
   }
   else
   {
      retval=EnglishWord;
   }
   return retval;
}
 

[balabaster]

Oh VB, how I dislike you....

Anyways, it looks like you only set the output stuff if it doesn't start with a vowel?

Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtenglish.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"
Else
stranswer = txtanswer.Text
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
stranswer = strOutput
 

You could've cut down your typing by using a case statement there...you probably wouldn't dislike VB so much :P

Select Case str1stCharacter.ToUpper
Case "A", "E", "I", "O", "U" : 'Do your stuff
Case Else : 'Do different stuff
End Select

[Plater]

You could've cut down your typing by using a case statement there...you probably wouldn't dislike VB so much :P

I dislike VB for a whole mess of reasons, one of which is that VB on a whole, is a mess.

[balabaster]

I dislike VB for a whole mess of reasons, one of which is that VB on a whole, is a mess.

And that is a debate that will go on between VB programmers and C# programmers until the end of time ;) I come from both camps...I hate inheriting people's C# code but am quite comfortable writing my own. If I inherit someone else's code, I'd much rather it was VB. It's like reading English instead of reading Math...

[Plater]

I'd much rather it was VB. It's like reading English instead of reading Math...

That was my exact argument, only in reverse lol. dim stdTersadf makes less sence to me then "Int32 myint"
(and yes I made those variable names to follow the programming style I see on these boards)
As a side note, I "started" in VB as well.


But on the matter at hand, did that piglatin thing work correctly?

[johnmac]

sorry , I'm a beginner at visual basics.
so far i have this.
Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtenglish.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"

Else
stranswer = txtanswer.Text
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
stranswer = strOutput

2 text
1 for english input(txtenglish)
and 1 for piglatin output(txtanswer)
so how come when i press compute
it doesn't show up in output
sorry if this annoys anyone
i'm just a beginner

[Plater]

This line:
stranswer = txtanswer.Text

sets stranswer to be whatever value is stored in txtanswer.Text
Not the other way around.
Try this:
txtanswer.Text=stranswer


Also, you need to make sure code gets execute in the right order.
They execute top to bottom. So if you set txtanswer.Text=stranswer then change the value of stranswer, the value in txtanswer.Text will NOT change unless you set it again with txtanswer.Text=stranswer

[johnmac]

Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtinput.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"
Else
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
strOutput = stranswer
txtoutput.Text = stranswer

i've left it like this and it still doesn't work
damn

[balabaster]

Dim strInput, str1stCharacter, strOutput, stranswer As String, intStringLength As Integer
strInput = txtinput.Text
str1stCharacter = Microsoft.VisualBasic.Left(strInput, 1)
If str1stCharacter = "A" Or str1stCharacter = "E" Or str1stCharacter = "I" Or str1stCharacter = "O" Or str1stCharacter = "U" Then
strOutput = strInput & "WAY"
Else
intStringLength = Len(strInput) - 1
strOutput = Microsoft.VisualBasic.Right(strInput, intStringLength) & str1stCharacter & "WAY"
strOutput = stranswer
txtoutput.Text = stranswer

i've left it like this and it still doesn't work
damn

Well aside from the obvious:
Missing End If

I can't believe this question is still going round in circles :oP

 Dim str1stChar, strInput As String 
strInput = txtInput.Text
str1stChar = txtInput.Text.Substring(0, 1)
Dim strOutput As String = ""
Select Case str1stChar.ToUpper
Case "A", "E", "I", "O", "U"
    strOutput = strInput.ToUpper
Case Else
    strOutput = (strInput.Substring(1) & str1stChar).ToUpper
End Select
strOutput &= "WAY"
txtOutput.Text = strOutput

Use this code...it works.

[balabaster]

Well aside from the obvious:
Missing End If

I can't believe this question is still going round in circles :oP

Dim str1stChar, strInput As String 
strInput = txtInput.Text
str1stChar = txtInput.Text.Substring(0, 1)
Dim strOutput As String = ""
Select Case str1stChar.ToUpper
Case "A", "E", "I", "O", "U"
    strOutput = strInput.ToUpper
Case Else
    strOutput = (strInput.Substring(1) & str1stChar).ToUpper
End Select
strOutput &= "WAY"
txtOutput.Text = strOutput

Use this code...it works.

And actually, in the immortal words of Luca Bolognese, "there is something displeasing with this code", what if we do:

Function IsVowel(ByVal InputChar As Char) As Boolean
  Dim Vowels() As Char = {"A", "E", "I", "O", "U"}
  Return Not Array.IndexOf(Vowels, InputChar) = -1
End Function
 
Dim strInput As String = txtInput.Text.ToUpper
Dim strOutput As String = strInput
Dim str1stChar As Char = strInput.Substring(0, 1)
If IsVowel(str1stChar) Then strOutput = strInput.Substring(1) & str1stChar
strOutput &= "WAY"
txtOutput.Text = strOutput

There...that's much more elegant...and more flexible, you can add any items you want to the char array for your 1st char without having to do "OR str1stChar = "n" OR str1stChar = "r" etc etc

[balabaster]

And actually, in the immortal words of Luca Bolognese, "there is something displeasing with this code", what if we do:

Function IsVowel(ByVal InputChar As Char) As Boolean
  Dim Vowels() As Char = {"A", "E", "I", "O", "U"}
  Return Not Array.IndexOf(Vowels, InputChar) = -1
End Function
 
Dim strInput As String = txtInput.Text.ToUpper
Dim strOutput As String = strInput
Dim str1stChar As Char = strInput.Substring(0, 1)
If IsVowel(str1stChar) Then strOutput = strInput.Substring(1) & str1stChar
strOutput &= "WAY"
txtOutput.Text = strOutput

There...that's much more elegant...and more flexible, you can add any items you want to the char array for your 1st char without having to do "OR str1stChar = "n" OR str1stChar = "r" etc etc

Damnit, now I find myself keep coming back to this question pitting myself against it to try and get it down to as few lines of code as possible! It's like othello...a minute to learn, a lifetime to master...I feel a competition coming on. Who can achieve this in as few lines of code as possible?

Function IsVowel(ByVal InputChar As Char) As Boolean
  Return Not Array.IndexOf(New Char() {"A", "E", "I", "O", "U"}, InputChar) = -1
End Function
 
Dim strInput As String = txtInput.Text.ToUpper
Dim strOutput As String = strInput
Dim str1stChar As Char = strInput.Substring(0, 1)
If IsVowel(str1stChar) Then strOutput = strInput.Substring(1) & str1stChar
strOutput &= "WAY"
txtOutput.Text = strOutput

[balabaster]

Damnit, now I find myself keep coming back to this question pitting myself against it to try and get it down to as few lines of code as possible! It's like othello...a minute to learn, a lifetime to master...I feel a competition coming on. Who can achieve this in as few lines of code as possible?

Function IsVowel(ByVal InputChar As Char) As Boolean
Return Not Array.IndexOf(New Char() {"A", "E", "I", "O", "U"}, InputChar) = -1
End Function
 
Dim strInput As String = txtInput.Text.ToUpper
Dim strOutput As String = strInput
Dim str1stChar As Char = strInput.Substring(0, 1)
If IsVowel(str1stChar) Then strOutput = strInput.Substring(1) & str1stChar
strOutput &= "WAY"
txtOutput.Text = strOutput

Or you could do it in two lines. It's not quite as easy to read though...
VB

Dim strInput As String = txtInput.Text.ToUpper
txtOutput.Text = (IIf(Array.IndexOf(New Char() {"A", "E", "I", "O", "U"}, CChar(strInput.Substring(0,1))) = -1, strInput.Substring(1) & strInput.Substring(0, 1), strInput) & "WAY").ToUpper()

I don't think I can reasonably cut it down any further than that...Ben 1-0 VB.NET :D

My work here is done...

[Plater]

Or you could do it in two lines. It's not quite as easy to read though...
VB

Dim strInput As String = txtInput.Text.ToUpper
txtOutput.Text = (IIf(Array.IndexOf(New Char() {"A", "E", "I", "O", "U"}, CChar(strInput.Substring(0,1))) = -1, strInput.Substring(1) & strInput.Substring(0, 1), strInput) & "WAY").ToUpper()

I don't think I can reasonably cut it down any further than that...Ben 1-0 VB.NET :D

My work here is done...

What if you changed all references of "strinput" to "txtInput.Text.ToUpper"
Then it would be one line?

[balabaster]

What if you changed all references of "strinput" to "txtInput.Text.ToUpper"
Then it would be one line?

I thought hard about that one...I was going to, but then I have a rule of thumb that if I'm going to need to reference a property of an object more than once that I store that property in a variable because it lessens the code...here we reference it a whole bunch of times. Now in VB 2008 type inferencing you could scrap the "As String" which cuts it down a bit more, but I don't think (at least as far as keystrokes) it can be cut down further without changing to a shorter variable name such as sIn instead of strInput.