Splitting a String Issues

[mknoll217]

Hello. I am trying to split a string. The string is "lastname, firstname". I need to obviously split the two up. I keep trying to rewrite my code and at this point am not sure of why am I getting the error. The string is coming from the last page of the website. It is telling me in my error "Object reference not set to an instance of an object " refering to line 6.
After looking at many examples I still can't see what the issue is.

        string firstName;
        string lastName;
 
        string name = Request.QueryString["name"];
 
        string[] nameSplit = name.Split(',');
 
        firstName = nameSplit[0];
        lastName = nameSplit[1];
 
 

I appreciate any feedback. Also if there is an easier way to do this that would be greatly appreciated too. Thanks.

[Lokean]

Try something along this line


string[] a;
string b = "next, for";
a = b.Split(",");

when you use the split function, the array is called implicitly. If you call it explicitly, you get that error.

i.e. the above code is correct, the code below would generate an error

string[] a;
string b = "next, for";
a[] = b.Split(",");


string firstName;
string lastName;
string nameSplit[];

string name = Request.QueryString["name"];

nameSplit = name.Split(',');

firstName = nameSplit[0];
lastName = nameSplit[1];


in your example, just omit the declaration

[mknoll217]

Thanks. I tried that and I'm still getting the same error.

[Lokean]

Thanks. I tried that and I'm still getting the same error.

could you post your code from the top? Start with the "using", if you're not referencing the right libraries, that might cause the problem.

[Plater]

        string name = Request.QueryString["name"];
 

I would be more suspect of this line returning an empty string.
You should be doing much more error checking/correction there

[nateraaaa]

Hello. I am trying to split a string. The string is "lastname, firstname". I need to obviously split the two up. I keep trying to rewrite my code and at this point am not sure of why am I getting the error. The string is coming from the last page of the website. It is telling me in my error "Object reference not set to an instance of an object " refering to line 6.
After looking at many examples I still can't see what the issue is.

        string firstName;
        string lastName;
 
        string name = Request.QueryString["name"];
 
        string[] nameSplit = name.Split(',');
 
        firstName = nameSplit[0];
        lastName = nameSplit[1];
 
 

I appreciate any feedback. Also if there is an easier way to do this that would be greatly appreciated too. Thanks.

When referencing querystrings in your code you need to always check to see if the querystring value is != null before you try to access the value.

if(Request.QueryString["name"] != null)
{
        string name = Request.QueryString["name"];
        if(name!=null)
        {
            string[] nameSplit = name.Split(',');
 
            firstName = nameSplit[0];
            lastName = nameSplit[1];
        }
 
}

This should keep you from getting the error that you mentioned.

Nathan