Dot net error discussion

[lingarajnandi]

Hello

I am writing the following code

public bool validation(string uname, string pword)
{
uname = username;
pword = password;

dbinsert db = new dbinsert();
SqlDataReader dr = db.Datareader("select Password from registration where UserName='" + uname.ToString() + "'");


if (dr.Read())
{

if (pword == dr["Password"].ToString())
{
return (true);
}
else
{
return (false);
}
}

The above error is showing the following error

Description: An error occurred during the compilation of a resource required to service this request. Please review the following specific error details and modify your source code appropriately.

Compiler Error Message: CS0161: 'LoginCtrl.validation(string, string)': not all code paths return a value

Source Error:



Line 51: }
Line 52:
Line 53: public bool validation(string uname, string pword)
Line 54: {
Line 55: uname = username;


Source File: d:\AJAXEnabledWebSite1\LoginCtrl.ascx.cs Line: 53



Pleaes solve the problem as soon as possible

[teakwood85]

give another "return" true/false outside the if/else statement.

-Jati Indrayanto

[Paulson]

give another "return" true/false outside the if/else statement.

-Jati Indrayanto

Hi RajNandi


I have been working in vb and urs is c#,but still i think if you just dclare
a variable for exampl result as boolean and set its value instead of returning true false directly I think it shud work. ie
your

code part

__________________________________________________ _______________

if (dr.Read())
{

if (pword == dr["Password"].ToString())
{
return (true);
}
else
{
return (false);
}
}

__________________________________________________ _______________

must be as follows ----->

__________________________________________________ _______________

if (dr.Read())
{

if (pword == dr["Password"].ToString())
{
result =true;
}
else
{
result =false;
}
return;
}

__________________________________________________ _______________


Try this and check if it works if it works pls inform,sorry if I could not help you

Anyway keep the good work going.



bye Paulson.

[TRScheel]

Hello

I am writing the following code

public bool validation(string uname, string pword)
{
uname = username;
pword = password;

dbinsert db = new dbinsert();
SqlDataReader dr = db.Datareader("select Password from registration where UserName='" + uname.ToString() + "'");
....

DO NOT DO THAT...

You will regret it if someone decides to do sql injections on you.

Imagine if someone put their username as

a' or 'a'='a

Stored procedures, or even just checking the username/password strings for sql injections will save you, but for the love of whomever you choose, dont use programmatic strings.