A question of style

[Barny]

Recently I noticed something that seems strange to me in .NET source that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

--
Barny

[Barny]

Hmm, rereading the post, it has some possible confusion:

I normally use if( o == null ) and the source has if( null == o )

--
Barny
"Barny" wrote:

Recently I noticed something that seems strange to me in .NET source that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

--
Barny

[Morten Wennevik]

On Fri, 27 Oct 2006 10:42:01 +0200, Barny
<Ba***@discussions.microsoft.comwrote:

Recently I noticed something that seems strange to me in .NET source
that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

I think you should stick with your instead of the 'source way' as you
compare an object with a value. Comparing a value against an object is
much harder to grasp mentally when scanning the code.

I don't think I have ever encountered the 'source way', but it isn't
really wrong, just unusual.

--
Happy Coding!
Morten Wennevik [C# MVP]

[Barny]

Thanks.

I have seen it used in a couple of other places and thought it was pants
there as well. For the purpose of consistancy, mods to this strange code
will have the brain yanked method used.

--
Barny
"Morten Wennevik" wrote:

On Fri, 27 Oct 2006 10:42:01 +0200, Barny
<Ba***@discussions.microsoft.comwrote:

Recently I noticed something that seems strange to me in .NET source
that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

I think you should stick with your instead of the 'source way' as you
compare an object with a value. Comparing a value against an object is
much harder to grasp mentally when scanning the code.

I don't think I have ever encountered the 'source way', but it isn't
really wrong, just unusual.

--
Happy Coding!
Morten Wennevik [C# MVP]

[David McDavison]

Mmmmmm have you tried Bulgarian notation? I had the same problems as you but
after trying the different notation method I wouldn't go back to using the
Hungarian method.

Cheers

"Barny" wrote:

Recently I noticed something that seems strange to me in .NET source that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

--
Barny

[David Anton]

Using a literal on the lhs of an equality test is something that is done in
C++ to avoid accidental assignmnet ("if (a = 0)" instead of equality testing
("if (a == 0)".
This is not an issue in C# since C# will not let you code "if (a = 0)", so
the more natural human readable "a 0" is what you'll find nearly everyone
else coding in C#.
--
David Anton
www.tangiblesoftwaresolutions.com
Instant C#: VB to C# converter
Instant VB: C# to VB converter
Instant C++: C#/VB to C++ converter
Instant Python: VB to Python converter
"Barny" wrote:

Recently I noticed something that seems strange to me in .NET source that I
wasn't originally involved in producing.

I was wondering if this was a preferred .NET style (or indeed general
style). I believe not as the code also uses Hungarian notation.

In summary I had always used, for example, something like:

if( a 0 )

wheras the source has

if( 0 < a )
or,

if( o == null )

as opposed to

if( null == o )
Comments please?

--
Barny