bash script of a simple calculator

[lifeisgreat20009]

Echo “Enter first number:”
Read n1
Echo “Enter Second number:”
Read n2
Echo “Enter operation to be carried out that is +, - , / or X”
Read opr
If [ opr==”+” ]
Then
echo $(( $a + $b ))
elif [ opr==”-“]
then
echo $(( $a - $b ))
elif [ opr==”/” ]
then
echo $(( $a / $b )) 
elif [ opr==”X” ]
then
echo $(( $a * $b ))
fi
 

Is the script above correct syntactically ?? its not working fine. I searched net for syntax errors but all seems to be correct. Plz tell me where modifications are needed in the code ?
thnx and regards

[Banfa]

You're entering n1 and n2 and then operating on a and b

[lifeisgreat20009]

otherwise is it ok ??
I made changes here only by mistake..
Its a and b only in the original script

[Banfa]

Sorry I'm not a bash expert it is just appeared to be an obvious mistake in any programming language.

[gpraghuram]

Hi,
There are some couple of errors in the code .
check this

echo "Enter first number:" 
read a 
echo "Enter Second number:" 
read b 
echo "Enter operation to be carried out that is +, - , / or X" 
read opr 
#echo "opr =$opr"
if [ $opr = "+" ] 
then 
    op=`expr $a + $b`
    echo "$op"
elif [ $opr = "-" ] 
then 
    op=`expr $a - $b`
    echo "$op"
elif [ $opr = "/" ] 
then 
    op=`expr $a / $b`
    echo "$op"
elif [ $opr = "X" ] 
then 
    op=`expr $a \* $b`
    echo "$op"
fi 

Raghu

[lifeisgreat20009]

thank you very much..its working now