Passing form id in FF 3.6 vs. FF 4.01

571

512MB

I think I need the reference to the form because I interact with other controls on the same line in the form. If time is added or subtracted that will affect what amount of time is permitted in the other selects and check boxes etc.

here is a snap shot of the other controls when only one line is displayed (the form can contain multiple lines)

Jun 16 '11 #2

571

512MB

I have now even tried to pass "this.form" and it still does not work with these lines.

Expand|Select|Wrap|Line Numbers

 
<select id ="HRS" name="HRS" onChange="NoPTOorOff(this,'line1','yes', this.form););">
 
function NoPTOorOff(obj, cLine, cTravel, oForm)

Here "oForm" is still null.

Jun 16 '11 #3

8,658

Expert Mod 8TB

what is the function NoPTOorOff() supposed to do?

Jun 16 '11 #4

571

512MB

This is a time sheet. the javascript functions keep track of various types of time earned by the employee. Check and balances are in place so excess time cannot be entered by the user.

Here is what the edit screen looks like.

this is the add screen

both the edit screen add screen use the same functions however, I call a sub function from "NoPTOorOff" called "adjustPersBal"

In the adjustPersBal() function, I look to see which screen made the call to the function (see below). Also as you can see, I have several other functions that use the same reference. I was hoping not to have to re-write everything right now as I am involved in a larger re-write of all my apps moving from one language to another (php). So the more I can keep the same for now the better, especially when it comes to the client side of the apps.

Expand|Select|Wrap|Line Numbers

 
function NoPTOorOff(obj, cLine, cTravel, oForm) 

{                               

/* var objV = obj.value;          

 var oForm = obj.form.id; 

 var timOff = document.forms[oForm].elements[cLine+"OFF"];

 var persnl = document.forms[oForm].elements[cLine+"PERS"];

 var regHrs = document.forms[oForm].elements[cLine+"HRS"];

 if (objV != "" && document.forms[oForm].elements[cLine+"OFF"] ) {              

   timOff.checked = false;

   //update current balance of personal time

   adjustPersBal(persnl, cLine, oForm)

   persnl.value   = "0";        

 }                                                                                

*/

 var objV = obj.value;          

 var timOff = document.getElementById(cLine+"OFF") ;

 var persnl = document.getElementById(cLine+"PERS");

 var regHrs = document.getElementById(cLine+"HRS");

 if (objV != "" && document.getElementById(cLine+"OFF")) {              

   timOff.checked = false;

   //update current balance of personal time

   adjustPersBal(persnl, cLine, oForm)

   persnl.value   = "0";        

 }                                                                                

}                                                                                        
 
function AdjustReg(obj, cLine, cDOW) 

{                               

 if (cDOW!="1" && cDOW!="7")

 {

     var oForm = obj.form.id; 

     var valRegHrs = parseFloat(document.forms[oForm].elements[cLine+"HRS"].value);

     var valPwHrs  = parseFloat(document.forms[oForm].elements[cLine+"PWREG"].value);

     var valPwHrs2 = parseFloat(document.forms[oForm].elements[cLine+"PWREG2"].value);

     var cTotHrs = valRegHrs+valPwHrs+valPwHrs2

     if (cTotHrs > 8) {             

       alert("The sum of the Regular Hours, Prevailing Wage and Prevailing Wage 2 hours exceed 8 hrs!"+'\n'+"Please adjust.")

        document.forms[oForm].elements[cLine+"HRS"].value = "0";

        document.forms[oForm].elements[cLine+"PWREG"].value ="0";

        document.forms[oForm].elements[cLine+"PWREG2"].value ="0";

     }                                                                                

 }
 
}                                                                                        
 
function showThisWeek( cPrev, cLocation)  

{                    

   location="/SMNO/addTimeOneWeek.exe?StartDate=" + cPrev + "&LOCATION=" + escape(cLocation) + "&EMPNO=yes";

}                                                                             

function adjustPersBal(obj, cLine, oForm)

{

   if (obj.value == "8" || obj.value == "8.00")

   {

    //calculate new Personal Time value based on change.

     if (oForm == "EditTimeForm" )

     {

        var xVal    = parseFloat(document.getElementById("PTOHOURS").value);

        var oVal     = xVal+8;

        //hidden balance field used to update balance in employee file found only in addTimeOneWeek

        document.getElementById("PTOHOURS").value = oVal.toString();

        document.getElementById("persHrBal").innerHTML = oVal.toString();

     }else{

        var xVal    = parseFloat(document.getElementById(cLine+"PERSBal").innerHTML);

        var oVal     = xVal+8;

        document.getElementById(cLine+"PERSBal").innerHTML = oVal.toString();

     }

     if (oForm == "AddTimeOneWeekForm")

     {

        var cCnt = cLine.substring(0,4)

        for (var i = 2; i < 7; i++ )

        {

            document.getElementById(cCnt+i+"PERSBal").innerHTML = oVal.toString();

        }

        //hidden balance field used to update balance in employee file found only in addTimeOneWeek

        document.getElementById("PTOHOURS").value = oVal.toString();

     }
 
   }

}

Jun 16 '11 #5

8,658

Expert Mod 8TB

first of all, the parameter oForms is wasted, you can access it via obj.form.

line #4 is also off, as forms are not called by ID, but by name or number (and we all know that IDs must not be numbers).

even then, if you have the form, why using document.form_name? i.e.

Expand|Select|Wrap|Line Numbers

var timOff = obj.form.elements[cLine+"OFF"];

personally I’d use an object that already stores the cLine and cTravel values. then you can easily move to an external JS file.

Jun 16 '11 #6

571

512MB

I added oForm as a parameter after my first post in an attempt to capture the name of the form when FF 4 would not return the id from "var oForm = obj.form.id;". As you can see I have left my original code in the /* */ section. I adjusted one "select" control to send that parameter also via "this.form", but that did not work either.

Please note that all my ids are alpahnumeric. I currently generate the line like this: "wkLineName = ltrim(str(wkLineCount))+'X'+c["EMPNODATE"].value"

This is dBase code, but should not look too unfamiliar to you. Note the first part of the string is number converted to a string and trimmed. That I then add a separator "X" and then tack on another string made up of the employee id and record date. That makes the content of that line and it's controls unique from all other records.

I just tried your suggestion "document.form_name" and that came back as undefined.

Also note I had this code running since 2004. So my coding may not have been as good at that time.

I might agree with your suggestion about the obj, but again I am trying to minimize the amount of re-write I have to do.

So I would really like to know how I can add a reference to the form to each of the select controls on the line (see my image in my second post). Prior to FF 4, I could pass the value simply by making a parameter "this". Since "this" is an object it carried the reference to the parent where I used it to extract it in the javascript function with this code "var oForm = obj.form.id;". This no longer works in FF 4

Thanks again for all your help. It is very much appreciated.

Jun 16 '11 #7

8,658

Expert Mod 8TB

as I already said, form access does not work with the ID. IDs are only useful in combination with document.getElementById().

hint: document.form_name = document["form_name"] = document.forms["form_name"], i.e. dot-notation can’t use variables

PS. personally I’ve given up on inline JS since I learned of EventTarget.addEventListener()

Jun 16 '11 #8

571

512MB

I totally agree with you about the inline js. And also thanks for the clarification on form_name point.

And when I get to this point in my re-write, I will make the necessary upgrades. At this time I was only looking for a small fix to keep the app running.

The main question I guess I have here is the app as it sits still works in FF 3.6.

<select name="regHRS" onChange="NoPTOorOff(this,'line1','Yes')">

passing a reference to the select object with the reserved word "this", In FF 3.6 I was able to reference all it's properties and attributes, including the id of the form on which the control was located.

function NoPTOorOff(obj, cLine, cTravel)
{
var oForm = obj.form.id;
}

Now in FF 4 that info is no longer provided. See the two screen shots below of exactly the same code.

FF 3.6

FF 4

Jun 21 '11 #9

8,658

Expert Mod 8TB

not sure what you mean. in both pictures (right side) you see that obj is a <select> element (despite the many property additions in FF4).

EDIT: looked up at HTML5 and found this:

A form-associated element can have a relationship with a form element, which is called the element's form owner. If a form-associated element is not associated with a form element, its form owner is said to be null.

from the looks of it, there is no form associated, but hard to tell without HTML code (usual question, do you have a demo page?)

Jun 21 '11 #10

571

512MB

Expand|Select|Wrap|Line Numbers

    puts([<BODY ])

   puts([ <FORM METHOD="POST" ])

   puts([         ENCTYPE="application/x-www-form-urlencoded"])

   puts([         NAME="EditTimeForm"])

   puts([         id  ="EditTimeForm">])

Fixed code

Expand|Select|Wrap|Line Numbers

    puts('<BODY>')

   puts(' <FORM METHOD="POST" ')

   puts('       ENCTYPE="application/x-www-form-urlencoded"')

   puts('        NAME="EditTimeForm"')

   puts('        id  ="EditTimeForm">')

Jun 21 '11 #11

8,658

Expert Mod 8TB

Sometimes I do wish I had a way to demo a page. But I am working on an intranet, so I have no means of displaying a working app.

File > save page as … > website - HTML only / website - complete

may not be a fully operable app, but good enough for HTML/JavaSctipt issues (without postback/AJAX)

Jun 21 '11 #12

by: Kevin Lyons | last post by:

Hello, I am trying to get all of my form elements passed correctly from the following URL: http://www.dslextreme.com/users/kevinlyons/selectBoxes.html to the following URL:...

Passing form variables

by: sindre | last post by:

Hi, I have a form with many fields. And then I thought I could have two other forms similar but here is only the submit button visible. What I want is: if the user click on a submit button on a...

passing form elements from page to page

by: Abby Lee | last post by:

My code works but because I'm using VBscript within JavaScript I get an error message...the yellow tri-angle with an "!" mark. ---------------within my body------------- <script...

passing form-objects to subroutine

by: SV | last post by:

Dear all, In my application I have a lot of hidden fields. I want to make them invisible for the users though for debugging reasons I want to make them visible. So I want to add these objects to...

Microsoft Access / VBA

Passing Form as parameter to non-form class

by: Ron Rohrssen | last post by:

I want to show a dialog and when the form (dialog) is closed, return to the calling form. The calling form should then be able to pass the child form to another object with the form as a...

C# / C Sharp

Passing form values from one page to other. Please, help me out. Thank You.

by: Miguel Dias Moura | last post by:

Hello, i created an ASP.net / VB page with a really big form. Now i want to create 4 pages and in each one i will place 1/4 of the big form. The last page will send all the form values by...

ASP.NET

passing form variables between pages - not another searchstring question :)

by: williamroy | last post by:

Hello, I've got a form that runs over 5 pages. I need the last page submit button to post all of the answers at one time from the previous 5 pages (to another server). I'd like to see the last...

Passing text between forms? How is this done?

by: patelxxx | last post by:

Problem: I am trying to input my name in a text box and I click on transfer and I want the name to appear on the same page (i.e. in another form). How is this done? <BODY> <HTML> <form...