By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
459,568 Members | 1,688 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 459,568 IT Pros & Developers. It's quick & easy.

rollover problem

P: n/a
Can someone please tell me what the heck is wrong with my code here on line
59 and 60. i get an error that says object expected and I have NO
understanding why. There must be something im overlooking and its really
irritating because i know how simple this should.
================================================== ==========================
======
<HTML>
<HEAD>
<TITLE>MENU</TITLE>
<SPRIPT LANGUAGE = "JavaScript">
<!--

if (document.images) {

img1on = new Image();
img1on.src = "buttons/button_2_up.gif";

img2on = new Image();
img2on.src = "buttons/button_4_up.gif";

img3on = new Image();
img3on.src = "buttons/button_6_up.gif";

img4on = new Image();
img4on.src = "buttons/button_8_up.gif";
img1off = new Image();
img1off.src = "buttons/button_2_down.gif";

img2off = new Image();
img2off.src = "buttons/button_4_down.gif";

img3off = new Image();
img3off.src = "buttons/button_6_down.gif";

img4off = new Image();
img4off.src = "buttons/button_8_down.gif";
}

function imgOn(imgName) {
if (document.images) {
document[imgName].src = eval(imgName + "on.src");
}
}

function imgOff(imgName) {
if (document.images) {
document[imgName].src = eval(imgName + "off.src");
}
}
//-->

</SCRIPT>

</HEAD>
<BODY>

<TABLE BORDER="0" CELLPADDING="0" CELLSPACING="0" WIDTH="135">

<TR><IMG SRC="buttons\logo.gif" width="135" heigth="117" border="0"></TR>
<TR><IMG SRC="buttons\menu.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_1_down.gif" border="0"></TR>

<TR><A href = "products.html" target="main"
onMouseOver = "imgOn('img1')" // this is the
line with the error!!!
onMouseOut = "imgOff('img1')"> // this one
too
<IMG NAME = "img1" border=0 height=27 width=128
src="buttons\button_2_down.gif"></A></TR>

<TR><IMG SRC="buttons\button_3_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_4_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_5_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_6_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_7_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_8_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_9_down.gif" border="0"></TR>
<TR><IMG SRC="buttons\button_10_down.gif" border="0"></TR>
</BODY>
</TABLE>
</HTML>
Jul 20 '05 #1
Share this Question
Share on Google+
1 Reply


P: n/a
"Paul Weikel" <we*****@earthlink.net> writes:
Can someone please tell me what the heck is wrong with my code here on line
59 and 60. i get an error that says object expected and I have NO
understanding why. There must be something im overlooking and its really
irritating because i know how simple this should.
I'll just give it the full treatment :)

Remember a DOCTYPE to set the browser into standards mode. <HTML>
<HEAD>
<TITLE>MENU</TITLE>
<SPRIPT LANGUAGE = "JavaScript"> ^
This P shoud be a C.
Also, the language attribute is depreacted and the type attribute is
required. Change this to
<script type="text/javascript">
<!--
HTML comments are not necessary in Javascript code.
if (document.images) {
Which currently used browsers don't have document.images?
Why do you test for it, if you don't use it? (even though you should
use it!)
function imgOn(imgName) {
if (document.images) {
document[imgName].src = eval(imgName + "on.src");
Bad code. It assumes the image is available as a property of the
document element. If you test for document.images, you might as well
use it.

You use eval to access a variable/object property. That is never
necessary, and should be avoided.

Change to:
document.images[imgName].src = window[imgName+"on"].src;

(Instead of a lot of global variables, you could have made just
one pointing to an object, and then stored the Image elements in it.
document[imgName].src = eval(imgName + "off.src");
As above.
//--> As for opening comments.
<TABLE BORDER="0" CELLPADDING="0" CELLSPACING="0" WIDTH="135">
Consider using CSS for controlling display. It is more powerful
than HTML attributes.
<TR><A href = "products.html" target="main"
onMouseOver = "imgOn('img1')" // this is the
line with the error!!!
onMouseOut = "imgOff('img1')"> // this one
too


Both errors probablt come from the "spript" tag. The functions are
simply not defined.

To find errors like this, you can use an HTML validator like
<URL:http://validator.w3.org/>. (It requires adding a DOCTYPE
declaration, but you should do that anyway).

/L
--
Lasse Reichstein Nielsen - lr*@hotpop.com
Art D'HTML: <URL:http://www.infimum.dk/HTML/randomArtSplit.html>
'Faith without judgement merely degrades the spirit divine.'
Jul 20 '05 #2

This discussion thread is closed

Replies have been disabled for this discussion.