canceling the submition of a form

[greg brant]

i have a form made up of 2 file inputs and a submit button..
the imputs are to upload images, namley jpeg's for a e-greatings thing im
working on.
this only works with jpegs so i have a script that will check the value of
the imput tag to make sure it ends with .jpg, .jpeg.

this works fine on the jubmit button using

onclick="myHandler(this)"

it works fane that it alerts the user that only jpegs are valid but then
when the alert
has been ok'd it continues to submit the form to my php script.

how can i get this to cancle the submit action?

cheers

Greg Brant

[Lee]

"greg said:

i have a form made up of 2 file inputs and a submit button..
the imputs are to upload images, namley jpeg's for a e-greatings thing im
working on.
this only works with jpegs so i have a script that will check the value of
the imput tag to make sure it ends with .jpg, .jpeg.

this works fine on the jubmit button using

onclick="myHandler(this)"

it works fane that it alerts the user that only jpegs are valid but then
when the alert
has been ok'd it continues to submit the form to my php script.

how can i get this to cancle the submit action?

Don't user the onclick handler of the submit button.
That's not even supported in all browsers.
Use the onSubmit handler of the form, itself, and have
it return true, if the form is to be submitted, and
false if not:

<form action="whatever" onsubmit="return myHandler(this)">

[greg brant]

hi,

thanks for the reply.. i tried this once but there was somthing i could not
understand

i was returning true or false but whatever i had it was still going to the
action="" URL

im using ie6 on win xp

cheers
"Lee" <RE**************@cox.net> wrote in message
news:bg********@drn.newsguy.com...

"greg said:

i have a form made up of 2 file inputs and a submit button..
the imputs are to upload images, namley jpeg's for a e-greatings thing im
working on.
this only works with jpegs so i have a script that will check the value ofthe imput tag to make sure it ends with .jpg, .jpeg.

this works fine on the jubmit button using

onclick="myHandler(this)"

it works fane that it alerts the user that only jpegs are valid but then
when the alert
has been ok'd it continues to submit the form to my php script.

how can i get this to cancle the submit action?

Don't user the onclick handler of the submit button.
That's not even supported in all browsers.
Use the onSubmit handler of the form, itself, and have
it return true, if the form is to be submitted, and
false if not:

<form action="whatever" onsubmit="return myHandler(this)">

[greg brant]

so heres my script

function checkExt(file1, file2) {
alert("hello");
files = Array(file1, file2);

if (files[0] == "" && files[1] == ""){
alert("Please select a file or browse our gallery");
return false;
}else{
return true;
}
}

and on the form tag i have

<form action="designer2.php?upload=1" method="post"
enctype="multipart/form-data" name="uploadForm" target="_top"
id="uploadForm" onSubmit="return checkExt(this.userFile1.value,
this.userFile2.value)">

and i dont even get the
alert("hello");

it just submits

cheers

"Lee" <RE**************@cox.net> wrote in message
news:bg********@drn.newsguy.com...

"greg said:

i have a form made up of 2 file inputs and a submit button..
the imputs are to upload images, namley jpeg's for a e-greatings thing im
working on.
this only works with jpegs so i have a script that will check the value ofthe imput tag to make sure it ends with .jpg, .jpeg.

this works fine on the jubmit button using

onclick="myHandler(this)"

it works fane that it alerts the user that only jpegs are valid but then
when the alert
has been ok'd it continues to submit the form to my php script.

how can i get this to cancle the submit action?

Don't user the onclick handler of the submit button.
That's not even supported in all browsers.
Use the onSubmit handler of the form, itself, and have
it return true, if the form is to be submitted, and
false if not:

<form action="whatever" onsubmit="return myHandler(this)">

[Grant Wagner]

Then you are most likely generating a JavaScript error somewhere along the way.
Change the onsubmit button to be:

onsubmit="return (false && checkExt(this.userFile1.value,
this.userFile2.value));"

then check the lower-left corner of IE for a yellow !, or type "javascript:" (no
quotes) into the Address bar of Mozilla/Netscape 7. If there are any errors,
they will be reported.

greg brant wrote:

so heres my script

function checkExt(file1, file2) {
alert("hello");
files = Array(file1, file2);
Why do you put both files into an array and then access the individual
elements?
if (files[0] == "" && files[1] == ""){
if (file1 == "" && file2 == "") {
alert("Please select a file or browse our gallery");
return false;
}else{
return true;
}
}

and on the form tag i have

<form action="designer2.php?upload=1" method="post"
enctype="multipart/form-data" name="uploadForm" target="_top"
id="uploadForm" onSubmit="return checkExt(this.userFile1.value,
this.userFile2.value)">

and i dont even get the
alert("hello");

it just submits

cheers

"Lee" <RE**************@cox.net> wrote in message
news:bg********@drn.newsguy.com...

"greg said:

i have a form made up of 2 file inputs and a submit button..
the imputs are to upload images, namley jpeg's for a e-greatings thing im
working on.
this only works with jpegs so i have a script that will check the value ofthe imput tag to make sure it ends with .jpg, .jpeg.

this works fine on the jubmit button using

onclick="myHandler(this)"

it works fane that it alerts the user that only jpegs are valid but then
when the alert
has been ok'd it continues to submit the form to my php script.

how can i get this to cancle the submit action?

Don't user the onclick handler of the submit button.
That's not even supported in all browsers.
Use the onSubmit handler of the form, itself, and have
it return true, if the form is to be submitted, and
false if not:

<form action="whatever" onsubmit="return myHandler(this)">

--
| Grant Wagner <gw*****@agricoreunited.com>

* Client-side Javascript and Netscape 4 DOM Reference available at:
*
http://devedge.netscape.com/library/...ce/frames.html

* Internet Explorer DOM Reference available at:
*
http://msdn.microsoft.com/workshop/a...ence_entry.asp

* Netscape 6/7 DOM Reference available at:
* http://www.mozilla.org/docs/dom/domref/
* Tips for upgrading JavaScript for Netscape 6/7 and Mozilla
* http://www.mozilla.org/docs/web-deve...upgrade_2.html

[Lasse Reichstein Nielsen]

Grant Wagner <gw*****@agricoreunited.com> writes:

Change the onsubmit button to be:

onsubmit="return (false && checkExt(this.userFile1.value,
this.userFile2.value));"

The would be equivalent to
onsubmit='return false;"
In Javascript, the "&&" operator is "short-circuit". If the first operand
is false, then the second isn't evaluated, since we already know that the
result must be false.

Try
onsubmit="return (false && alert('this is not happening'));"
and see (not) that it is indeed no happening.

/L
--
Lasse Reichstein Nielsen - lr*@hotpop.com
Art D'HTML: <URL:http://www.infimum.dk/HTML/randomArtSplit.html>
'Faith without judgement merely degrades the spirit divine.'

[Grant Wagner]

Lasse Reichstein Nielsen wrote:

Grant Wagner <gw*****@agricoreunited.com> writes:

Change the onsubmit button to be:

onsubmit="return (false && checkExt(this.userFile1.value,
this.userFile2.value));"

The would be equivalent to
onsubmit='return false;"
In Javascript, the "&&" operator is "short-circuit". If the first operand
is false, then the second isn't evaluated, since we already know that the
result must be false.

Try
onsubmit="return (false && alert('this is not happening'));"
and see (not) that it is indeed no happening.

/L

You're right of course, it should have been:

onsubmit="return (checkExt(this.userFile1.value, this.userFile2.value) &&
false);"

Since he isn't sure the function is even being called, it necessary to halt
the onsubmit event unconditionally so he can see the error(s), if any.

onsubmit="checkExt(...); return false;" would work just as well.

--
| Grant Wagner <gw*****@agricoreunited.com>

* Client-side Javascript and Netscape 4 DOM Reference available at:
*
http://devedge.netscape.com/library/...ce/frames.html

* Internet Explorer DOM Reference available at:
*
http://msdn.microsoft.com/workshop/a...ence_entry.asp

* Netscape 6/7 DOM Reference available at:
* http://www.mozilla.org/docs/dom/domref/
* Tips for upgrading JavaScript for Netscape 6/7 and Mozilla
* http://www.mozilla.org/docs/web-deve...upgrade_2.html

[greg brant]

thanks guys
"Grant Wagner" <gw*****@agricoreunited.com> wrote in message
news:3F***************@agricoreunited.com...

Lasse Reichstein Nielsen wrote:

Grant Wagner <gw*****@agricoreunited.com> writes:

Change the onsubmit button to be:

onsubmit="return (false && checkExt(this.userFile1.value,
this.userFile2.value));"
The would be equivalent to
onsubmit='return false;"
In Javascript, the "&&" operator is "short-circuit". If the first operand is false, then the second isn't evaluated, since we already know that the result must be false.

Try
onsubmit="return (false && alert('this is not happening'));"
and see (not) that it is indeed no happening.

/L

You're right of course, it should have been:

onsubmit="return (checkExt(this.userFile1.value, this.userFile2.value) &&
false);"

Since he isn't sure the function is even being called, it necessary to

halt the onsubmit event unconditionally so he can see the error(s), if any.

onsubmit="checkExt(...); return false;" would work just as well.

--
| Grant Wagner <gw*****@agricoreunited.com>

* Client-side Javascript and Netscape 4 DOM Reference available at:
*
http://devedge.netscape.com/library/...ce/frames.html
* Internet Explorer DOM Reference available at:
*
http://msdn.microsoft.com/workshop/a...ence_entry.asp
* Netscape 6/7 DOM Reference available at:
* http://www.mozilla.org/docs/dom/domref/
* Tips for upgrading JavaScript for Netscape 6/7 and Mozilla
* http://www.mozilla.org/docs/web-deve...upgrade_2.html