How to add 19 more states to ip block.

[starlight2200]

I'm using a web statistic service and I want to only allow certain states to my site as a testing mode for a certain period of time and block all non US countries.

I received the correct javascript below, but I can't figure out how to add the addtional states to the else statement. I tried everything. I don't know javascript. I need to add 19 more states to the else statement correctly. Can you give me the correct sequence to follow by adding 4 or five states as sampe to the else statement and letting me know how to end the statement correctly? The script below does work.

<script language="JavaScript">
var geo = disp();
if (geo[0] != 'US'){
   alert('Sorry this site is only accessible from the USA');
 
   window.location = ('http://www.yahoo.com'); 
}
else {
   if (geo[2] != 'CA' && geo[2] != 'TX' ){ (NEED TO ADD STATES HERE)
      alert('Sorry this site is only accessible from California and Texas');
 
      window.location = ('http://www.yahoo.com'); 
   }
}
</script>

[Dormilich]

I recommend a switch statement

switch (geo[2])
{
    case: "CA":
    case: "TX":
    case: "WA":
    // …
    case: "TN":
        // execute "valid" code
        break;
    default:
        alert(…);
        location.href = "…";
}

[starlight2200]

That was fast thanks.

[Dormilich]

you get 5 extra dice if you’re a moderator ;)

[gits]

another idea to shorten the code a bit would be to use a 'hash-map' like this:

var statesMap = { 'CA': 1, 'TX': 1, 'WA': 1, ... };
 
if ( geo[2] in statesMap) {
    // valid handling
} else {
    // invalid handling
}
 

kind regards

[Dormilich]

and just another one using arrays:

var statesMap = ["WA", "TX", "CA", …];
if (-1 == statesMap.indexOf(geo[2]))
{
    // invalid handling
}
else
{
    // valid handling
}

even searching in a string were possible …

you see, there are many ways to do this

[Plater]

Note: Poopy IE6 doesn't have the .indexOf() operator on its arrays.