A question regarding swfobject

[mikek12004]

Trying to build a flash rotator which takes some swf from a db and rotates them.
In the head I have

<script type="text/javascript">
        clock_ads(1);
        function clock_ads(i)
        {
            <?php
            $q1=mysql_query("select * from banners");
            $c1=mysql_num_rows($q1);
            if ($c1>0) //got banners and ok to show
            {
                $maxy=0;
                //check if only one entry
                for ($j=1;$j<=$c1;$j++)
                {
                    $q2=mysql_query("select * from banners where banorder='$j'");
                    $r2=mysql_fetch_array($q2);
                    $file="banners/".$r2[1];
                    $size=getimagesize($file);
                    if ($size[1]>$maxy) $maxy=$size[1];
                    $life=$r2[3];
                    if ($j==1) echo "if"; else echo "else if";
                    ?>
                    (i=='<?php echo $j;?>')
                    {
                        //check to see how we will display the ad based on the type (flash or image) 
 
                        if ( ("<?php echo $r2[1];?>".search(/.swf/i))>0 )
                        {
 
                            swfobject.embedSWF("<?php echo $file;?>", "myContent", "<?php echo $size[0];?>", "<?php echo $size[1];?>", "9.0.0");
 
                        }
                        else
                        {
 
                            document.getElementById("myContent").innerHTML="<img border='0' src='<?php echo $file;?>' />";
 
                        }
                        if (<?php echo $c1?>!='1')
                            setTimeout("clock_ads(<?php echo $j+1;?>)",<?php echo $life;?>);    
                    }
                    <?php    
                }
            }//if ($c1>0) //got banners and ok to show
            ?>
            if (i><?php echo $c1;?>) clock_ads(1);
        }
        </script>    
 

and in the body a

<div id="myContent">
                                                            <h2><?php echo GET_FLASH;?></h2>
                                                            <p><a href="http://www.adobe.com/go/getflashplayer"><img src="http://www.adobe.com/images/shared/download_buttons/get_flash_player.gif" alt="Get Adobe Flash player" /></a></p>
                                                            </div> 
 

when I have only swf it works ok but when I also use images I get an error that
mycontent is null meaning that it cannot find the div, as I see it the

document.getElementById("myContent").innerHTML="<img border='0' src='<?php echo $file;?>' />";
 

is for some reason relating to the swf wrong logic any help?

PS Even when I moved the script below the div in the body the image was shown once and only when it was shown before a swf after that it was simply ignored and the page showed only the swfs

[mikek12004]

a bit of further explanation about the code, all it does is to generate a javascript to do the job e.g. an image ELNAVI.jpg and after that 2 swf we have this

<script type="text/javascript">
        clock_ads(1);
        function clock_ads(i)
        {
            if    (i=='1')
            {
                //check to see how we will display the ad based on the type (flash or image)     
                if ( ("ELNAVI.jpg".search(/.swf/i))>0 )
                {
                    swfobject.embedSWF("banners/ELNAVI.jpg", "myContent", "160", "37", "9.0.0");
                }
                else
                {
                    document.getElementById("myContent").innerHTML="<img border='0' src='banners/ELNAVI.jpg' />'";
                }
                if (3!='1')
                    setTimeout("clock_ads(2)",8000);    
            }
            else if    (i=='2')
            {
            //check to see how we will display the ad based on the type (flash or image) 
                if ( ("gmlogoA.swf".search(/.swf/i))>0 )
                {
                    swfobject.embedSWF("banners/gmlogoA.swf", "myContent", "779", "136", "9.0.0");
                }
                else
                 {
                    document.getElementById("myContent").innerHTML="<img border='0' src='banners/gmlogoA.swf' />'";
                }
                if (3!='1')
                    setTimeout("clock_ads(3)",5000);    
                }
                else if    (i=='3')
                {
                    //check to see how we will display the ad based on the type (flash or image) 
                    if ( ("alba468x60msc150609.swf".search(/.swf/i))>0 )
                    {
                        swfobject.embedSWF("banners/alba468x60msc150609.swf", "myContent", "468", "60", "9.0.0");
                    }
                    else
                    {    
                        document.getElementById("myContent").innerHTML="<img border='0' src='banners/alba468x60msc150609.swf' />'";    
                    }
                    if (3!='1')
                        setTimeout("clock_ads(4)",5000);    
                }
                if (i>3) clock_ads(1);
            }
</script>  

[acoder]

See line 14:

document.getElementById("myContent").innerHTML="<img border='0' src='banners/ELNAVI.jpg' />'"

You have an extraneous ' (single quote).