opening new window on click of button

[phpnewbie26]

I don't have much background with javascript and my page currently is mainly using php. I am now trying to create a button that will open a new window and I believe I have to use javascript for that. I've looked online for help and it seems that I should be using window.open function but I keep on getting errors. Here is what I have so far.

echo '<form>';
echo '<p><input type="button" value="Click Here" onClick="window.open('http://intra.array.ca/admin/ts2/tsreport.php','','width=900,height=600')"/></p>';
echo '</form>';
 

when I tried adding in the language=javascript thing it tells me I have an error with a "<" and my current coding, it tells me I have an error with a ";
or ",". Any help is appreciated. Thanks in advance.

[phpnewbie26]

okay. I seemed to have figured it out without the use of window.open=)

[acoder]

So, what did you use instead?

The problem with the code posted is that you've not escaped the single quotes.

[phpnewbie26]

i just used

echo '<form action="http://blah.php" target="_blank">
<input type=submit value="click here">
</form>';
 

and where was I supposed to escape the single quotes..i must be blind..lol

[acoder]

Since you use single quotes for the echo, you need to escape all single quotes within the string:

echo '<p><input type="button" value="Click Here" onclick="window.open(\'http://intra.array.ca/admin/ts2/tsreport.php\',\'\',\'width=900,height=600\')"/></p>';

Your code will also work, but you have more control with window.open(). To avoid the quotes problem, keep the JavaScript code out of HTML, or come out of PHP when you output HTML.