JS is working in firefox but not working in IE

[black143]

Hi All,

i am using this below addElement() function to create the file element dynamically

function addElement( filename,businessName ){
 
// Make sure it's a file input element
//if( element.tagName == 'INPUT' && element.type == 'file' )
{
var textdiv = document.createTextNode('SER file to upload:'); 
var new_element = document.createElement( 'input' );
var divdetails =document.createElement('div');
divdetails.id='files_div'+filecount
 
new_element.type = 'file';
new_element.id='my_file_element'+filecount;
 
 new_element.setAttribute('name','testFile[' +  filecount  +  ']'); 
 
var treval = 'document.getElementById("files_div'+filecount+'").style.display="block"'; 
var treval1 = 'document.getElementById("files_div'+filecount+'").style.position="absolute"'; 
var treval2 = 'document.getElementById("files_div'+filecount+'").style.top="78px"'; 
 
filecount++
var tableid = document.getElementById('tableid');
 
divdetails.appendChild(textdiv); 
 
divdetails.appendChild(new_element);
tableid.appendChild(divdetails);
//document.upload.appendChild(divdetails);
document.upload.appendChild(new_hiddenelement);
//document.getElementById("tempFiles").style.display="none";
if(document.getElementById("files_div0") !=null)
{
document.getElementById("files_div0").style.visibility="hidden";
}
eval(treval);
eval(treval1);
eval(treval2);
 
};
 

and using this below codei am retriving the value of dyamically created file

value_of_file = 'document.upload.elements["testFile[' +  count_list1 +  ']"].value'                
value_of_file = eval(value_of_file);
 

above code is working perfectly in teh firefox but in IE it was showing null value exception


please help to solve this problem..


thanks in advance....


Riaz

[acoder]

Unfortunately, IE doesn't set the names of elements with setAttribute() or .name syntax when created dynamically. It needs its own non-standard syntax in createElement(). You may find this link useful for a cross-browser solution.

[iam_clint]

var pinput = document.createElement("INPUT");
pinput.setAttribute("id", "partnum");
pinput.setAttribute("name", "partnum");
pinput.id="partnum";
pinput.name="partnum";
 

This is some code I use for setting the names of created Elements without the IE hack... this seems to work in all browsers i've tested on.. ie6, ie7, firefox, google chrome.. It doesn't seem to work if the id attribute is not there.. If i remember correctly it doesn't seem to work if the id attribute isn't there first.

Now here comes the part that gets people confused and think that .name doesn't work.. IE only gets elements by name if they are native form elements... input, select, textarea so on

So I use this

function getAllElementsByName(name) {
    var Elements=document.getElementsByTagName("*");
    var Return_Array=Array();
    var r=0;
    for (var i=0; i<Elements.length; i++) {
        if (Elements[i].getAttribute("name")==name) {
            Return_Array[r]=Elements[i];
            r++;
        }
    }
    return Return_Array;
}
 

[zaphod42]

correct me if I'm wrong clint, but IE doesn't allow setting the name attribute for grouped input items (like radio and check boxes) after creation, (or dynamically in 6 period) I've had to use the very irritating

document.createElement("<input type="+args.type+" name="args.name">")

method...

As far as I know, if you dynamically create form elements, there are some wierd caveats that ie refuses to make easier.

also why:

  var r=0;
  for (var i=0; i<Elements.length; i++) {
     if (Elements[i].getAttribute("name")==name) {
        Return_Array[r]=Elements[i];
        r++;
  }

in that scenario don't 'i' and 'r' equal the same value?

[iam_clint]

r won't always be the same because i is incrementing with no if statements
r only increments when Elements[i].getAttribute("name")==name

  var r=0; 
  for (var i=0; i<Elements.length; i++) { 
     if (Elements[i].getAttribute("name")==name) { 
        Return_Array[r]=Elements[i]; 
        r++; 
     }
  } 
 

as to the other question i'm not sure off the top of my head I would have to run some tests.

[zaphod42]

sorry, should have read the code more thoroughly:p