I don't get it: -
var img_buttnz = document.getElementsByTagName('IMG');
-
for (var z = 0; z<img_buttnz.length; z++) {
-
alert(img_buttnz[z].id);
-
if(img_buttnz[z].id) {
-
addEvent(img_buttnz[z], 'click', function() { k.changeFile(this); });
-
}
-
}
-
That works. -
var img_buttnz = document.getElementsByTagName('IMG');
-
for (var z = 0; z<img_buttnz.length; z++) {
-
if(img_buttnz[z].id) {
-
addEvent(img_buttnz[z], 'click', function() { k.changeFile(this); });
-
}
-
}
-
That doesn't.
Can anyone tell me why I have to alert() the Objects in order to work with them?
20  1532 
This little test code I slapped together worked fine with and without the alert -
<html>
-
<body>
-
<script>
-
function test() {
-
var img_buttnz = document.getElementsByTagName('IMG');
-
for (var z = 0; z<img_buttnz.length; z++) {
-
if (img_buttnz[z].id!="") {
-
img_buttnz[z].onclick=function() { alert(this.id); }
-
}
-
}
-
}
-
window.onload=function() { test(); }
-
</script>
-
<img src="" id="whateva1" name="whateva"><img src="" id="whateva2" name="whateva"><img src="" id="whateva3" name="whateva"><img src="" id="whateva4" name="whateva"><img src="" id="whateva5" name="whateva"><img src="" id="whateva6" name="whateva">
-
</body>
-
</html>
-
This little test code I slapped together worked fine with and without the alert. . .
Thanks again, Clint. I don't get what's going on with this one. Any ideas what *might* be causing a problem? The code is about as basic as it gets, yet it doesn't want to work.
It may also help to note that this seems to be an issue for FF and not for IE.
gits 5,390
Expert Mod 4TB
are you waiting for the page to be loaded completely (have a look at the onload-trigger in iam_clint's code) so that you may use the dom-methods reliably?
show your addEvent()-function ... and may be you could tell what the problem is? what did you expect and what do you get?
kind regards
are you waiting for the page to be loaded completely (have a look at the onload-trigger in iam_clint's code) so that you may use the dom-methods reliably?
show your addEvent()-function ... and may be you could tell what the problem is? what did you expect and what do you get?
kind regards
The addEvent function: -
function addEvent(elm, evType, fn, useCapture) {
-
elm["on"+evType]=fn;return;
-
}
The code originally posted is added to the page with the same addEvent function, loading on window load. What I expected was to add a function to the images which would happen onClick, but what I got was nothing at all.
I've also added an alert() inside the conditional to see if it would tell me something happened, and it did nothing.
gits 5,390
Expert Mod 4TB
so i assume you want to do something like the following:
[HTML]<html>
<body>
<script>
function test() {
var img_buttnz = document.getElementsByTagName('IMG');
for (var z = 0; z < img_buttnz.length; z++) {
if (img_buttnz[z].id != "") {
var f = function(el) {
addEvent(el, 'click', function() { alert(this.id); }) ;
}(img_buttnz[z]);
}
}
}
function addEvent(elm, evType, fn, useCapture) {
elm["on"+evType]=fn;
return;
}
addEvent(window, 'load', function() { test(); });
</script>
<img src="" id="whateva1" name="whateva">
<img src="" id="whateva2" name="whateva">
<img src="" id="whateva3" name="whateva">
<img src="" id="whateva4" name="whateva">
<img src="" id="whateva5" name="whateva">
<img src="" id="whateva6" name="whateva">
</body>
</html>
[/HTML]
as you see you should use a closure when adding the events in a loop.
kind regards
so i assume you want to do something like the following:
[HTML]
for (var z = 0; z < img_buttnz.length; z++) {
if (img_buttnz[z].id != "") {
var f = function(el) {
addEvent(el, 'click', function() { alert(this.id); });
}(img_buttnz[z]);
}
}
[/HTML]
as you see you should use a closure when adding the events in a loop.
kind regards
I'm not sure I understand what that "(img_buttnz[z]);" text is doing there after the closed curly brace?
gits 5,390
Expert Mod 4TB
have a close look at it ... it defines a function that is instantly called with the current img-ele in your list as param el :)
have a close look at it ... it defines a function that is instantly called with the current img-ele in your list as param el :)
Perhaps we've gone off on a tangent. I take your point about using the enclosure (and I've never seen a closure created in that way, so it's definitely a function to study and absorb, thank you!). But I'm left with the same problem: it works fine in IE but not in FireFox. By adding in the alert() message, it suddenly works in both versions. THIS is primarily what brought me to your awesome forums today. Do you have any idea why this would be a problem for FF?
I noticed that my code was taking other images on the page into consideration. Since I don't want that, I've modified the code slightly and it's written below. -
var panels = document.getElementsByClassName('panel');
-
for(var z = 0; z < panels.length; z++) {
-
// alert(panels[z].id);
-
var buttnz = panels[z].getElementsByTagName('IMG');
-
for(var q = 0; q < buttnz.length; q++) {
-
var f = function(el) {
-
addEvent(el, 'click', function() { k.changeFile(this); }) ;
-
}(buttnz[q]);
-
}
-
}
-
gits 5,390
Expert Mod 4TB
?? ... i tested it with FF ... it should work. do you get an alert when using: - addEvent(el, 'click', function() { alert('foo'); }) ;
for the above line 7.?
?? ... i tested it with FF ... it should work. do you get an alert when using:
- addEvent(el, 'click', function() { alert('foo'); }) ;
for the above line 7.?
Same thing. And I know that it should work. The trouble is that it doesn't work. I'm trying to figure out why that would be. Any guesses? Should I post the entire function to see how it goes together? That's looking like it might be necessary.
I'll have to post the entire function tomorrow when I'm back at work.
gits 5,390
Expert Mod 4TB
may be that would be a good idea ... lets have a look at this then.
kind regards
may be that would be a good idea ... lets have a look at this then.
kind regards
OK, gits. Here goes. Thanks again for all the help: -
function launchKiosk() {
-
k.getImages();
-
var demo_container = document.getElementById('demo_container');
-
var divs = demo_container.childNodes;
-
for (var x = 0; x<divs.length; x++) {
-
if(divs[x].tagName == 'DIV') {
-
if (divs[x].getAttribute('id') == 'designs_button') {
-
k.designs_button = divs[x];
-
k.designs_panel = document.getElementById('designs');
-
}
-
if (divs[x].getAttribute('id') =='styles_button') {
-
k.styles_button = divs[x];
-
k.styles_panel = document.getElementById('styles');
-
}
-
}
-
}
-
if(k.designs_button && k.designs_button) {
-
addEvent(k.designs_button, 'click', function() {k.changeTab(k.designs_button)});
-
addEvent(k.styles_button, 'click', function() {k.changeTab(k.styles_button)});
-
}
-
var panels = document.getElementsByClassName('panel');
-
for(var z = 0; z < panels.length; z++) {
-
// alert(panels[z].id);
-
var buttnz = panels[z].getElementsByTagName('IMG');
-
for(var q = 0; q < buttnz.length; q++) {
-
var f = function(el) {
-
addEvent(el, 'click', function() { k.changeFile(this); }) ;
-
}(buttnz[q]);
-
}
-
}
-
}
gits 5,390
Expert Mod 4TB
just to ensure it first - you have a correct working getElementsByClassName()-method implemented for FF and/or since this method is just natively supported with FF 3 - you test with this version?
gits 5,390
Expert Mod 4TB
the following example works as expected in FF3:
[HTML]<html>
<body>
<script>
function test() {
var panel = document.getElementsByClassName('panel')[0];
var img_buttnz = panel.getElementsByTagName('IMG');
for (var z = 0; z<img_buttnz.length; z++) {
if (img_buttnz[z].id!="") {
var f = function(el) {
addEvent(el, 'click', function() { alert(el.id); })
}(img_buttnz[z]);
}
}
}
function addEvent(elm, evType, fn, useCapture) {
elm["on"+evType]=fn;
return;
}
addEvent(window, 'load', function() { test(); });
</script>
<div class="panel">
<img src="" id="whateva1" name="whateva">
<img src="" id="whateva2" name="whateva">
<img src="" id="whateva3" name="whateva">
<img src="" id="whateva4" name="whateva">
<img src="" id="whateva5" name="whateva">
<img src="" id="whateva6" name="whateva">
</div>
</body>
</html>
[/HTML]
does FF show any errors in the JavaScript-Console for your page?
Here is the getElementsByClassName function: -
// getElementsByClassName
-
document.getElementsByClassName = function(clsName){
-
var retVal = new Array();
-
var elements = document.getElementsByTagName("*");
-
for(var i = 0;i < elements.length;i++){
-
if(elements[i].className.indexOf(" ") >= 0){
-
var classes = elements[i].className.split(" ");
-
for(var j = 0;j < classes.length;j++){
-
if(classes[j] == clsName)
-
retVal.push(elements[i]);
-
}
-
}
-
else if(elements[i].className == clsName)
-
retVal.push(elements[i]);
-
}
-
return retVal;
-
}
Thanks again. But let me ask you: forgetting the actual code for the moment, what changes about an object when it's alert()'ed that might make the situation different after having done so? Maybe this is the question we need to answer to get the problem solved?
Wait, wait, wait. . .
Maybe the problem is that I'm using a getElementsByClassName function that was created outside of Mozilla's support? Could it be that if I change the function name, it might work? Hmm. . .
Wait, wait, wait. . .
Maybe the problem is that I'm using a getElementsByClassName function that was created outside of Mozilla's support? Could it be that if I change the function name, it might work? Hmm. . .
The answer seems to be a big, fat "no." Which makes sense, since it really has nothing to do with the getElementsByClassName function. Dangit.
gits 5,390
Expert Mod 4TB
nope ... i just asked because sometimes people use a getElementsByClassName() method thinking it is a standard-dom method and wonder why it just don't work without having one implemented. i tried your version with FF and the above example and even with your implementation it worked.
basicly an alert() just stops the execution of the code until the ok is clicked - so it is a modal message ... having code that works with an alert typically has a timing problem ... but i cannot see such problem here. currently i have to admit to be out of ideas ... i have to have a closer look at the problem. i wonder whether there is something that is besides the current code we just had a look at that could cause a problem ... since the example i gave you just use the same methods as you use in your code ... and it just works.
kind regards
nope ...
Well, Gits, you've done a whole lot more than most would have, so I appreciate the effort.
One last thing, since you mention timing: the images I'm gathering up are actually being dynamically rendered from XML in the following line:
Is it possible that the problem is that the code is happening before the XmlHttpRequest has gone through? If so, what do I do to arrest code execution until that's done?
gits 5,390
Expert Mod 4TB
that could be truely the reason ... you could start the addEvent()-loop in the ready-callback of your AJAX-request after the nodes are full rendered into the DOM ... that should solve this issue ...
kind regards
Sign in to post your reply or Sign up for a free account.
Similar topics
by: Justin Koivisto |
last post by:
Is there a way to create an alert-like message box that uses a custom
image? Basically, I want to replace the default ! image with something else.
--
Justin Koivisto - spam@koivi.com
PHP...
|
by: optimistx |
last post by:
How to write a function f(x) or f('x') so that it produces the same output
as a call to alert-function:
var x='abc';
alert('x='+x);
In testing one needs to write similar alert() calls...
|
by: schieco |
last post by:
The following code always prints the debug lines inside the
conditional if statement before and after the alert statement when the
session has timed out, but the alert and redirect only appear/work...
|
by: hugo2 |
last post by:
Most of these characters are not on the standard keyboard.
Here's a successful contrivance, with comments & cautions,
a little page that works in IE6.
<HTML><HEAD><SCRIPT TYPE="text/javascript">...
|
by: Alistair Saldanha |
last post by:
I'm looking for the event that is fired by Internet Explorer to an "alert":
<SCRIPT>
Alert("You already have a session open")
</SCRIPT>
The event would be webBrowser.Document.????
Much...
|
by: clentoc |
last post by:
I'm pretty new to javascript so this may well be a really basic error, but I've spent hours trying to fix it with no joy.
I have written some code which looks in a CSV file, filters it depending...
|
by: pantagruel |
last post by:
Hi,
the following works in FF but not IE:
Object.prototype.describe=function(){alert("Description: " +
this);return this}
alert.describe();
The question I have is mainly how can one go about...
|
by: axapta |
last post by:
Hi Guys,
I'm using this code in my asp.net page. It runs from a button webcontrol.
Dim sbJScript As String
sbJScript = "<script language = ""javascript"">"
sbJScript = sbJScript &...
|
by: Jeremy J Starcher |
last post by:
While reading c.l.j, I've noticed that some people prefer and indeed even
recommend the use of "window.alert()" over "alert()".
I can't find any technical reason to make this distinction, and...
|
by: Peter |
last post by:
I need a popup alert after a post back.
1) user clicks on the submit button
2) Server side code runs and if the result is false I want to display a java
script alert("It did not work")
How to...
|
by: Faith0G |
last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome former...
|
by: ryjfgjl |
last post by:
In our work, we often need to import Excel data into databases (such as MySQL, SQL Server, Oracle) for data analysis and processing. Usually, we use database tools like Navicat or the Excel import...
|
by: taylorcarr |
last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
|
by: aa123db |
last post by:
Variable and constants
Use var or let for variables and const fror constants.
Var foo ='bar';
Let foo ='bar';const baz ='bar';
Functions
function $name$ ($parameters$) {
}
...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: Sonnysonu |
last post by:
This is the data of csv file
1 2 3
1 2 3
1 2 3
1 2 3
2 3
2 3
3
the lengths should be different i have to store the data by column-wise with in the specific length.
suppose the i have to...
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
| |
